From patchwork Thu Apr 27 18:38:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 41388 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:dca6:b0:f3:34fa:f187 with SMTP id ky38csp740032pzb; Thu, 27 Apr 2023 11:39:10 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7QhqfElmcVlXBA3ksq+GR6Rph4xDhVJK5Mb0xgOwd1/byWUo3rcEiSt2dQmijb+eMpBxN3 X-Received: by 2002:aa7:cc85:0:b0:508:3ff8:afe7 with SMTP id p5-20020aa7cc85000000b005083ff8afe7mr2359581edt.6.1682620750187; Thu, 27 Apr 2023 11:39:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682620750; cv=none; d=google.com; s=arc-20160816; b=KD363CVRBsfSg+9Q758j9qbJ8PMuBEiE5pInPcEQE/ckHyROzuHKbCqIF8xiK0hFiX ZlFG3RQZJsDsbwVT/znd6ElLD93Ff9wtkrrAmXtHWtixdCO4vBc21nnNblRhkSAwhZAj BFLAG/bR5t1YSNQ6Eq2PobISoqJyXv3sBSo8jfwnaNPPP+nQyN576XtYfNt/yVXEvA7H YJfK8OCC4Qk4sMjp2aOpihjKDx+8GuFe4hWXXE17cjPpeHjYmU4I7OXg8KEtwKK88TtU GOL+b4lAz8jdRQuXT4eTW4WKKcOchRpAm4GFESLVPtV7YARV3dQzmqzTKcPJQX1mrCXs wuGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:delivered-to; bh=XTin0NA9JPSDpeaTS+mzMAs5IBLnn+EMPwIrT1PEjfo=; b=rwTMhwSXPtLN4oJKAy60h7VMjf9+EI/7Ln9zMvAriSfYd89rhFPGh0lPOtvarc61WZ 5nBj+Op0d6jmtfjGZo/wV97zcEgoV8BzZQP+6jewTnMwXSq/iUNyEVX2vlU2lZjS4hAL VZyfBAeepDORMEjJUnXwfITTkjJdsxQ1UUa/95X8pR5IC7uqPG7LS0xEuw1i6C5eaONw 1d3mx19YuubQOy+6KiSPOxoqUYwjNm7BNMqJzFf2lHlzdUy4dro8eePOXn9pP8hyw+Fq 1Elb14K5jWt8OvcH+uy3R3dBPR0sGnKiW1h4yvtj7RXEWxWXOZGjW0TaxdWmkjZAipAy haZQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id ca8-20020aa7cd68000000b005083db60638si12386731edb.590.2023.04.27.11.39.09; Thu, 27 Apr 2023 11:39:10 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2E64868BF5C; Thu, 27 Apr 2023 21:38:52 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CD36468BF4F for ; Thu, 27 Apr 2023 21:38:44 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 0EEB960002 for ; Thu, 27 Apr 2023 18:38:43 +0000 (UTC) From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Thu, 27 Apr 2023 20:38:40 +0200 Message-Id: <20230427183840.1015-3-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230427183840.1015-1-michael@niedermayer.cc> References: <20230427183840.1015-1-michael@niedermayer.cc> Subject: [FFmpeg-devel] [PATCH 3/3] avcodec/hevc_ps: Avoid signed overflow before check on QP X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: Q5fubF2+He/1 Fixes: signed integer overflow: -2147483648 - 5 cannot be represented in type 'int' Fixes: 58066/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-5312995835379712 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/hevc_ps.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/hevc_ps.c b/libavcodec/hevc_ps.c index 1533e2a817..6b8f432609 100644 --- a/libavcodec/hevc_ps.c +++ b/libavcodec/hevc_ps.c @@ -1522,9 +1522,9 @@ static int pps_scc_extension(GetBitContext *gb, AVCodecContext *avctx, pps->pps_curr_pic_ref_enabled_flag = get_bits1(gb); if (pps->residual_adaptive_colour_transform_enabled_flag = get_bits1(gb)) { pps->pps_slice_act_qp_offsets_present_flag = get_bits1(gb); - pps->pps_act_y_qp_offset = get_se_golomb_long(gb) - 5; - pps->pps_act_cb_qp_offset = get_se_golomb_long(gb) - 5; - pps->pps_act_cr_qp_offset = get_se_golomb_long(gb) - 3; + pps->pps_act_y_qp_offset = get_se_golomb_long(gb) - 5U; + pps->pps_act_cb_qp_offset = get_se_golomb_long(gb) - 5U; + pps->pps_act_cr_qp_offset = get_se_golomb_long(gb) - 3U; #define CHECK_QP_OFFSET(name) (pps->pps_act_ ## name ## _qp_offset <= -12 || \ pps->pps_act_ ## name ## _qp_offset >= 12)