From patchwork Wed May 17 10:20:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anton Khirnov X-Patchwork-Id: 41679 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:ba91:b0:105:feb:71f2 with SMTP id fb17csp1079588pzb; Wed, 17 May 2023 03:24:27 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5QAI7LwYuXxc7rnJjA0phyhSL19BlkSaCzhZnA1mFmYLqMynHW7ecJbGJgiqcLFa1UEDo6 X-Received: by 2002:aa7:da98:0:b0:505:4f7:8a50 with SMTP id q24-20020aa7da98000000b0050504f78a50mr1839350eds.5.1684319066950; Wed, 17 May 2023 03:24:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684319066; cv=none; d=google.com; s=arc-20160816; b=ccRUyUmCxKw8Lx9Ur1WSZ88S/erByb9+U6IPuF0O0fLcLF7e9hqCiWEmT289WnLFVd N+V3U583PtO86q9481Bg++bAoMU7/p+dU+qkw1lWCoKjB62SEGBEqcY3OPHhUiWG5ido Ei1oZXlHePqNQs81cmH+qecIPNg/qC4ojmTwV/36nZFGV94OnFO2QrHVaM+wVNTCTDbu beqspXBnrBEIOjd5FAetz/U2Fl2q9qwRZaiSielpc5tB4E6ddOWoq75XG9HDtCGFaiQn ewYiuvyCJ5qSCmDaVOeemB0c87k+TDfWxO2uryvg1uCkVbke41kwTvOInKjNepVpctlU wmLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:delivered-to; bh=lWY84YhA7zO6a+LYq+zqB+MTgxyobKfnJQyPJkPqKCE=; b=qXfEodMLpS2U9SzjU4u1dy9cgTj/AvwUY6IPtFQRijFn0WMFHtbbIQOLjPEN92i1Bq hjtZpfu+wMS2iss3yzds7+tjnuzQz4FTHVEMKBy0RzDMGDDvG2IePCQFZTm4EyjWzfOd PNUHO3c/80NOwGjersqyh+r48iATfEjbE3Sc3AUyHHxg9cBHg6p2ipiYnMlkMYwJQbNj k/SkQnBGNGWyVgrvyQNk3+zzPwg7el+xAhcFo2hdUOzROBQ4iM/mx2HN5hofYt+72duT j0QV2R+K6rpKG16FIm1vE3QM+Kd/o4ahTBNw/NTFDgHJhfuOUTPtO7TzIrVcKythgQVA FybA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id y13-20020a50eb0d000000b0050de918773fsi11827699edp.12.2023.05.17.03.24.26; Wed, 17 May 2023 03:24:26 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 851F568C1C7; Wed, 17 May 2023 13:21:16 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3F38B68C13B for ; Wed, 17 May 2023 13:20:53 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id F2FFD2406CD for ; Wed, 17 May 2023 12:20:51 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id Y4WDS8xxYid6 for ; Wed, 17 May 2023 12:20:51 +0200 (CEST) Received: from libav.khirnov.net (libav.khirnov.net [IPv6:2a00:c500:561:201::7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "libav.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 1B30C2406CC for ; Wed, 17 May 2023 12:20:46 +0200 (CEST) Received: from libav.khirnov.net (libav.khirnov.net [IPv6:::1]) by libav.khirnov.net (Postfix) with ESMTP id 1AA3B3A17DA for ; Wed, 17 May 2023 12:20:40 +0200 (CEST) From: Anton Khirnov To: ffmpeg-devel@ffmpeg.org Date: Wed, 17 May 2023 12:20:09 +0200 Message-Id: <20230517102029.541-16-anton@khirnov.net> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230517102029.541-1-anton@khirnov.net> References: <20230517102029.541-1-anton@khirnov.net> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 16/36] fftools/ffmpeg_filter: drop a redundant error message X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: thvvL0APbfQk In case no decoder is available, dec_open() called from ist_use() will fail with 'Decoding requested, but no decoder found', so this check is redundant. --- fftools/ffmpeg_filter.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index 12e756e489..16f29a313f 100644 --- a/fftools/ffmpeg_filter.c +++ b/fftools/ffmpeg_filter.c @@ -1201,12 +1201,6 @@ static int configure_input_audio_filter(FilterGraph *fg, InputFilter *ifilter, static int configure_input_filter(FilterGraph *fg, InputFilter *ifilter, AVFilterInOut *in) { - if (!ifilter->ist->dec) { - av_log(NULL, AV_LOG_ERROR, - "No decoder for stream #%d:%d, filtering impossible\n", - ifilter->ist->file_index, ifilter->ist->st->index); - return AVERROR_DECODER_NOT_FOUND; - } switch (avfilter_pad_get_type(in->filter_ctx->input_pads, in->pad_idx)) { case AVMEDIA_TYPE_VIDEO: return configure_input_video_filter(fg, ifilter, in); case AVMEDIA_TYPE_AUDIO: return configure_input_audio_filter(fg, ifilter, in);