diff mbox series

[FFmpeg-devel] fftools/ffmpeg_dec: abort if avcodec_send_packet() returns EAGAIN

Message ID 20230522221826.3124-1-jamrial@gmail.com
State New
Headers show
Series [FFmpeg-devel] fftools/ffmpeg_dec: abort if avcodec_send_packet() returns EAGAIN | expand


Context Check Description
andriy/make_x86 fail Make failed

Commit Message

James Almer May 22, 2023, 10:18 p.m. UTC
As the comment in the code mentions, EAGAIN is not an expected value here
because we call avcodec_receive_frame() until all frames have been returned.
avcodec_send_packet() returning EAGAIN means a packet is still buffered, which
hints that the underlying decoder is buggy and not fetching packets as it

An example of this behavior was in the libdav1d wrapper before f209614290,
where feeding it split frames (or individual OBUs) would result in the CLI
eventually printing the unuseful "Error submitting packet to decoder: Resource
temporarily unavailable" error message, and just keep until EOF without
returning new frames.

Signed-off-by: James Almer <jamrial@gmail.com>
 fftools/ffmpeg_dec.c | 5 +++++
 1 file changed, 5 insertions(+)
diff mbox series


diff --git a/fftools/ffmpeg_dec.c b/fftools/ffmpeg_dec.c
index e06747d9c4..85064f061a 100644
--- a/fftools/ffmpeg_dec.c
+++ b/fftools/ffmpeg_dec.c
@@ -390,6 +390,11 @@  int dec_packet(InputStream *ist, const AVPacket *pkt, int no_eof)
     if (ret < 0 && !(ret == AVERROR_EOF && !pkt)) {
         // In particular, we don't expect AVERROR(EAGAIN), because we read all
         // decoded frames with avcodec_receive_frame() until done.
+        if (ret == AVERROR(EAGAIN) {
+            av_log(ist, AV_LOG_FATAL, "A decoder returned an unexpected error code. "
+                   "This is a bug, please report it.\n");
+            exit_program(1);
+        }
         av_log(ist, AV_LOG_ERROR, "Error submitting %s to decoder: %s\n",
                pkt ? "packet" : "EOF", av_err2str(ret));
         if (exit_on_error)