From patchwork Tue May 23 13:58:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anton Khirnov X-Patchwork-Id: 41795 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:c51c:b0:10c:5e6f:955f with SMTP id gm28csp600256pzb; Tue, 23 May 2023 06:59:23 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5iM2x4Mmyg3F9ChPluBf6rEBrchQXWhUO97W+IMsD+eW//GtcTAS4DEvoQNarjs2F2ptI6 X-Received: by 2002:a17:907:6287:b0:965:d18b:f03a with SMTP id nd7-20020a170907628700b00965d18bf03amr14038063ejc.58.1684850363056; Tue, 23 May 2023 06:59:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684850363; cv=none; d=google.com; s=arc-20160816; b=vLlRLihVJsNRN9ihTwNo2FZtDTykWEHuuHf5dh1R0yCiDGaicAhebuBRY7SgIKQVi/ SlF3vmoiqqyYv5/oPdj/Wu9dNp03uUAC6MC/GHTJp9U9sLfat//0j59VhP2iiUmlvdQ1 18wbhoRZuueO4vL+5c/MKODhbmsLZB+oRA57j3sNUVsnq/Zw3o5QOhIbfW557krecjyA c4ARdOsgVY8HGP687UTPz7aS/Li393WfaDHlDZMwvYhe7AER5/uP4jxM5xzTjJjHdWLo KHT2iIqyh9f749S9xlSHzqMkzPhcuzSdOfyuoRQLttbSmebunUUULA/5f3ZA3oKqSJlS Aleg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:delivered-to; bh=6YGU1zF5GORGE77RYd1NWN0LLJ+gc14olIjaA+43HIY=; b=McS8NsyFJT/T8xIjCrOcGfpGh1IARoedDhjNPOFnyROUN3WrNs+mxoFnLfkvcP4hO3 YY6KeqerWwhuzMslyIfxaJQeMcZ/CP3+dpIvAzzj6UsMHTbw+PrjbzyjJ850z1ZSlYq2 W20Ky0Lph3XCEyQDk2I+QRsSkftBT4pJ3HtR0CjLyit9RUWc8rZ/kXVeq/Q3UgWSCWl1 HzrFpN4qey5APk0aODx/jFpz8MEJQLEdcmMXJyZq6uMlaL6P31G5mRMQPTreeDVrHji8 nMmBF5ZEU74kSp/93f86bO+H7iljz9YUdQxLOh5PcArFEVvn38TPDHQAVQ39lhl2otAi GEmA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id h22-20020a170906829600b00965f171543esi6007147ejx.148.2023.05.23.06.59.22; Tue, 23 May 2023 06:59:23 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 13B0F68C030; Tue, 23 May 2023 16:59:05 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 42D6768BFFE for ; Tue, 23 May 2023 16:58:50 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 0566D240177 for ; Tue, 23 May 2023 15:58:50 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id 9xy3FBnzVbjh for ; Tue, 23 May 2023 15:58:49 +0200 (CEST) Received: from libav.khirnov.net (libav.khirnov.net [IPv6:2a00:c500:561:201::7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "libav.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 7060C2404EE for ; Tue, 23 May 2023 15:58:48 +0200 (CEST) Received: from libav.khirnov.net (libav.khirnov.net [IPv6:::1]) by libav.khirnov.net (Postfix) with ESMTP id 5BD0C3A1267 for ; Tue, 23 May 2023 15:58:48 +0200 (CEST) From: Anton Khirnov To: ffmpeg-devel@ffmpeg.org Date: Tue, 23 May 2023 15:58:33 +0200 Message-Id: <20230523135842.20388-6-anton@khirnov.net> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230523135842.20388-1-anton@khirnov.net> References: <20230523135842.20388-1-anton@khirnov.net> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 06/15] fftools/ffmpeg_demux: only print demuxing stats if demuxing actually started X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: ih5+qgDymr3g If the transcoding process never got to reading any packets from this input then printing stats is just pointless noise. --- fftools/ffmpeg_demux.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c index 7318abc6d9..ed8d5d165a 100644 --- a/fftools/ffmpeg_demux.c +++ b/fftools/ffmpeg_demux.c @@ -113,6 +113,8 @@ typedef struct Demuxer { int thread_queue_size; pthread_t thread; int non_blocking; + + int read_started; } Demuxer; typedef struct DemuxMsg { @@ -734,6 +736,8 @@ static int thread_start(Demuxer *d) goto fail; } + d->read_started = 1; + return 0; fail: av_thread_message_queue_free(&d->in_thread_queue); @@ -833,7 +837,7 @@ void ifile_close(InputFile **pf) thread_stop(d); - if (f->ctx) + if (d->read_started) demux_final_stats(d); for (int i = 0; i < f->nb_streams; i++)