From patchwork Sun Jun 18 21:50:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 42209 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:be15:b0:121:b37c:e101 with SMTP id ge21csp314262pzb; Sun, 18 Jun 2023 14:50:50 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7ZOGbsfyDCkGdM+UKJQy4ClALxtuQqbEjROnX/uOb3ITccUJce3FZxkQ6zd9nepseZ8jav X-Received: by 2002:a17:906:dacb:b0:94e:e6b9:fef2 with SMTP id xi11-20020a170906dacb00b0094ee6b9fef2mr7149423ejb.67.1687125049983; Sun, 18 Jun 2023 14:50:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687125049; cv=none; d=google.com; s=arc-20160816; b=cAkinN+T68uXQMH9JlcexaplLg90FjrNN/anDzEiMfB5EmZTNXxgSs5C1m3cuJRS/j sE/sEQ1asLPi6gOHCgTSG5f+65iB8s6R6hUW8cPxH7qf4Ssr68OZ+4YX0DNiDLWPGetV NAgKWXkIwo0RYJZnY7iwwZj5WZ0dvO6Vs/P0ccr4ZDQmkeIJ16ugYtotIDfs99HUF1nW djv5cowsDLrd4yYoTTZfClFqteJNYc9eYiLEtqSgkj98xnda3s32/nkt+9mW/hCXIvoL E+0APm0+qmibjHco1CHVrykdtCuqw2BgfQC5F0OhX1ZROa4exhJxlHxKymgRTRNIu5zm wSAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:delivered-to; bh=7txo7otbqqcNTIRV4pm2/Hcj2drv3UR91tI7omKFzC8=; b=eIyjrl6tDbjNq1vKPid1Jt1NlkfFIf1kJDnrEBKDUCDtTfxJbMZJmQww2HdRHscKK/ m+wNGs0kBlhIe6HJbfDSnVcc/OU332R+G7SlkAjJKt7QyluqcorUDXoblKibJOW8SyKo 5f7FL/x9S/tPXyxQ96HubecJ/+nyhv3FPDtSxLuvtSJAW0PhJ6uhp4gam9LYFBrIwt63 zCZXCkxP9C5kT++Q3YlPoCvqBomUC09As7aJoAynr/ylDJe+9oUSNLFQ3cxRNrctOBcw kp/EHkMjfiULvaDtkg+8amsk5kJl64b/doX9vHdijgwdLgEZs3JKAxbKqDGSKUl8ohk1 gQLQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id lv19-20020a170906bc9300b00987dbbdae33si1635302ejb.629.2023.06.18.14.50.49; Sun, 18 Jun 2023 14:50:49 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8E87368BC18; Mon, 19 Jun 2023 00:50:31 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-02-2.mymagenta.at (mail-02-2.mymagenta.at [80.109.253.249]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 90FB668BF22 for ; Mon, 19 Jun 2023 00:50:24 +0300 (EEST) Received: from [192.168.232.136] (helo=ren-mail-psmtp-mg02.) by mail-02.mymagenta.at with esmtp (Exim 4.93) (envelope-from ) id 1qB0Hw-000jd7-BH for ffmpeg-devel@ffmpeg.org; Sun, 18 Jun 2023 23:50:24 +0200 Received: from localhost ([84.115.40.24]) by ren-mail-psmtp-mg02. with ESMTP id B0HxqrzPJbZLDB0HxquNIF; Sun, 18 Jun 2023 23:50:25 +0200 X-Env-Mailfrom: michael@niedermayer.cc X-Env-Rcptto: ffmpeg-devel@ffmpeg.org X-SourceIP: 84.115.40.24 X-CNFS-Analysis: v=2.4 cv=Ufwy9IeN c=1 sm=1 tr=0 ts=648f7c21 a=4thelYDX6rwh+ygQwvsI+Q==:117 a=4thelYDX6rwh+ygQwvsI+Q==:17 a=MKtGQD3n3ToA:10 a=1oJP67jkp3AA:10 a=GEAsPZ9sns4A:10 a=c5RBGETicSnhGOyKd9QA:9 From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Sun, 18 Jun 2023 23:50:21 +0200 Message-Id: <20230618215021.3044-6-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230618215021.3044-1-michael@niedermayer.cc> References: <20230618215021.3044-1-michael@niedermayer.cc> X-CMAE-Envelope: MS4xfItjIY6R5NtTsVRPMZxDxL8H/OLW36c+0a/xRsHLMYGP/kIijkRtWZMMeEDfnXItg4TMfPKF1nuYBvDd2qBaFI6Pwz5udjvKoU2Bcj4UlJr3xusmlKXI CGVI6DiDbgLbydOZwaIA3+Agad1iTR05VIh1QHsIExbSPO5EnX/pfj2/JCNhM6PzIuaTznZgGvPBgw== Subject: [FFmpeg-devel] [PATCH 6/6] doc/developer: Require new modules to include tests X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: jvoLttQC44Ci Signed-off-by: Michael Niedermayer --- doc/developer.texi | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/doc/developer.texi b/doc/developer.texi index a7da2ce2d5..0c2f2cd7d1 100644 --- a/doc/developer.texi +++ b/doc/developer.texi @@ -805,7 +805,10 @@ Lines with similar content should be aligned vertically when doing so improves readability. @item -Consider adding a regression test for your code. +Consider adding a regression test for your code. All new modules +should be covered by tests. That includes demuxers, muxers, decoders, encoders +filters, bitstream filters, parsers. If its not possible to do that, add +an explanation why to your patchset, its ok to not test if theres a reason. @item If you added YASM code please check that things still work with --disable-yasm.