From patchwork Sat Jul 8 15:06:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 42528 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:6d25:b0:130:f365:34ad with SMTP id fv37csp517863pzb; Sat, 8 Jul 2023 08:06:27 -0700 (PDT) X-Google-Smtp-Source: APBJJlHjH6Z5uqrHefoeGMqjiCW9gmvPFa2xJ97QOU6PRR09yHvvUbU+fpMb2QxO7cQtT9jHW9Zi X-Received: by 2002:a17:906:10cf:b0:993:e81a:f093 with SMTP id v15-20020a17090610cf00b00993e81af093mr2211935ejv.26.1688828787102; Sat, 08 Jul 2023 08:06:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688828787; cv=none; d=google.com; s=arc-20160816; b=FqR3AP2Son0oRinF4LYf/cJ4Ki5UXgIQLKaXIcqf8s5qmxHFHOhMMoIZRKTCS5bNRT oSMqfFPCgrdYG6P+XnQz9dNRpEhi+EN5rS/+KpvNvbBrlVioIrfAZcJpZLBIBDPwdweG SXVWfoNAKRt8sMEGqFxrC3lqlHG2pxkX1CwcOLbz9QxPJB6nHkYkwk7ieet9OF+/mfHm UR2RnsIFSORGuLyWitzHK0kO2oxq/NbqHM1R6BrnfcCshvk+204bex/zfIKHoJy6hisn YaGoHlrpP5vvHXba4SvM1F29vZmV7Qve47mi2xoAOnsWqnX5wWhk3Yz5tMv6jukmH1HO LGyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:delivered-to; bh=yC6JGgfYakeTJyzMjpbxd2gJS0EkS27H7oFWq0JEq6g=; fh=YYwLYmpaV0Fpw/rxmSKNRLS2XzDkAlGbHATiKOPtZrY=; b=pmvzB1c/u6jgEyBegJ6751rzGIfjtusu40gIrooWvcEhWtQGHXZfSqrwbmIYyqCulw b9Ae0lwIVZ2DziNDnKA4KXaOPZT97CTd+6iX2rZ2AvO3DD5v3Zr8TFMO9f57gHjsA1Z7 30/XBtKl40U58kg5viIdqOHyxf4/R60fjQo4rFpHUUO9WDX5JaYNricrhNpoNEwssc8+ 6dmEemynJY10bzJ0lCSBsOkBPf+MrmtsNvhidA9PVuPASJP2N/frql2ZQ6q2pndqPIWm qp+LeDKBLyKC6H5O1WYezMX671TDWj8s+Mp2NxJqch7qMUl+pIr5qfWMfQo+7uNwS1o8 UCWw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id d18-20020a17090648d200b0098ddf0dcf02si3717472ejt.157.2023.07.08.08.06.25; Sat, 08 Jul 2023 08:06:27 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 99C7868C4EE; Sat, 8 Jul 2023 18:06:21 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-02-2.mymagenta.at (mail-02-2.mymagenta.at [80.109.253.249]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0DD9068C38E for ; Sat, 8 Jul 2023 18:06:14 +0300 (EEST) Received: from [192.168.232.135] (helo=ren-mail-psmtp-mg01.) by mail-02.mymagenta.at with esmtp (Exim 4.93) (envelope-from ) id 1qI9Vm-006Arn-84 for ffmpeg-devel@ffmpeg.org; Sat, 08 Jul 2023 17:06:14 +0200 Received: from localhost ([84.115.40.24]) by ren-mail-psmtp-mg01. with ESMTP id I9VjqXG5lOG5ZI9Vjqevg6; Sat, 08 Jul 2023 17:06:12 +0200 X-Env-Mailfrom: michael@niedermayer.cc X-Env-Rcptto: ffmpeg-devel@ffmpeg.org X-SourceIP: 84.115.40.24 X-CNFS-Analysis: v=2.4 cv=KJo5sHJo c=1 sm=1 tr=0 ts=64a97b64 a=4thelYDX6rwh+ygQwvsI+Q==:117 a=4thelYDX6rwh+ygQwvsI+Q==:17 a=MKtGQD3n3ToA:10 a=1oJP67jkp3AA:10 a=GEAsPZ9sns4A:10 a=hGrV9KBr6KBgawsg_h0A:9 From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Sat, 8 Jul 2023 17:06:09 +0200 Message-Id: <20230708150609.6304-2-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230708150609.6304-1-michael@niedermayer.cc> References: <20230708150609.6304-1-michael@niedermayer.cc> X-CMAE-Envelope: MS4xfGI5v5MMaoysbDHDt38Ch9lQAB4JkX6FMYa/iap8XlSeCdgu7PpA1/eejHrc1HkfTWrkIyEHefhVrcxe76XZ19/T1aYn838+HkcI/HSElQf0Ank7fuTW h/Mm9Ey0y27P+UVhlf1erQ1asFhWDg3w0jsDZiRIpPyuN1RBZdkDxr7t5YIKXhvWX0DIdEXlzL3Xcw== Subject: [FFmpeg-devel] [PATCH] doc/developer: Alternative to making tests a requirement. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: xUxfSFnL3nPu Making tests a strict requirement could increase the burden on new developers. This is an alternative Signed-off-by: Michael Niedermayer --- doc/developer.texi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/developer.texi b/doc/developer.texi index 0c2f2cd7d1..c7536a17b6 100644 --- a/doc/developer.texi +++ b/doc/developer.texi @@ -809,6 +809,8 @@ Consider adding a regression test for your code. All new modules should be covered by tests. That includes demuxers, muxers, decoders, encoders filters, bitstream filters, parsers. If its not possible to do that, add an explanation why to your patchset, its ok to not test if theres a reason. +If your module lacks a test, then you must provide all information and samples +which are needed for someone else to create a test, limited by what you possess. @item If you added YASM code please check that things still work with --disable-yasm.