From patchwork Thu Jul 13 10:55:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anton Khirnov X-Patchwork-Id: 42652 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:6da1:b0:131:a7d0:bc6d with SMTP id gl33csp2823345pzb; Thu, 13 Jul 2023 04:00:21 -0700 (PDT) X-Google-Smtp-Source: APBJJlG0PX57V6i8n8i7ImFsgwfEkEDaBg75WMTRcbuJ7e24EUKeWVJ1KPo22sD+LA5/1Z31gN9i X-Received: by 2002:a17:906:6890:b0:992:a257:560d with SMTP id n16-20020a170906689000b00992a257560dmr1076285ejr.35.1689246021340; Thu, 13 Jul 2023 04:00:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689246021; cv=none; d=google.com; s=arc-20160816; b=zwymGoQ0w588yAgBdxjk08mcnr2OKQIv86A4D1ZmhnzuD1P1OkLA3d30esvw3nvAMu 8xYSRMrh6ZiML5uOuaigzi/yRaatXs0fR8bPhqVUQYvHOmD4fHoraEnmzVlMPCCRw7zP yq3rwAvp7nnUaVvs0gZjAEezKhd7butvfakTderWJr8hm4GCX/IIaRNswagT8dnAYSdD aoDssf3rP/ad1tBZgwC9Q7yMWNyGEGbuLWP7MJIabDh0vLsKZk4UNNgoE2/GunOa1jkl NCTeGo7NlQAJFHu7cs3grs0bW3mMCpm3PmtLNvqJAd3GeT+jRLCi930jlWowCEEYkPiX qMbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:delivered-to; bh=lvAq3iOc1AYEYTN63gsqdSNdzUFXMXfG2pRpGFBCNd0=; fh=8ZF2QtiKOjBtyn9wuO2cMeZaLsE4aq02Bq77gGK61E8=; b=MaGuMKkH52/KLxiBi6XWsfajGQ2EpBhr/JlrWAH7apfUMn6s96aWqAtZQfSj2BBxxY PIXntG9ppDTwAHJJNZwqJxV7JZlTidupMvrv01OCWBh9YrR6CMv1Sns7Bkxf7zGgnNf/ iy/wEYDQMaX+jEHelQIoTU9bJO2uSTOks4EOZOlMjrImEne1xQNVCbhiijaUdE9udoD9 rNTekjDpKYGq+lAE5rwoECqaLBIEMeasvYoIGfCppQzblUmjok+ySNCLGsvcBbkLxSKB 8+kbMpEuM0h56ncq5oqLIqXKMIl1ayhVjrrqJ46qDhbWw+QIjCXNA1fTx5cqM7M+jILP X6sg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id y17-20020a170906559100b00992d0de875esi7126283ejp.914.2023.07.13.04.00.20; Thu, 13 Jul 2023 04:00:21 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5EB0568C6F9; Thu, 13 Jul 2023 13:58:08 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5D89468C695 for ; Thu, 13 Jul 2023 13:57:53 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 19F042404EA for ; Thu, 13 Jul 2023 12:57:53 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id 7kt9xam3np44 for ; Thu, 13 Jul 2023 12:57:52 +0200 (CEST) Received: from libav.khirnov.net (libav.khirnov.net [IPv6:2a00:c500:561:201::7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "libav.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id C629A240D1D for ; Thu, 13 Jul 2023 12:57:41 +0200 (CEST) Received: from libav.khirnov.net (libav.khirnov.net [IPv6:::1]) by libav.khirnov.net (Postfix) with ESMTP id 6EA043A222F for ; Thu, 13 Jul 2023 12:57:36 +0200 (CEST) From: Anton Khirnov To: ffmpeg-devel@ffmpeg.org Date: Thu, 13 Jul 2023 12:55:52 +0200 Message-Id: <20230713105553.21052-32-anton@khirnov.net> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230713105553.21052-1-anton@khirnov.net> References: <20230713105553.21052-1-anton@khirnov.net> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 32/33] fftools/ffmpeg: rework -enc_time_base handling X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: Qw/q7q+k6R27 Read the timebase from FrameData rather than the input stream. This should fix #10393 and generally be more reliable. Replace the use of '-1' to indicate demuxing timebase with the string 'demux'. Also allow to request filter timebase with '-enc_time_base filter'. --- doc/ffmpeg.texi | 7 ++++--- fftools/ffmpeg.h | 6 ++++++ fftools/ffmpeg_enc.c | 16 ++++++++++++++-- fftools/ffmpeg_mux_init.c | 31 +++++++++++++++++++------------ tests/fate/video.mak | 2 +- 5 files changed, 44 insertions(+), 18 deletions(-) diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi index 08b11097b7..b41e4d9272 100644 --- a/doc/ffmpeg.texi +++ b/doc/ffmpeg.texi @@ -1811,10 +1811,11 @@ Assign a default value according to the media type. For video - use 1/framerate, for audio - use 1/samplerate. -@item -1 -Use the input stream timebase when possible. +@item demux +Use the timebase from the demuxer. -If an input stream is not available, the default timebase will be used. +@item filter +Use the timebase from the filtergraph. @item >0 Use the provided number as the timebase. diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index 97aa4d716e..f45ddf33b2 100644 --- a/fftools/ffmpeg.h +++ b/fftools/ffmpeg.h @@ -56,6 +56,7 @@ #define FFMPEG_ROTATION_METADATA 1 #define FFMPEG_OPT_QPHIST 1 #define FFMPEG_OPT_ADRIFT_THRESHOLD 1 +#define FFMPEG_OPT_ENC_TIME_BASE_NUM 1 enum VideoSyncMethod { VSYNC_AUTO = -1, @@ -66,6 +67,11 @@ enum VideoSyncMethod { VSYNC_DROP, }; +enum EncTimeBase { + ENC_TIME_BASE_DEMUX = -1, + ENC_TIME_BASE_FILTER = -2, +}; + #define MAX_STREAMS 1024 /* arbitrary sanity check value */ enum HWAccelID { diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c index 0e2285c5a2..1489b2f179 100644 --- a/fftools/ffmpeg_enc.c +++ b/fftools/ffmpeg_enc.c @@ -264,8 +264,20 @@ int enc_open(OutputStream *ost, AVFrame *frame) fr.num, fr.den, 65535); } - enc_ctx->time_base = ost->enc_timebase.num > 0 ? ost->enc_timebase : - av_inv_q(fr); + if (ost->enc_timebase.num == ENC_TIME_BASE_DEMUX) { + if (fd->dec.tb.num <= 0 || fd->dec.tb.den <= 0) { + av_log(ost, AV_LOG_ERROR, + "Demuxing timebase not available - cannot use it for encoding\n"); + return AVERROR(EINVAL); + } + + enc_ctx->time_base = fd->dec.tb; + } else if (ost->enc_timebase.num == ENC_TIME_BASE_FILTER) { + enc_ctx->time_base = frame->time_base; + } else { + enc_ctx->time_base = ost->enc_timebase.num > 0 ? ost->enc_timebase : + av_inv_q(fr); + } if (!(enc_ctx->time_base.num && enc_ctx->time_base.den)) enc_ctx->time_base = frame->time_base; diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c index 4434e6b70d..2d45fa7c7c 100644 --- a/fftools/ffmpeg_mux_init.c +++ b/fftools/ffmpeg_mux_init.c @@ -1220,20 +1220,27 @@ static int ost_add(Muxer *mux, const OptionsContext *o, enum AVMediaType type, MATCH_PER_STREAM_OPT(enc_time_bases, str, enc_time_base, oc, st); if (enc_time_base) { AVRational q; - if (av_parse_ratio(&q, enc_time_base, INT_MAX, 0, NULL) < 0 || - q.den <= 0) { - av_log(ost, AV_LOG_FATAL, "Invalid time base: %s\n", enc_time_base); - return AVERROR(EINVAL); - } - if (q.num < 0) { - if (!ost->ist) { - av_log(ost, AV_LOG_FATAL, - "Cannot use input stream timebase for encoding - " - "no input stream available\n"); - return AVERROR(EINVAL); + if (!strcmp(enc_time_base, "demux")) { + q = (AVRational){ ENC_TIME_BASE_DEMUX, 0 }; + } else if (!strcmp(enc_time_base, "filter")) { + q = (AVRational){ ENC_TIME_BASE_FILTER, 0 }; + } else { + ret = av_parse_ratio(&q, enc_time_base, INT_MAX, 0, NULL); + if (ret < 0 || q.den <= 0 +#if !FFMPEG_OPT_ENC_TIME_BASE_NUM + || q.num < 0 +#endif + ) { + av_log(ost, AV_LOG_FATAL, "Invalid time base: %s\n", enc_time_base); + return ret < 0 ? ret : AVERROR(EINVAL); } - q = ost->ist->st->time_base; +#if FFMPEG_OPT_ENC_TIME_BASE_NUM + if (q.num < 0) + av_log(ost, AV_LOG_WARNING, "-enc_time_base -1 is deprecated," + " use -enc_timebase demux\n"); +#endif } + ost->enc_timebase = q; } } else { diff --git a/tests/fate/video.mak b/tests/fate/video.mak index a2011d0dad..4e7a77537f 100644 --- a/tests/fate/video.mak +++ b/tests/fate/video.mak @@ -270,7 +270,7 @@ FATE_VIDEO-$(call FRAMECRC, MXG, MXPEG) += fate-mxpeg fate-mxpeg: CMD = framecrc -idct simple -flags +bitexact -i $(TARGET_SAMPLES)/mxpeg/m1.mxg -an FATE_NUV += fate-nuv-rtjpeg -fate-nuv-rtjpeg: CMD = framecrc -idct simple -i $(TARGET_SAMPLES)/nuv/Today.nuv -an -enc_time_base -1 +fate-nuv-rtjpeg: CMD = framecrc -idct simple -i $(TARGET_SAMPLES)/nuv/Today.nuv -an -enc_time_base demux FATE_NUV += fate-nuv-rtjpeg-fh fate-nuv-rtjpeg-fh: CMD = framecrc -idct simple -i $(TARGET_SAMPLES)/nuv/rtjpeg_frameheader.nuv -an