From patchwork Fri Aug 11 06:35:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Xiang, Haihao" X-Patchwork-Id: 43201 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:8b1b:b0:130:ccc6:6c4b with SMTP id l27csp1164736pzh; Thu, 10 Aug 2023 23:54:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE4mTnUHuoO2Ya1E2B5uCuV/pZjCnYTYOFyIzpkry2twE4WtXpkgqRzYBYDbVSR7uzs7KSk X-Received: by 2002:a17:907:2710:b0:98e:933:2909 with SMTP id w16-20020a170907271000b0098e09332909mr1030054ejk.22.1691736872954; Thu, 10 Aug 2023 23:54:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691736872; cv=none; d=google.com; s=arc-20160816; b=Hsn5p3Y9JkYvwyJPNLN4m6GaKcDWmKfM2v4cHplpsNg84HDJjUrx9GeSy0prPq9jgY XbArNnhipL63PChVVTXfxwxuba6yslI+/P1qVf95DXqnmJRqS7CACiIgUzJuOi1ZXzAm cgiK2CxOkLCiXayypbhnR2r7QhHHIwT9vnf19/hBp9cqomQS5DawBv3tS/bg1OaB/mmb FUDNm3RwD57Nkw+8/LUgx6bMJNDOIWNIE4m5bSuTxtOfW9syFDyAaPFtpVZpY/yyl/ml OzoJ93xjhG9fJYOOA3isRCkxiW5IbbpkZIH7feC1dV3h2N5Bgm5w20k1g1Oud6C6blXs wY7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=Qr06N8aNtOuv3T7+E7p+nxhlJj5/m1csNpYwkSP3gOU=; fh=Tt4aWcAPplwJLYowQh9cIyedJjsIqBA8GlwfHZgTuYo=; b=YUw46ZwlTdPOwdcReL+NWArk/Yl6sHVSHVClGEM4PNY26ujmQtO0ZWtfWh7/x+xaTM tAHKc9t4Rp64FvdAtfIit2Bjk8lkYuFdn4nKnVnhtWQXOK1nwiGKjvkj7Pm21dmHTI6l +d8CWIaXgRmmHlGcqZapcXWJczIaaLipxfTch0MiWVO4q2CtK/yTZacDRFDwZ3LkYwaZ 1p8C0l9S8Z4YEOXyfew/HIUR6LglOh4AMI6gtQV8I8Pp5ddfdbcALygjfr2+K5VQflza Z5cc4O4e5kuIBcuMAvW+nN1Hm7HmOxl9H3zy+iQV55vayEKtBpPKYVGx9b9Fh51h0Hhf B/zA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b="Xr/WNHkO"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id gh6-20020a170906e08600b009888e0923cfsi3017647ejb.712.2023.08.10.23.54.32; Thu, 10 Aug 2023 23:54:32 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b="Xr/WNHkO"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 66A6168C5A1; Fri, 11 Aug 2023 09:54:27 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F001568C230 for ; Fri, 11 Aug 2023 09:54:19 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691736865; x=1723272865; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=ppjc1BZoF+jT/Xbm+ZY8LWsihknICQ0SMVG5M8sRWRU=; b=Xr/WNHkOOtp5bSu8ISdy9wwx9daJTDET1MC+qRbmQtcKefWwSBxZF/64 GyOh6mYS6LqB9CMSQzS9kpzVvab8mDKeHjCd6Horw/4aVTq6/SFLlRntT Msy+MTfqy8JT9RW1ITmib9/O++157bN31ugSH/gEFHAp0QwbBFh9E8OKC LcAIXkNnFeCbY/B1W6TqI59kSHmZ7KjMGHPr2dA0CcdOyfqjXuvadB6Wk Xe+yxOeKXDb2ai0746a7TrEocjrtyDfO8bJHYpPuMOCDbqzVBmjyd9UbV QifdLUML/5p+jSzt1OLj1uG5O2KU9Tw/dqsQMePKwV5UZ43xr6XMLLrvJ g==; X-IronPort-AV: E=McAfee;i="6600,9927,10798"; a="374378091" X-IronPort-AV: E=Sophos;i="6.01,164,1684825200"; d="scan'208";a="374378091" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2023 23:36:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10798"; a="762089872" X-IronPort-AV: E=Sophos;i="6.01,164,1684825200"; d="scan'208";a="762089872" Received: from xhh-tgl64.sh.intel.com ([10.238.2.19]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2023 23:36:00 -0700 From: "Xiang, Haihao" To: ffmpeg-devel@ffmpeg.org Date: Fri, 11 Aug 2023 14:35:41 +0800 Message-Id: <20230811063541.536421-1-haihao.xiang@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] lavc/qsvenc_hevc: restore the default gop size X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Haihao Xiang Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: tK9ceaC8t140 From: Haihao Xiang commit a3c0a3e changed the default settings and expected the runtime can choose a best value. However the runtime doesn't set a valid gop size for hevc encoder, hence the output steam is non-seekable, which is inconvenient to user [1][2] [1] https://github.com/intel/media-driver/issues/1576 [2] https://ffmpeg.org/pipermail/ffmpeg-user/2023-August/056716.html Signed-off-by: Haihao Xiang --- libavcodec/qsvenc_hevc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/qsvenc_hevc.c b/libavcodec/qsvenc_hevc.c index 5e23ca9647..c5b7ac7cc4 100644 --- a/libavcodec/qsvenc_hevc.c +++ b/libavcodec/qsvenc_hevc.c @@ -376,7 +376,7 @@ static const AVClass class = { static const FFCodecDefault qsv_enc_defaults[] = { { "b", "1M" }, { "refs", "0" }, - { "g", "-1" }, + { "g", "248" }, { "bf", "-1" }, { "qmin", "-1" }, { "qmax", "-1" },