From patchwork Thu Aug 24 19:56:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 43298 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:24a6:b0:149:dfde:5c0a with SMTP id m38csp1552750pzd; Thu, 24 Aug 2023 12:56:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGYaTiRNbU/VpFDnphMnIQHmv19mjjRNmM7LGHNbaYuTlAkzRhh1tA8Oz4WwvoIigDX2PVD X-Received: by 2002:a17:907:763a:b0:9a1:b144:30f4 with SMTP id jy26-20020a170907763a00b009a1b14430f4mr10932373ejc.14.1692907003128; Thu, 24 Aug 2023 12:56:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692907003; cv=none; d=google.com; s=arc-20160816; b=WojpM924tsHI2ccL/eaBjcqWokcQgbUvn3iaWyULQAWLU/soVxv6CQHsvU1lT7y4Ve Se/CuIAJq9dOBdSiHH2SHc3FTAIYmX6ajmsj8QL4/Pk42Ix/gKLwZw80l/k3D30NiuRt 8lIaN2ki3cQ2uPnHy3l83VIeZLJVu+nMuOo1VgfJfjYnYEhOW4pJBQwmYb72ZNUP1322 gLGdP3vM3WRPnbWibSM4CECYdRHORQ8ei/KDE9BD52ZPiNlQBpIn0D7qAZTGuWk1udrp Zn3d0C9Cy+nRoRveYAS27ThxG2sV31YN8fJEa824KRHvkfuD76DRTVCzjycm1d27Dw/s 6LXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:delivered-to; bh=i87OZzjJTqcgrcbNVZ/qOWceOOkXI3AedG7UP8nL7Jw=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=aPyuMCoygAGYB7fZTaUcHYTo2Itz4CyoV0HdV7zhWIL1pRzCq3hKcoOwWVSXIbNkNO gMvPMewWHH9DFC1bhqNRWlkt0bQ7EemdudzbgadfJtIojSTc+wmhPfku+gDcFqVcH5W6 +13zljL/d3CZF5pBZ9Tz854wbNQjwkRBMpWVzq5VNOnoD3nJLuq70FeNzu2a1wqWGS2e vTAYZdaSuifSXd01YQVsBD/xTjC4MLPLmz4jr6LkyscT6y2RO7K4FK9lplQptm2CNGzf 4zSOPqiVkpeiiJfxBSkwwB1v/9dGVg5Rns95f9cZdJ+8m7lAJqpJm3DehAWNnoO51Oa0 NQ7w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id y11-20020a170906070b00b0099d804da2ebsi17409ejb.503.2023.08.24.12.56.42; Thu, 24 Aug 2023 12:56:43 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A660968C5A9; Thu, 24 Aug 2023 22:56:34 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BAEFF68C230 for ; Thu, 24 Aug 2023 22:56:25 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 0C098E0003 for ; Thu, 24 Aug 2023 19:56:24 +0000 (UTC) From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Thu, 24 Aug 2023 21:56:14 +0200 Message-Id: <20230824195615.19017-2-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230824195615.19017-1-michael@niedermayer.cc> References: <20230824195615.19017-1-michael@niedermayer.cc> X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 1/2] doc/developer: Reviews must be constructive X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: H8xuIGVunPHD Suggested text is from Anton Signed-off-by: Michael Niedermayer --- doc/developer.texi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/developer.texi b/doc/developer.texi index 0c2f2cd7d1..383120daaa 100644 --- a/doc/developer.texi +++ b/doc/developer.texi @@ -853,6 +853,9 @@ Everyone is welcome to review patches. Also if you are waiting for your patch to be reviewed, please consider helping to review other patches, that is a great way to get everyone's patches reviewed sooner. +Reviews must be constructive and when rejecting a patch the reviewer must explain +their reasons and ideally suggest an alternative approach. + @anchor{Regression tests} @chapter Regression tests