From patchwork Wed Sep 13 23:47:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 43726 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:4b2f:b0:149:dfde:5c0a with SMTP id fp47csp58341pzb; Wed, 13 Sep 2023 16:48:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHpc36RoQ3stx6hH/MkotIlfPEEn2a3ePcPDmEoXIH/CKxAzJNN8tICHEsupRGpMj/RkeEt X-Received: by 2002:a17:906:1d:b0:9a9:d5d1:35a4 with SMTP id 29-20020a170906001d00b009a9d5d135a4mr301490eja.7.1694648879784; Wed, 13 Sep 2023 16:47:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694648879; cv=none; d=google.com; s=arc-20160816; b=liojuv52DGAq8PugEJaiQXL6jvbSNS9fio/ZE6XDFSXs3yF7EfMih0SKTVDUul5f/c 5MOnp3z4rZNCyFhPFZn4xLUDY5ocOG8mM4FaVr+b840SICGXdFFOAj5L9Y7JJfWqJyyL tEIM1yZXl6jSQdVdPE6JYPz3faR1COSc3kGnB80JHll4vWwGyVq37Rccv0aNRZxyWo6h 2txvD3+Pr6LKZbrnmzOj/bbQAwiUBThlR/SYvn3GrxAAuN5s5upTW2yNmqGGGrmSL8kS yO/J1pTKtmwAmJ7apLNhg2eXj5f8W6G5CrlgqSenJ1ivRGGJ3F7ehsir8AN2hA5rtPvr Oa0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:delivered-to; bh=scHAQTzai/IYz3XN84SPbYzDLJI9ZU0R0VFI+Fq4bpM=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=NBgNamYpRVfn+WBsVuMk4mDxn0ATZYujyKcR+g5OLfJ7qitr4D5oEZ95qrZ4RecuAy BQAbUcBW/2LNJkr/Pyf1MAtdTxVTHFo6Ox8x4P12K6ngsL0RChId8xljEIRcbO3dAGWj INg3jBYP/xeqV8I8zPpwaOV1zxktZZd85hGpZwH+SgZQ6uQXOsnOTeOcvolQ8xEs1Dze nyucZC0TcZGQ47CMwAexprLrvvYH3nmjphwgjwx8oqVKx+n1CITWmmpZSfhUEd2r2LfW 5sZOp7rbi39fdvSaDO9/dvEQUDqMDrzY3oBVmz1Y7Vt4H4yU3eRhzRg+0zX6/TIox/NB n7Lg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id um10-20020a170906cf8a00b009a205e2e6e3si226515ejb.231.2023.09.13.16.47.59; Wed, 13 Sep 2023 16:47:59 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CD1AA68CA06; Thu, 14 Sep 2023 02:47:44 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B7AEA68C9AF for ; Thu, 14 Sep 2023 02:47:37 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id EEEA520002 for ; Wed, 13 Sep 2023 23:47:36 +0000 (UTC) From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Thu, 14 Sep 2023 01:47:33 +0200 Message-Id: <20230913234734.22402-2-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230913234734.22402-1-michael@niedermayer.cc> References: <20230913234734.22402-1-michael@niedermayer.cc> X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 2/3] avcodec/vlc: Attempt to free buf after use in ff_vlc_init_multi_from_lengths() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 2/3iRxiISELi Fixes: use after free Fixes: 62153/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MAGICYUV_fuzzer-4702814909366272 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/vlc.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavcodec/vlc.c b/libavcodec/vlc.c index b353d2e86c2..f4bab0ae529 100644 --- a/libavcodec/vlc.c +++ b/libavcodec/vlc.c @@ -471,10 +471,13 @@ int ff_vlc_init_multi_from_lengths(VLC *vlc, VLC_MULTI *multi, int nb_bits, int goto fail; } } - ret = vlc_common_end(vlc, nb_bits, j, buf, flags, localbuf); + ret = vlc_common_end(vlc, nb_bits, j, buf, flags, buf); if (ret < 0) goto fail; - return vlc_multi_gen(multi->table, vlc, nb_elems, j, nb_bits, buf, logctx); + ret = vlc_multi_gen(multi->table, vlc, nb_elems, j, nb_bits, buf, logctx); + if (buf != localbuf) + av_free(buf); + return ret; fail: if (buf != localbuf) av_free(buf);