From patchwork Wed Sep 20 12:18:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: mezhuevtp@ispras.ru X-Patchwork-Id: 43855 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:a886:b0:149:dfde:5c0a with SMTP id ca6csp606128pzb; Wed, 20 Sep 2023 05:18:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHUp8Qi3Ef3XLmgKS2FP6zQvt20Sx1D84Ed0gEWU7W4dwlqHOxd55VP4xlMFvhGZOGhbIFS X-Received: by 2002:a17:906:20ce:b0:9ae:505d:310b with SMTP id c14-20020a17090620ce00b009ae505d310bmr1066774ejc.39.1695212310886; Wed, 20 Sep 2023 05:18:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695212310; cv=none; d=google.com; s=arc-20160816; b=XDk84BD7oUrQcQQmLO5WoZboAucLnM4mkk+z9Hp7au/CBGClY6qpRNfYX5TcgIkz5l yEGoaN+LS81XyZRQz/5NH/80PYW7Tx+VgQW0sWVpwarcalUc6rZbZaIQz/VOnsA4w1YU 7YIi5D13p38Nlp3zb4dqC1Ikl9dYWAOVPd1lOLD4JKFolT8RaNI9YfaekQfZGSJiPjH2 RGjG0KLnjIJRj7eRZYNzlpRZaQctIqAgZtbPI6FV+041fGIHkq3VO+85w3NiFAbTD5mQ 42FgBjQj2XBKg/bIvHNAQZLLOi0ri7f1c9Gub7kzDr6Lgg6YlEXijU6rTfL8V5i8HNYL 6LPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :dkim-signature:dkim-filter:delivered-to; bh=0dMnOf2ybKrOzmcTvScm/nWJ8a45wbcpTFVJVYynu+M=; fh=N5ZEAcbS/qNmXhnh007L0O2hfBv3whDN0oICTLe1blQ=; b=ycLlWU3n4ZuiIj7l+pA14lPJHoqg9COq+C/a/7VnVvM7MYMsz/tOj4Bi/zMv0n37RL w2jHkTsmg7dUzvhG0yt5RApJYxLKega9pFMr/URPyRYciT6Dp3ChhH5YSUFwFXEBlHle lQBD5DII5QogHCp5B+K4kCRbYfwwQmHJwtmMkwoC3FpyxbBpASfxpQ2ksInKzYLOzWj8 sc/tVz5wfLQc24R3j+ZdEVzUzHP0Q5RVFUgGPWy/ljXoOg2O9LcY/dx/VgQuljNZSBPE aRE3absj9OtlI20UwXETCwWC8C0SnSAWY+2VdneNKa9uejRWFlKx2QjC7J7pLDPQQVsg GY9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@ispras.ru header.s=default header.b=aQ+gV7JM; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id gr3-20020a170906e2c300b009a63cbd4b0asi11386465ejb.938.2023.09.20.05.18.29; Wed, 20 Sep 2023 05:18:30 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@ispras.ru header.s=default header.b=aQ+gV7JM; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 45FA568C809; Wed, 20 Sep 2023 15:18:26 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 73E0E68C809 for ; Wed, 20 Sep 2023 15:18:19 +0300 (EEST) Received: from nick.intra.ispras.ru (unknown [10.10.34.56]) by mail.ispras.ru (Postfix) with ESMTPSA id AFC61407673D; Wed, 20 Sep 2023 12:18:18 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru AFC61407673D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1695212298; bh=MnWCrdt9CNmYttwAK1obiqm0PnDPkEA/F8R7vj9vWVY=; h=From:To:Cc:Subject:Date:From; b=aQ+gV7JMZpqFYexM7KxnUYE8J5TMpP/4cxl4ZjQzk1z0AtA7xoA+44NmRyp+eCytr K8OMP9S5ZKjQaKlAFr4uQidhKZTXCCZYV1tmP8mrz0OcGZNeb+YrLJssjnzIB3iZzN BqH7Fu+khk3eqsdh3OUy7k87/RFd8JDI9MXvTsBg= From: mezhuevtp@ispras.ru To: ffmpeg-devel@ffmpeg.org Date: Wed, 20 Sep 2023 15:18:03 +0300 Message-Id: <20230920121803.3456113-1-mezhuevtp@ispras.ru> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] Hi! We've been fuzzing `ffmpeg` with [sydr-fuzz](https://github.com/ispras/oss-sydr-fuzz) security predicates and we found numeric truncation error in `svs.c:57`. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: mezhuevtp@ispras.ru, headshog Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: rng6E4d9jCBL From: headshog In function `svs_read_header` on line 57 field `st->codecpar->sample_rate` has type `int`, the type of return value in `av_rescale_rnd` function is `uint64_t`, so the numeric truncation may occur here. Then value of `st->codecpar->sample_rate` is passed to `avpriv_set_pts_info` function parameter `unsgined int pts_den`. In this function `pts_den` is used only in passing its value to parameter `int64_t den` in function `av_reduce`. So we suggest to change the type of field `sample_rate` to `int64_t` and to change the type of `pts_den` to `uint64_t` in `avpriv_set_pts_info` function. The other way to solve this is to add a checker for `sample_rate` valid value. - OS: ubuntu 20.04 - commit: f225f8d7464569c7b917015c26ad30a37a5fbbe2 ``` libavformat/svs.c:57:36: runtime error: implicit conversion from type 'int64_t' (aka 'long') of value 6321554672 (64-bit, signed) to type 'int' changed the value to 2026587376 (32-bit, signed) SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior libavformat/svs.c:57:36 ``` --- libavcodec/codec_par.h | 2 +- libavformat/internal.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/codec_par.h b/libavcodec/codec_par.h index add90fdb1e..2bbb7ba4e7 100644 --- a/libavcodec/codec_par.h +++ b/libavcodec/codec_par.h @@ -175,7 +175,7 @@ typedef struct AVCodecParameters { /** * Audio only. The number of audio samples per second. */ - int sample_rate; + int64_t sample_rate; /** * Audio only. The number of bytes per coded audio frame, required by some * formats. diff --git a/libavformat/internal.h b/libavformat/internal.h index 901a8b51c6..6e1fce41aa 100644 --- a/libavformat/internal.h +++ b/libavformat/internal.h @@ -584,7 +584,7 @@ const struct AVCodec *ff_find_decoder(AVFormatContext *s, const AVStream *st, * @param pts_den time base denominator */ void avpriv_set_pts_info(AVStream *st, int pts_wrap_bits, - unsigned int pts_num, unsigned int pts_den); + unsigned int pts_num, uint64_t pts_den); /** * Set the timebase for each stream from the corresponding codec timebase and