From patchwork Wed Sep 20 18:40:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abhishek Ojha X-Patchwork-Id: 43856 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:1e62:b0:149:dfde:5c0a with SMTP id cy34csp138323pzb; Wed, 20 Sep 2023 11:41:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFsYl5Cc3afNPd1YgZ/zlPItMOVcYWOpyWpeVyOHyhEUob9sTVJpqfc0hXWsaKdpbcAHhP7 X-Received: by 2002:a2e:b018:0:b0:2c0:2b44:6ebe with SMTP id y24-20020a2eb018000000b002c02b446ebemr2777986ljk.13.1695235275413; Wed, 20 Sep 2023 11:41:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695235275; cv=none; d=google.com; s=arc-20160816; b=GhvFjuYmg83jIfW3WzAgs7pQqUWmm/gQ2VemuuyuvrckJuA4VXiUM+r3qxRPA+wwAI lZCoby1MCk3WHvGLGSgf3MWn8+Qo571dwFpuiCiIbOo5CLZipq/RYK5L0BTfgDO/D151 w9ii6bH9gBOeRgtZ65LUzsqjbtdRcxfvGdHfJj4sTed3OCC0Nmmz3i8FsDJPgM2xd2PQ p7xi3KJOJsZxI0Obiq7eOXUn1iF5+skWolS5SZR+TM2Hf8OfhUXcQL2BznzI/dGSlDH2 K5Jui63zidKcjO/pcj+HRFiXRu9xluyGr5wvSHnAPY6xcktNgQNqqyUtKEXneSiPpHQC IoXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:dkim-filter:delivered-to; bh=lxsAQzC5wwpyFLu2AVARDKeI/+xAbNvKG0lFgbTdsSU=; fh=EoDQIxrGX5YoxE06pcRJp2YbYXp56qGDzCRNcLmuGVo=; b=r4pN47wR1lobhKU9KnFGgHXU7EJLKJlAYGUiDEevnqDMQ+gSTRDJR9dGBExV/yltFA KA9KDaQCovsypv1RdwgfVufEYOJH55WwmI2cFYA8SFwAQy2KYgC4ht1wdR7/Zo8KoHZZ PvRpsyIy+LiIzJy8dlgQ4XIm3PAbOEj4m6wpMxausfqHghOqFqaO69d8BAWlpUkgEvGs RnKDKv9l0a5qWxnjuglHb6dhIfDqVwAzY9hj4oDfNXjlaxebsDXTCtrHdGOhROjCsdyU +xE15kvN7gD8lMPPajc1QhoaOKC1jxvclA84hJ2KewKVz6Kib5L0MtpPoLvp8Qxn3D89 542g== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@savoirfairelinux.com header.s=DFC430D2-D198-11EC-948E-34200CB392D2 header.b=ujdsFWHd; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id f15-20020a170906560f00b009a5830bb1fdsi13217577ejq.1054.2023.09.20.11.41.14; Wed, 20 Sep 2023 11:41:15 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@savoirfairelinux.com header.s=DFC430D2-D198-11EC-948E-34200CB392D2 header.b=ujdsFWHd; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D5E0768C7E9; Wed, 20 Sep 2023 21:41:10 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail.savoirfairelinux.com (mail.savoirfairelinux.com [208.88.110.44]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 11CA868C876 for ; Wed, 20 Sep 2023 21:41:03 +0300 (EEST) Received: from localhost (localhost [127.0.0.1]) by mail.savoirfairelinux.com (Postfix) with ESMTP id 328D49C0E4C for ; Wed, 20 Sep 2023 14:41:00 -0400 (EDT) Received: from mail.savoirfairelinux.com ([127.0.0.1]) by localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavis, port 10032) with ESMTP id p5AitRxE8loX; Wed, 20 Sep 2023 14:40:59 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.savoirfairelinux.com (Postfix) with ESMTP id BBEDE9C2AE5; Wed, 20 Sep 2023 14:40:59 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.savoirfairelinux.com BBEDE9C2AE5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=savoirfairelinux.com; s=DFC430D2-D198-11EC-948E-34200CB392D2; t=1695235259; bh=JO50s552rwPhdoh4IDmYKzNtNVEDDlaR+fMXqKSJur0=; h=From:To:Date:Message-Id:MIME-Version; b=ujdsFWHdYMGp6VFwfXnzho5ZZN5cEMd2ktwbO14083FbFQUhmtn6LcBqPJ4UVoyMf 9YhKFDQ/yZ58y0tVPZZptrNIc/GVsNzyZB/RNNTXSGXDijcKmbV9UmSbHT8yvnVODl NBdKlWu5GmF9gQ6UQHv7WSIDej2IC9xD9SCdp0pRKmcNNR0VxmR+zrXrsBsEJ/GlgX 6wbgqgYFEzxF/4LWULEQZrmgIH5Z8bf5aZAJyHFelJQYvwqvqVXCBGu56b9zDmecAB xF42WwbAlgzxRvPRQfDVUeShM+R5vMgIkPwMiWztKrPh7NVFVc5ZRe+B7mYe9k6eE2 ywKNhIHhUUq8w== X-Virus-Scanned: amavis at mail.savoirfairelinux.com Received: from mail.savoirfairelinux.com ([127.0.0.1]) by localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavis, port 10026) with ESMTP id ciwQEVTzsdgM; Wed, 20 Sep 2023 14:40:59 -0400 (EDT) Received: from asuspc2.taile0726.ts.net (unknown [192.168.51.254]) by mail.savoirfairelinux.com (Postfix) with ESMTP id A3AC69C0E4C; Wed, 20 Sep 2023 14:40:59 -0400 (EDT) From: Abhishek Ojha To: ffmpeg-devel@ffmpeg.org Date: Wed, 20 Sep 2023 14:40:58 -0400 Message-Id: <20230920184058.1263793-2-abhishek.ojha@savoirfairelinux.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230920184058.1263793-1-abhishek.ojha@savoirfairelinux.com> References: <20230920184058.1263793-1-abhishek.ojha@savoirfairelinux.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [RFC PATCH 2/2] configure: disable locale use in spa plugin X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Abhishek Ojha Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: yvzeDkVYJc6+ This commit requires to resolve the compilation error of pipewiregrab because Pipewire's spa plugin is requesting locale_t extension to compile. Which was added in POSIX 2008 but ffmpeg is using POSIX 2001 due to which spa plugin complains. __LOCALE_C_ONLY flag is set to disable the locale usage in spa plugin. Adding it in configure file fix both the library test and source compilation issue. Not sure if this is the right approach to fix the issue. Feedback/Suggestions will be highly appreciated. Signed-off-by: Abhishek Ojha --- configure | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure b/configure index 325b10484f..e14a8e5bcb 100755 --- a/configure +++ b/configure @@ -7045,6 +7045,8 @@ if enabled libxcb; then enabled libxcb_xfixes && check_pkg_config libxcb_xfixes xcb-xfixes xcb/xfixes.h xcb_xfixes_get_cursor_image fi +# _POSIX_C_SOURCE=200112 doesn't support locale +add_cppflags -D__LOCALE_C_ONLY enabled libpipewire && check_pkg_config libpipewire "libpipewire-0.3 >= 0.3.40" pipewire/pipewire.h pw_init if enabled libpipewire; then enabled libgio_unix && check_pkg_config libgio_unix gio-unix-2.0 gio/gio.h g_main_loop_new