From patchwork Tue Oct 31 18:57:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Evgeny Pavlov X-Patchwork-Id: 44456 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:6da5:b0:15d:8365:d4b8 with SMTP id gl37csp511741pzb; Tue, 31 Oct 2023 11:14:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF5YgNUDZA7XbDtcOreFnlelSPdtxtKnQaiVKKNwa6wSGPfZ++iGCUAcm6GCBc3b26IqX5P X-Received: by 2002:a50:a692:0:b0:542:f9b3:fb0 with SMTP id e18-20020a50a692000000b00542f9b30fb0mr6671144edc.34.1698776068614; Tue, 31 Oct 2023 11:14:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698776068; cv=none; d=google.com; s=arc-20160816; b=e+iLXhPrW7wcNE19yBAM240nAzzCY37cQaorXzdxsWgnYtLRHTAY0mV6GmOwksvbYC USysnuR4gIf8k6pCdIXW1cYYe1DFDA1ocq2jC0FEuwV9XiuQ6A+KTod4uXb8+jE1foUs 5+tnvc+Jo2lBARBbszr1r1x7eRZZTtgRJJK8PtiT6lYXRQn8/0LdShysu5iO7mcsKODb /Wx6RsS7PKAwS1/n5jSF16QwPP52I7S1zfaD8pnp64JIAF4NoPWAdUFEXaOUNLUF41pW ceYPzsuglZ6WQaqpLeNjfD4vPFd9p7ToRb3dILnyeXi0Pkw8qyf/APa2xQ9rSMFyDEv1 fBXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:delivered-to; bh=nQXLYHTU+pzuXnAClmiMA38bfEI/TvjQj+sU31BLIk4=; fh=s4NEqlgyeQvuJ9M2FER/qIrd96lZ1v/frktaqQpFGmg=; b=YGwSuxjNap18YVWdppqmsgzf7eHTKIqyPXNaCl+cs8kGQmR6CKraZpcS3Nnl9xB1Z/ Goi58kiveB+hUiExKnC+sQsf61UPddvH/iIOuS4ipRzhIOCiGidluSs7Z357Gb2mJvY5 8Wv7ckAzcyKmtQQ/ZR7hzNwlHBKn1Eqmdpy+TBssXs5/PfXJq9vjLwXkrhCXlRMiuT00 1A1BYcp3BcJ5iqVMiaY7TzuxtXE6sQMJ97BtLYG/yehJSaSlAH6phKuy9n5uhzjl1pWI peqfURrI8w9fsA5GiBcOq/EyvHbpPCwIod0Wdtf5YY+r0TC9r3i4vkTjQFILhHzLSaHF 0YJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=D5up6MyY; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id y37-20020a50bb28000000b005436e0c57bcsi774446ede.415.2023.10.31.11.14.28; Tue, 31 Oct 2023 11:14:28 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=D5up6MyY; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DC9C668CD87; Tue, 31 Oct 2023 20:14:25 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C6D2668CD6F for ; Tue, 31 Oct 2023 20:14:18 +0200 (EET) Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-507c5249d55so8619026e87.3 for ; Tue, 31 Oct 2023 11:14:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698776057; x=1699380857; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JX4G0I9AfulDVPsYmdrP3bDhk9RapAH7Dgp5Ckjk1xY=; b=D5up6MyYhIvmavFmvKKnRwtXnLu7bRsQzoKdJhQrkaD2tctFi6c9uVrlxY1Lv3GHuu JFGoGO64Z+TaA5AydD5yJJXy9Iru2euVTlr3WAZamKEqHMdaQT/A/iIFZ+xuNp4znpuI jJHCD8tNbFxJcSORj5RJvoIck6p/+FcZmoPVcQRrh26Xml5bUHKJ3UexbeV/m+IdFq/y hBH0dW8fch+dc4QfeRCmyj6PabtfsT+SWyW/kQh86vfGKvAaLR1XZkyA602xeUsds2wa w050rbA806gak8XBzBrcau/gpYZJ4qG18XtBqGW/VvOXEn3q3j6+8+sqdH9CqgK0vvTy Bo8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698776057; x=1699380857; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JX4G0I9AfulDVPsYmdrP3bDhk9RapAH7Dgp5Ckjk1xY=; b=II/QqHKXfKN/LIliBTFLrI3fcUVMItpxOF22i9sB26IgoRKq+qIq3ooUuZv0IlPYSj YZcYy+qGvDnzovsy4h01DN7gh6fo0L/CCGj/7PJdkxX+agCGJsox1FqvXs0+P8pn1GAZ NRyC8grxBfFn3Ublp1gaCS+qAeZUgZtFdG7MCYivm3ocIUKTYSGcPO6I6MuV7ie4v7pw ucyah4U5JyR+Hl5jCH4v/CjnMhrRi2X4Wp/OZc57MCwUMMNpefwQ7DeZxhb8G4n+Zn6g /6tdCy81WVCuzDS8aeLiM/ohkyphtS/YOTArQ+sMHCguXqWak9FAPkiJwHVkl0wPu9dK b61g== X-Gm-Message-State: AOJu0Yyme7kmXp7R56hPPviN3cepiWaOQCxAUL0WObmHnkB6eVAbIf8K U4K7rLbks0/EUpA+WPbL4vZTweDnCvbdcs1B X-Received: by 2002:a19:c510:0:b0:503:34b8:20b with SMTP id w16-20020a19c510000000b0050334b8020bmr9664544lfe.65.1698776057339; Tue, 31 Oct 2023 11:14:17 -0700 (PDT) Received: from MSDN-EVPAVLOV.amd.com (178-223-50-56.dynamic.isp.telekom.rs. [178.223.50.56]) by smtp.gmail.com with ESMTPSA id z18-20020a05600c079200b0040772934b12sm2364192wmo.7.2023.10.31.11.14.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Oct 2023 11:14:17 -0700 (PDT) From: Evgeny Pavlov To: ffmpeg-devel@ffmpeg.org Date: Tue, 31 Oct 2023 19:57:47 +0100 Message-ID: <20231031185817.6779-4-lucenticus@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231031185817.6779-2-lucenticus@gmail.com> References: <20231031185817.6779-2-lucenticus@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 10 bit support v5 2/3] avcodec/amfenc: HDR metadata. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: nyanmisaka Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: LfUMkBr2RkqV From: nyanmisaka v2: fixes for indentation --- libavcodec/amfenc.c | 83 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 83 insertions(+) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index 0bd15dd812..068bb53002 100644 --- a/libavcodec/amfenc.c +++ b/libavcodec/amfenc.c @@ -36,6 +36,57 @@ #include "amfenc.h" #include "encode.h" #include "internal.h" +#include "libavutil/mastering_display_metadata.h" + +static int amf_save_hdr_metadata(AVCodecContext *avctx, const AVFrame *frame, AMFHDRMetadata *hdrmeta) +{ + AVFrameSideData *sd_display; + AVFrameSideData *sd_light; + AVMasteringDisplayMetadata *display_meta; + AVContentLightMetadata *light_meta; + + sd_display = av_frame_get_side_data(frame, AV_FRAME_DATA_MASTERING_DISPLAY_METADATA); + if (sd_display) { + display_meta = (AVMasteringDisplayMetadata *)sd_display->data; + if (display_meta->has_luminance) { + const unsigned int luma_den = 10000; + hdrmeta->maxMasteringLuminance = + (amf_uint32)(luma_den * av_q2d(display_meta->max_luminance)); + hdrmeta->minMasteringLuminance = + FFMIN((amf_uint32)(luma_den * av_q2d(display_meta->min_luminance)), hdrmeta->maxMasteringLuminance); + } + if (display_meta->has_primaries) { + const unsigned int chroma_den = 50000; + hdrmeta->redPrimary[0] = + FFMIN((amf_uint16)(chroma_den * av_q2d(display_meta->display_primaries[0][0])), chroma_den); + hdrmeta->redPrimary[1] = + FFMIN((amf_uint16)(chroma_den * av_q2d(display_meta->display_primaries[0][1])), chroma_den); + hdrmeta->greenPrimary[0] = + FFMIN((amf_uint16)(chroma_den * av_q2d(display_meta->display_primaries[1][0])), chroma_den); + hdrmeta->greenPrimary[1] = + FFMIN((amf_uint16)(chroma_den * av_q2d(display_meta->display_primaries[1][1])), chroma_den); + hdrmeta->bluePrimary[0] = + FFMIN((amf_uint16)(chroma_den * av_q2d(display_meta->display_primaries[2][0])), chroma_den); + hdrmeta->bluePrimary[1] = + FFMIN((amf_uint16)(chroma_den * av_q2d(display_meta->display_primaries[2][1])), chroma_den); + hdrmeta->whitePoint[0] = + FFMIN((amf_uint16)(chroma_den * av_q2d(display_meta->white_point[0])), chroma_den); + hdrmeta->whitePoint[1] = + FFMIN((amf_uint16)(chroma_den * av_q2d(display_meta->white_point[1])), chroma_den); + } + + sd_light = av_frame_get_side_data(frame, AV_FRAME_DATA_CONTENT_LIGHT_LEVEL); + if (sd_light) { + light_meta = (AVContentLightMetadata *)sd_light->data; + if (light_meta) { + hdrmeta->maxContentLightLevel = (amf_uint16)light_meta->MaxCLL; + hdrmeta->maxFrameAverageLightLevel = (amf_uint16)light_meta->MaxFALL; + } + } + return 0; + } + return 1; +} #if CONFIG_D3D11VA #include @@ -683,6 +734,26 @@ int ff_amf_receive_packet(AVCodecContext *avctx, AVPacket *avpkt) frame_ref_storage_buffer->pVtbl->Release(frame_ref_storage_buffer); } + // HDR10 metadata + if (frame->color_trc == AVCOL_TRC_SMPTE2084) { + AMFBuffer * hdrmeta_buffer = NULL; + res = ctx->context->pVtbl->AllocBuffer(ctx->context, AMF_MEMORY_HOST, sizeof(AMFHDRMetadata), &hdrmeta_buffer); + if (res == AMF_OK) { + AMFHDRMetadata * hdrmeta = (AMFHDRMetadata*)hdrmeta_buffer->pVtbl->GetNative(hdrmeta_buffer); + if (amf_save_hdr_metadata(avctx, frame, hdrmeta) == 0) { + switch (avctx->codec->id) { + case AV_CODEC_ID_H264: + AMF_ASSIGN_PROPERTY_INTERFACE(res, ctx->encoder, AMF_VIDEO_ENCODER_INPUT_HDR_METADATA, hdrmeta_buffer); break; + case AV_CODEC_ID_HEVC: + AMF_ASSIGN_PROPERTY_INTERFACE(res, ctx->encoder, AMF_VIDEO_ENCODER_HEVC_INPUT_HDR_METADATA, hdrmeta_buffer); break; + } + res = amf_set_property_buffer(surface, L"av_frame_hdrmeta", hdrmeta_buffer); + AMF_RETURN_IF_FALSE(avctx, res == AMF_OK, AVERROR_UNKNOWN, "SetProperty failed for \"av_frame_hdrmeta\" with error %d\n", res); + } + hdrmeta_buffer->pVtbl->Release(hdrmeta_buffer); + } + } + surface->pVtbl->SetPts(surface, frame->pts); AMF_ASSIGN_PROPERTY_INT64(res, surface, PTS_PROP, frame->pts); @@ -746,6 +817,18 @@ int ff_amf_receive_packet(AVCodecContext *avctx, AVPacket *avpkt) } res_resubmit = AMF_OK; if (ctx->delayed_surface != NULL) { // try to resubmit frame + if (ctx->delayed_surface->pVtbl->HasProperty(ctx->delayed_surface, L"av_frame_hdrmeta")) { + AMFBuffer * hdrmeta_buffer = NULL; + res = amf_get_property_buffer((AMFData *)ctx->delayed_surface, L"av_frame_hdrmeta", &hdrmeta_buffer); + AMF_RETURN_IF_FALSE(avctx, res == AMF_OK, AVERROR_UNKNOWN, "GetProperty failed for \"av_frame_hdrmeta\" with error %d\n", res); + switch (avctx->codec->id) { + case AV_CODEC_ID_H264: + AMF_ASSIGN_PROPERTY_INTERFACE(res, ctx->encoder, AMF_VIDEO_ENCODER_INPUT_HDR_METADATA, hdrmeta_buffer); break; + case AV_CODEC_ID_HEVC: + AMF_ASSIGN_PROPERTY_INTERFACE(res, ctx->encoder, AMF_VIDEO_ENCODER_HEVC_INPUT_HDR_METADATA, hdrmeta_buffer); break; + } + hdrmeta_buffer->pVtbl->Release(hdrmeta_buffer); + } res_resubmit = ctx->encoder->pVtbl->SubmitInput(ctx->encoder, (AMFData*)ctx->delayed_surface); if (res_resubmit != AMF_INPUT_FULL) { int64_t pts = ctx->delayed_surface->pVtbl->GetPts(ctx->delayed_surface);