From patchwork Thu Nov 9 12:19:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Niklas Haas X-Patchwork-Id: 44587 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:4fa4:b0:181:818d:5e7f with SMTP id gh36csp444185pzb; Thu, 9 Nov 2023 04:26:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IHAEy6wMOZyssn/fZqrR595CcoU3z6icyrrhrRovIUW10LCxPM/tgZQcxfsgdVSCTxXfYEr X-Received: by 2002:a50:cd49:0:b0:53e:bb41:7506 with SMTP id d9-20020a50cd49000000b0053ebb417506mr4042890edj.33.1699532787941; Thu, 09 Nov 2023 04:26:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699532787; cv=none; d=google.com; s=arc-20160816; b=bAU88+954TUfrume0dz7QgYWZQQYXiZ/hYrDtVj4hzA/f41IzFDXnUcv25/ZN73AoQ ivIfiphgONerfEJZp8kZPwTpDRZh5weI94VhdcMGjPWMjN6LqObJin48k/u89Ebrm6Dz ejjRxk48h6Bfk8bUYnUEoZ97gfC4cL/0ionx+dqIXJyb8C9G+c6wdG7wHaUVcq7n/iro ohlztbnJ/KgKYIdoYp2nAy9hWbQlzMfXk6Nw4GjO6QjVCw4hPl+y33sUj5Jgu4vfnbfF ekia7DNDfFQ6z40x46IeJYmhI71sNMHecj9aXYf+B+uwE9A7Jxgp9I0n4oAPu0YMmfbi z16w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:delivered-to; bh=wqNHfi578BpS260RIplma3n+zy138Vrk/JrOy8mHrpU=; fh=xmAeKtysnShNOmkhiJmYkS30uw4Fu2hvBJ7qlIwukxQ=; b=FtdibNhFo5eoSCfW5oGoFM+NyXqIKfKkejdtGuq1iSV6DS0Xcf5y3yLgr+ThACkxYy 7jIhgj/T8tYJ6bLPHq1COCtpHfKkyxx9OaE6yT6Qg3WzZNv74TKdIphabCP1w9TCKefV s+DrFB7LfhfTSOpFJCzEcw/P2eAfCAGMe7bFLQspvjvGSZVzFNx2JDWyjLWNmah5nT/V vamOaU06rvRGZwPVMNQlc3/ZEwFEmgML82C/UfLiz2PkHvdvqQGMJ+ag3VXqxLnz0pXx UjhJwL0/1gNwxZVX1bl7Vxfgr1nAqgVajB1x7OiTXtPAkYwXx24/BEr8aZ/fPSK9VFtM IrnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@haasn.xyz header.s=mail header.b=tcb1FrGj; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id o20-20020aa7d3d4000000b0053e31324eafsi7257634edr.504.2023.11.09.04.26.27; Thu, 09 Nov 2023 04:26:27 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@haasn.xyz header.s=mail header.b=tcb1FrGj; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 11C6268CC54; Thu, 9 Nov 2023 14:25:48 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from haasn.dev (haasn.dev [78.46.187.166]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EFA9968CBDC for ; Thu, 9 Nov 2023 14:25:36 +0200 (EET) Received: from haasn.dev (unknown [10.30.0.2]) by haasn.dev (Postfix) with ESMTP id B007A4BB22; Thu, 9 Nov 2023 13:25:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=haasn.xyz; s=mail; t=1699532736; bh=Lt2U3qANIACK/9ke9adoboGOHB7sOeWQnsnAsX9IZKw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tcb1FrGjlMr7wS01VvQsXSSUIvnvyBVNXaE+8sCydTTLv5xRtgx6a+li41p6mNwpU Ut89LcKqY5lYoXjlNhR5epvMydOev37HhpV6ogfD9KzBdv1786vyWQl0GAzWUzvMOX BP4IBrfHQDi/jfr4BygyfiqjxbIhtGkdM8IOrm+M= From: Niklas Haas To: ffmpeg-devel@ffmpeg.org Date: Thu, 9 Nov 2023 13:19:36 +0100 Message-ID: <20231109122534.124157-5-ffmpeg@haasn.xyz> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231109122534.124157-1-ffmpeg@haasn.xyz> References: <20231109122534.124157-1-ffmpeg@haasn.xyz> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 04/25] fftools/ffmpeg_filter: don't clear buffersrc params X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Niklas Haas Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: gzZz4RIVAjwW From: Niklas Haas This memset is bogus, it accomplishes nothing in the best case and regresses future additions to AVBufferSrcParameters in the worst case. --- fftools/ffmpeg_filter.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index b7da105141..e699798897 100644 --- a/fftools/ffmpeg_filter.c +++ b/fftools/ffmpeg_filter.c @@ -1400,11 +1400,8 @@ static int configure_input_video_filter(FilterGraph *fg, InputFilter *ifilter, int ret, pad_idx = 0; int64_t tsoffset = 0; AVBufferSrcParameters *par = av_buffersrc_parameters_alloc(); - if (!par) return AVERROR(ENOMEM); - memset(par, 0, sizeof(*par)); - par->format = AV_PIX_FMT_NONE; if (ist->dec_ctx->codec_type == AVMEDIA_TYPE_AUDIO) { av_log(fg, AV_LOG_ERROR, "Cannot connect video filter to audio input\n");