From patchwork Mon Dec 11 19:06:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?Q2zDqW1lbnQgQsWTc2No?= X-Patchwork-Id: 45075 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:1225:b0:181:818d:5e7f with SMTP id v37csp3137384pzf; Mon, 11 Dec 2023 11:10:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IHLd8g0pK6vhXv81LJTpl0yzCm00wfkxS3T99se1b2uN/qL+VJeCcxwBpul++cLzsswLAQ8 X-Received: by 2002:a17:906:5a49:b0:9e0:4910:166a with SMTP id my9-20020a1709065a4900b009e04910166amr2803093ejc.32.1702321808072; Mon, 11 Dec 2023 11:10:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702321808; cv=none; d=google.com; s=arc-20160816; b=YfyQGszduqrPIsyPT17dkbTcCgg2V88oBAbzLHU1HIMUa1AiOUlaMEhrJrb03V60KW eL4061SwpgCKbBeTNx9GmUy/dKgKMV617P14pA0IAXvT1G0fu2juisq7OXU4FGUSnT1O BJZ94nJCK8O9hlSVUhgbffC9BtuoChKi0w67V7mhTrgJXdh2/5KfUF+tqOsqWWFDFi/x yzkkbYbg5UBACbTazVenHMRKaDJwRALOgB9uOh2Ru88SnOR9642FxUhfaqp7xKjtWdFl ndB6UPDBsEUs1j2/nmgnXpJECUCH3jkm6qHvsmrPmdejhlHweAcSbOKpYqRreP3BPP02 /q6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:delivered-to; bh=8WU9ujyCR0tDNoNf6F4HyKG7HN2RDqh+csxp5pCF4x0=; fh=Jgo3TCyoG8OdFLqA8BuM7Wbf1w27210JU6p+E8x39/M=; b=g3f70Oa9BZbQh8p9TVxkj9WsdDWUdM1UAVRCpWvZ43X6oJAN8jfXy2JWY5Vd7ApmXG czDM2O1+lTInyoafAwV/yHxYI19ybLxUDZc9ra26f7pAg0/yRbOXHyjfQwU+2CQ0M6Im zLkJ2LVEkOd6jBeJvS3IFVVg0CyLyfmPTcVbKk5qAffvcA0UlHhzA9W+/RIjxHFqWblG BX8MrIb8tXq4IZsEX+iYlUgtN1yZY4saSnGlPSxTRZn8oD03bLX+2iXnBwLwf4fp+Urj 9jvJdgwS6tya4nD/o3TAp1/UtuW406uuNYG5FBfgvgN5148E2Al0Hirq89Mmn8z7TAr6 4mUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@pkh.me header.s=selector1 header.b=cKURna6k; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=pkh.me Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id ha13-20020a170906a88d00b00a1d5063b018si3866873ejb.718.2023.12.11.11.10.07; Mon, 11 Dec 2023 11:10:08 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@pkh.me header.s=selector1 header.b=cKURna6k; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=pkh.me Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4582E68D204; Mon, 11 Dec 2023 21:09:31 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from ssq0.pkh.me (laubervilliers-656-1-228-164.w92-154.abo.wanadoo.fr [92.154.28.164]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A707068D1E9 for ; Mon, 11 Dec 2023 21:09:23 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pkh.me; s=selector1; t=1702321752; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fvyHtgc2OiK+Wu3MwP+ZEA21yvYp0n5pSj0e0J6NVrg=; b=cKURna6k5C3OTKyYJwSV9n0peMi+PlloHFIaibntG2QGzxzOLlLaQ4dVPT8GY2QaHYTEn7 xhiSrztkIkpPfgrWnlcZfiSNIeWK+PcoZiqTiqscUb/gfnGUqeNRW6qgpixmsH5jpTrU1B 5ghNNOHVOKBAHdr84DHnpbyHYA6w2Hs= Received: from localhost (ssq0.pkh.me [local]) by ssq0.pkh.me (OpenSMTPD) with ESMTPA id c3e39c6e; Mon, 11 Dec 2023 19:09:12 +0000 (UTC) From: =?utf-8?b?Q2zDqW1lbnQgQsWTc2No?= To: ffmpeg-devel@ffmpeg.org Date: Mon, 11 Dec 2023 20:06:55 +0100 Message-ID: <20231211190908.1882569-6-u@pkh.me> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231211190908.1882569-1-u@pkh.me> References: <20231211190908.1882569-1-u@pkh.me> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 5/5] avcodec/proresenc_anatoliy: do not write into chroma reserved bitfields X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: =?utf-8?b?Q2zDqW1lbnQgQsWTc2No?= Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: BE9XFqZF70LK The layout for the frame flags is as follow: chroma_format u(2) reserved u(2) interlace_mode u(2) reserved u(2) chroma_format has 2 allowed values: 0: reserved 1: reserved 2: 4:2:2 3: 4:4:4 interlace_mode has 3 allowed values: 0: progressive 1: tff 2: bff 3: reserved 0x80 is what we expect for "422 not interlaced", and the extra 0x2 from 0x82 is actually writting into the reserved bits. --- libavcodec/proresenc_anatoliy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c index 727199ed3b..7c2ec7b3fe 100644 --- a/libavcodec/proresenc_anatoliy.c +++ b/libavcodec/proresenc_anatoliy.c @@ -751,7 +751,7 @@ static int prores_encode_frame(AVCodecContext *avctx, AVPacket *pkt, bytestream_put_buffer(&buf, ctx->vendor, 4); bytestream_put_be16(&buf, avctx->width); bytestream_put_be16(&buf, avctx->height); - frame_flags = 0x82; /* 422 not interlaced */ + frame_flags = 0x80; /* 422 not interlaced */ if (avctx->profile >= AV_PROFILE_PRORES_4444) /* 4444 or 4444 Xq */ frame_flags |= 0x40; /* 444 chroma */ if (ctx->is_interlaced) {