| Message ID | 20231212210240.19886-1-remi@remlab.net |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel,1/2] checkasm/lpc: test compute_autocorr | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | success | Make fate finished |
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
On Tue, Dec 12, 2023 at 11:02:39PM +0200, Rémi Denis-Courmont wrote: > --- > tests/checkasm/lpc.c | 42 ++++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 40 insertions(+), 2 deletions(-) Often this works, but not always ffmpeg/tests/checkasm/checkasm --test=lpc checkasm: using random seed 3321308425 SSE2: - lpc.apply_welch_window_even [OK] - lpc.apply_welch_window_odd [OK] - lpc.compute_autocorr_10 [OK] - lpc.compute_autocorr_30 [OK] - lpc.compute_autocorr_32 [OK] AVX2: - lpc.apply_welch_window_even [OK] - lpc.apply_welch_window_odd [OK] checkasm: all 7 tests passed $ ffmpeg/tests/checkasm/checkasm --test=lpc checkasm: using random seed 3962111 SSE2: - lpc.apply_welch_window_even [OK] - lpc.apply_welch_window_odd [OK] - lpc.compute_autocorr_10 [OK] - lpc.compute_autocorr_30 [OK] - lpc.compute_autocorr_32 [OK] AVX2: - lpc.apply_welch_window_even [OK] - lpc.apply_welch_window_odd [OK] checkasm: all 7 tests passed $ ffmpeg/tests/checkasm/checkasm --test=lpc checkasm: using random seed 2098118744 SSE2: - lpc.apply_welch_window_even [OK] - lpc.apply_welch_window_odd [OK] - lpc.compute_autocorr_10 [OK] - lpc.compute_autocorr_30 [OK] - lpc.compute_autocorr_32 [OK] AVX2: - lpc.apply_welch_window_even [OK] - lpc.apply_welch_window_odd [OK] checkasm: all 7 tests passed $ ffmpeg/tests/checkasm/checkasm --test=lpc checkasm: using random seed 2281870905 SSE2: - lpc.apply_welch_window_even [OK] - lpc.apply_welch_window_odd [OK] - lpc.compute_autocorr_10 [OK] - lpc.compute_autocorr_30 [OK] - lpc.compute_autocorr_32 [OK] AVX2: - lpc.apply_welch_window_even [OK] - lpc.apply_welch_window_odd [OK] checkasm: all 7 tests passed $ ffmpeg/tests/checkasm/checkasm --test=lpc checkasm: using random seed 258427554 SSE2: - lpc.apply_welch_window_even [OK] - lpc.apply_welch_window_odd [OK] - lpc.compute_autocorr_10 [OK] - lpc.compute_autocorr_30 [OK] - lpc.compute_autocorr_32 [OK] AVX2: - lpc.apply_welch_window_even [OK] - lpc.apply_welch_window_odd [OK] checkasm: all 7 tests passed $ ffmpeg/tests/checkasm/checkasm --test=lpc checkasm: using random seed 966320013 SSE2: - lpc.apply_welch_window_even [OK] - lpc.apply_welch_window_odd [OK] 0: 976.228035341704 - 976.998462662304 = -0.7704273206 autocorr_10_sse2 (lpc.c:81) - lpc.compute_autocorr_10 [FAILED] 0: 966.946397975397 - 967.716825295995 = -0.770427320599 autocorr_30_sse2 (lpc.c:81) - lpc.compute_autocorr_30 [FAILED] 0: 968.085384693526 - 968.855812014127 = -0.770427320601 autocorr_32_sse2 (lpc.c:81) - lpc.compute_autocorr_32 [FAILED] AVX2: - lpc.apply_welch_window_even [OK] - lpc.apply_welch_window_odd [OK] checkasm: 3 of 7 tests have failed $ ffmpeg/tests/checkasm/checkasm --test=lpc checkasm: using random seed 470640728 SSE2: - lpc.apply_welch_window_even [OK] - lpc.apply_welch_window_odd [OK] - lpc.compute_autocorr_10 [OK] - lpc.compute_autocorr_30 [OK] - lpc.compute_autocorr_32 [OK] AVX2: - lpc.apply_welch_window_even [OK] - lpc.apply_welch_window_odd [OK] checkasm: all 7 tests passed [...]
Le torstaina 14. joulukuuta 2023, 18.41.24 EET Michael Niedermayer a écrit : > SSE2: > - lpc.apply_welch_window_even [OK] > - lpc.apply_welch_window_odd [OK] > 0: 976.228035341704 - 976.998462662304 = -0.7704273206 > autocorr_10_sse2 (lpc.c:81) > - lpc.compute_autocorr_10 [FAILED] > 0: 966.946397975397 - 967.716825295995 = -0.770427320599 > autocorr_30_sse2 (lpc.c:81) > - lpc.compute_autocorr_30 [FAILED] > 0: 968.085384693526 - 968.855812014127 = -0.770427320601 Right, it seems that the SSE optimisations craps out on odd length. The RVV code seems to match the C code there, so I am not sure if this is exposing an existing bug in the SSE code, or if odd length are illegal. On a related note, we should probably test for odd lag values, as the C code has special handling for them. But from a quick glance, it seems that the SSE code also fails to deal with that case. > autocorr_32_sse2 (lpc.c:81) > - lpc.compute_autocorr_32 [FAILED] > AVX2: > - lpc.apply_welch_window_even [OK] > - lpc.apply_welch_window_odd [OK] > checkasm: 3 of 7 tests have failed > $ ffmpeg/tests/checkasm/checkasm --test=lpc > checkasm: using random seed 470640728 > SSE2: > - lpc.apply_welch_window_even [OK] > - lpc.apply_welch_window_odd [OK] > - lpc.compute_autocorr_10 [OK] > - lpc.compute_autocorr_30 [OK] > - lpc.compute_autocorr_32 [OK] > AVX2: > - lpc.apply_welch_window_even [OK] > - lpc.apply_welch_window_odd [OK] > checkasm: all 7 tests passed > > > [...]
diff --git a/tests/checkasm/lpc.c b/tests/checkasm/lpc.c index 592e34c03d..4d84defec3 100644 --- a/tests/checkasm/lpc.c +++ b/tests/checkasm/lpc.c @@ -57,10 +57,41 @@ static void test_window(int len) bench_new(src, len, dst1); } +static void test_compute_autocorr(ptrdiff_t len, int lag) +{ + LOCAL_ALIGNED(16, double, src, [5000]); + LOCAL_ALIGNED(16, double, dst0, [MAX_LPC_ORDER + 1]); + LOCAL_ALIGNED(16, double, dst1, [MAX_LPC_ORDER + 1]); + + declare_func(void, const double *in, ptrdiff_t len, int lag, double *out); + + av_assert0(lag >= 0 && lag <= MAX_LPC_ORDER); + + for (size_t i = 0; i < len; i++) { + src[i] = (double)rnd() / (double)UINT_MAX; + } + + call_ref(src, len, lag, dst0); + call_new(src, len, lag, dst1); + + for (size_t i = 0; i < lag; i++) { + if (!double_near_abs_eps(dst0[i], dst1[i], EPS)) { + fprintf(stderr, "%zu: %- .12f - %- .12f = % .12g\n", + i, dst0[i], dst1[i], dst0[i] - dst1[i]); + fail(); + break; + } + } + + bench_new(src, len, lag, dst1); +} + void checkasm_check_lpc(void) { LPCContext ctx; - int len = rnd() % 5000; + int len = 2000 + (rnd() % 3000); + static const int lags[] = { 10, 30, 32 }; + ff_lpc_init(&ctx, 32, 16, FF_LPC_TYPE_DEFAULT); if (check_func(ctx.lpc_apply_welch_window, "apply_welch_window_even")) { @@ -72,6 +103,13 @@ void checkasm_check_lpc(void) test_window(len | 1); } report("apply_welch_window_odd"); - ff_lpc_end(&ctx); + + for (size_t i = 0; i < FF_ARRAY_ELEMS(lags); i++) { + ff_lpc_init(&ctx, 32, lags[i], FF_LPC_TYPE_DEFAULT); + if (check_func(ctx.lpc_compute_autocorr, "autocorr_%d", lags[i])) + test_compute_autocorr(len, lags[i]); + report("compute_autocorr_%d", lags[i]); + ff_lpc_end(&ctx); + } }