From patchwork Mon Dec 18 09:57:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anton Khirnov X-Patchwork-Id: 45205 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:1225:b0:181:818d:5e7f with SMTP id v37csp7221739pzf; Mon, 18 Dec 2023 01:58:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IFmiUOwbGSlBob1qSN/VX5z7u/T6zesc+C5cRhjG5O9Uz40XqgnOsBjZYvFmo2Y7pmyCesQ X-Received: by 2002:a17:906:39d6:b0:a22:dc72:afb1 with SMTP id i22-20020a17090639d600b00a22dc72afb1mr5607879eje.118.1702893494108; Mon, 18 Dec 2023 01:58:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702893494; cv=none; d=google.com; s=arc-20160816; b=HxQegSUIX/ZAM/Mm/0XLzimSoCzAF09uBlxhlK4NW8t2YugtUhypSsRPS5x6mlSdX7 IK730BIM9iV1vLj71vwcvGNHhynxQ5f/NO4g910KqSQgkdW1kcoKDuFe0alqZlQDAVT3 SRPcBE9TpNRGNTUG3rvmCdZiJu8MHpXhIIf+DRzAQohw0LNq2siumCP4EG1ThByLb/Oa 7ZO0n4BecMTbgr4cLaapcurUUeU1XFy1cGjqq+4glRzqlhrihT/LXmC9GhBfyNkE6FN0 cKGx2F7WSYtVYcwq5TQxEXc3ftG4MMFs1c7N1ERuRxnr2wtGGhlKPdvjAMk5DKxOHtbW L9hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :delivered-to; bh=AvEA7Eoo+v+lpr44qRVHOcZVpczT5dZ8Ao2HW3xolM0=; fh=YOA8vD9MJZuwZ71F/05pj6KdCjf6jQRmzLS+CATXUQk=; b=aUtn/lUVQPu6ER5HcdjrQ3FxETc8WBEAGmRndqyH9C2n1zFcoS/tiOMQF1AilaASH7 93HwQMcPF4X1P5wUsrYxL9XN/Shm4nQ/71GKvWIgm+c5t4oaoqnqbTmU0G6lYl2vwnU2 oF2dCU+0b1A1vMxuJr8RPp9KSCwkh0Q0cf7EVGCz79+cMGiaZa/vjQku9Bx+27ckXunR WKhwxIZjbY5XSz6+8u4AEb/Gr8RyxvPlaOMB1pZ+FdI7HuG/7j67O1NpOz0kEixyONik vANFuepAeuHoToB4LEeCyGHN5SmpwP2MZmY/W6W3GcpJJkMtl5sX7Q9WxCjtM3f61tnc u+pA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id i14-20020a170906a28e00b00a23337f6a1fsi1610913ejz.87.2023.12.18.01.58.13; Mon, 18 Dec 2023 01:58:14 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6ECE968D1CE; Mon, 18 Dec 2023 11:58:01 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail1.khirnov.net (quelana.khirnov.net [94.230.150.81]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5990A68D1C9 for ; Mon, 18 Dec 2023 11:57:53 +0200 (EET) Received: from localhost (mail1.khirnov.net [IPv6:::1]) by mail1.khirnov.net (Postfix) with ESMTP id 0B87E1372 for ; Mon, 18 Dec 2023 10:57:53 +0100 (CET) Received: from mail1.khirnov.net ([IPv6:::1]) by localhost (mail1.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id Dl8-9mNWHXKo for ; Mon, 18 Dec 2023 10:57:52 +0100 (CET) Received: from libav.khirnov.net (libav.khirnov.net [IPv6:2a00:c500:561:201::7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "libav.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail1.khirnov.net (Postfix) with ESMTPS id 41B411365 for ; Mon, 18 Dec 2023 10:57:51 +0100 (CET) Received: from libav.khirnov.net (libav.khirnov.net [IPv6:::1]) by libav.khirnov.net (Postfix) with ESMTP id E31583A0336 for ; Mon, 18 Dec 2023 10:57:43 +0100 (CET) From: Anton Khirnov To: ffmpeg-devel@ffmpeg.org Date: Mon, 18 Dec 2023 10:57:03 +0100 Message-ID: <20231218095722.25879-1-anton@khirnov.net> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 01/20] fftools/ffmpeg_filter: only set framerate for video X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: gxkK4JsLqe0Y Otherwise an unitialized stack value would be copied to FPSConvContext. As it's then never used, it tends not to be a problem in practice, however it is UB and some compilers warn about it. --- fftools/ffmpeg_filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index 9fc877b437..e219594a4a 100644 --- a/fftools/ffmpeg_filter.c +++ b/fftools/ffmpeg_filter.c @@ -2017,9 +2017,9 @@ static int choose_out_timebase(OutputFilterPriv *ofp, AVFrame *frame) if (!(tb.num > 0 && tb.den > 0)) tb = frame->time_base; + fps->framerate = fr; finish: ofp->tb_out = tb; - fps->framerate = fr; ofp->tb_out_locked = 1; return 0;