From patchwork Fri Dec 22 12:12:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Almer X-Patchwork-Id: 45292 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:6623:b0:194:e134:edd4 with SMTP id n35csp1017419pzh; Fri, 22 Dec 2023 04:12:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IHENjCorG4Qh7tM92C0G0utPYdna8E/NxnyyN2aNrQOhI1mZvYhKNIIpe50/Oq2ule6ArDL X-Received: by 2002:a50:ab58:0:b0:553:8e01:35ba with SMTP id t24-20020a50ab58000000b005538e0135bamr571906edc.54.1703247171474; Fri, 22 Dec 2023 04:12:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703247171; cv=none; d=google.com; s=arc-20160816; b=Y2xdwAdPKnDMIYhHF2hq4dWWij04qdxCGcxAUP/96QKoDGPelXZj5X9UNNX6zEc9gs egBBbgrkZgtcWjFYqyNXF/yBgjLRsRBN38T8YF84BYOW3bJsjC44ShABzETENpuxoYqu TzSR4W7T0vqxcjmO1bcyxUEPp9F4WQ47PRcHuWtMgrIIZXxr+W2p8p5pwbgdVDMjjWDF c8RyztJ+Oq+KRKtyi7sHS86h35VdVn7eU0MGsOIsIHP0MAVzZAaC54WE454J+wkX5hBF 4dee7J58kr8bv3+LtHJ8gqRCpE6IZGM+0Fos3Yg7fYZ9Pk1f9WIJjcPbVI/wVVmy1aqB nziA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=m5Nog1AFrGiBTgfYHM45ucmwftmudFJIcO4wOUb0Hvs=; fh=YOA8vD9MJZuwZ71F/05pj6KdCjf6jQRmzLS+CATXUQk=; b=kCtFs+825nyInTrT/Z1UedaZlgd82y+1v5RnhGIgiP3etgL6cvyFnbIslQHtiZ8ecO XLHMUmVpCOCeYzTn5KL/koYkvMC4K3NpkXewPf8CiYZdrvlrQSwW7X7J90Z3JW+UOj3A sgzOJWXaEkeN2VGj6m1jCm5ORMDagqRKlKVobC0jSyEi6Ld+HHf6M9hxpOvHteC+IuAR rWTtMbiHeL+sm7ukG39j8YoYHaHYGab3dCXmYWZ1ia1dliFS3RdmYDZI9KUjlizeyiaj zHS+/ZfTQHNpLjr6BPy2yrxCuZHQGB4wURUEW3fHzKxj9aDQ4atW9qgOT7xIIliNumy5 PzfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=FOy38tzT; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id r10-20020a50d68a000000b005545e655cf7si360790edi.487.2023.12.22.04.12.48; Fri, 22 Dec 2023 04:12:51 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=FOy38tzT; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6E41468D2E4; Fri, 22 Dec 2023 14:12:45 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7332868D030 for ; Fri, 22 Dec 2023 14:12:38 +0200 (EET) Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1d40eec5e12so10463825ad.1 for ; Fri, 22 Dec 2023 04:12:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703247156; x=1703851956; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=eRiOTuD+Ws1ri4rybHJkPM8Tr59itzQpbUO8yQo7BjY=; b=FOy38tzTlQtHk6QXqbmyKrD0+mzQm0SIxfaq5OnHBDBriBk4LJb0GOQ4sWiUBW9K8A Kl9eSS9Wz5XHeJW4loIEdnxzNOAPHmXHZb9QcmPIlMJGkNsfjKWbh178sOK86SHdGiWs 2zAK1v8nk6WIVBp4Rw9semH73PaBaTzG2r8bN9zomHavNwSOgpnCjy07CXYlNuPskve3 rN5dSl3wkdNdEc8oPuMMafIttWXVDPtKQBfgNMmLdaAJaHknbaTTX9k5HKLiyvLYXaQF hF4/rmo+i2F911uyViu7pIexaAFDYJhhAgldPrEXcDi89Jtu3337jZEu4a8qN+v2sdC/ b7Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703247156; x=1703851956; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eRiOTuD+Ws1ri4rybHJkPM8Tr59itzQpbUO8yQo7BjY=; b=vMe14BweQyHopl2QmiWs7UIuZKBpvwc5ZnEfYQCH3qxCshbNwn6WfFZrZfIF0KWjYp zwRHTPd/+SifTpSS8nksuZnzQ4zz3f+np5a2ilbwa881zGddzFEQzGjC6VhiSFKva86m H5W+k3fSL977+j6sPwy2GFwQY49RPThyoOUrJOCAF4uCungwUf4V8ZPpulkhLlKsOkfA 43rqw/nBeVuS3autDgFZM1Y5Q0LC6j+vtzjB2VuGKSZtujS5vKOr4oPUQ3jEQ142kv6z s0EEQnIgfDSNkxi7+grPXW2rMx9McQVvtWOZ/y2ZdsuPtzUEy+66SmRtxSqHVfDHNJxb z69w== X-Gm-Message-State: AOJu0Yygz/2OwqVVde0gzzYilgoe3BqtKuMkNIIVJ9q511dIOG3skyTx BCrFT6EaKnntXXFoxQi/z/ueGTBLKKA= X-Received: by 2002:a17:903:40c4:b0:1d3:9f6e:cd89 with SMTP id t4-20020a17090340c400b001d39f6ecd89mr1156859pld.98.1703247155389; Fri, 22 Dec 2023 04:12:35 -0800 (PST) Received: from localhost.localdomain (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001d09c5424d4sm3280608plx.297.2023.12.22.04.12.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Dec 2023 04:12:34 -0800 (PST) From: James Almer To: ffmpeg-devel@ffmpeg.org Date: Fri, 22 Dec 2023 09:12:30 -0300 Message-ID: <20231222121232.324-1-jamrial@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 1/3 v2] checkasm/takdsp: add decorrelate_sf test X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: jmwuBr4iUFhC Signed-off-by: James Almer --- Fixes broken logic as reported by Martin. tests/checkasm/takdsp.c | 35 ++++++++++++++++++++++++++++++++--- 1 file changed, 32 insertions(+), 3 deletions(-) diff --git a/tests/checkasm/takdsp.c b/tests/checkasm/takdsp.c index 3aecee1f72..78528b1c5d 100644 --- a/tests/checkasm/takdsp.c +++ b/tests/checkasm/takdsp.c @@ -24,6 +24,7 @@ #include "libavutil/mem_internal.h" #include "libavcodec/takdsp.h" +#include "libavcodec/mathops.h" #include "checkasm.h" @@ -33,8 +34,9 @@ buf[i] = rnd(); \ } while (0) -static void test_decorrelate_ls(TAKDSPContext *s) { #define BUF_SIZE 1024 + +static void test_decorrelate_ls(TAKDSPContext *s) { declare_func(void, int32_t *, int32_t *, int); if (check_func(s->decorrelate_ls, "decorrelate_ls")) { @@ -60,7 +62,6 @@ static void test_decorrelate_ls(TAKDSPContext *s) { } static void test_decorrelate_sr(TAKDSPContext *s) { -#define BUF_SIZE 1024 declare_func(void, int32_t *, int32_t *, int); if (check_func(s->decorrelate_sr, "decorrelate_sr")) { @@ -86,7 +87,6 @@ static void test_decorrelate_sr(TAKDSPContext *s) { } static void test_decorrelate_sm(TAKDSPContext *s) { -#define BUF_SIZE 1024 declare_func(void, int32_t *, int32_t *, int); if (check_func(s->decorrelate_sm, "decorrelate_sm")) { @@ -114,6 +114,34 @@ static void test_decorrelate_sm(TAKDSPContext *s) { report("decorrelate_sm"); } +static void test_decorrelate_sf(TAKDSPContext *s) { + declare_func(void, int32_t *, int32_t *, int, int, int); + + if (check_func(s->decorrelate_sf, "decorrelate_sf")) { + LOCAL_ALIGNED_32(int32_t, p1, [BUF_SIZE]); + LOCAL_ALIGNED_32(int32_t, p1_2, [BUF_SIZE]); + LOCAL_ALIGNED_32(int32_t, p2, [BUF_SIZE]); + int dshift, dfactor; + + randomize(p1, BUF_SIZE); + memcpy(p1_2, p1, BUF_SIZE * sizeof(*p1)); + randomize(p2, BUF_SIZE); + dshift = (rnd() & 0xF) + 1; + dfactor = sign_extend(rnd(), 10); + + call_ref(p1, p2, BUF_SIZE, dshift, dfactor); + call_new(p1_2, p2, BUF_SIZE, dshift, dfactor); + + if (memcmp(p1, p1_2, BUF_SIZE) != 0) { + fail(); + } + + bench_new(p1, p2, BUF_SIZE, dshift, dfactor); + } + + report("decorrelate_sf"); +} + void checkasm_check_takdsp(void) { TAKDSPContext s = { 0 }; @@ -122,4 +150,5 @@ void checkasm_check_takdsp(void) test_decorrelate_ls(&s); test_decorrelate_sr(&s); test_decorrelate_sm(&s); + test_decorrelate_sf(&s); }