From patchwork Wed Dec 27 16:25:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abhishek Ojha X-Patchwork-Id: 45349 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:6623:b0:194:e134:edd4 with SMTP id n35csp3707785pzh; Wed, 27 Dec 2023 08:25:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IExaToD5UFh0jayf5yFE6HQt6ZSUjEi/lI0VQyvBHuxNL9B4TKPmPvL7jTvcFNmUOKaz/Vn X-Received: by 2002:a50:d598:0:b0:553:50d9:89e2 with SMTP id v24-20020a50d598000000b0055350d989e2mr4731958edi.19.1703694358645; Wed, 27 Dec 2023 08:25:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703694358; cv=none; d=google.com; s=arc-20160816; b=d9wwMWAqjtPDiTZI0HkFFbSZE2/qT3nzW93M4a5gt1nZOkJI8+O1dH+SIW4j3Rmt5f nZyRSOb9SsKwG23YwZyfE0q/0MqIXjILEe5OhEsnK4UZRB6yahBKK4jzYtG9DNrYd7iv TVVs/TGDQM/1WmM1TA65vBs2C6aBSwePZ6DIRcN7mb3H16S+PyB9yWJs5EgH3467GOKr B0qlOEbsoQC3Wozsq/VqMLrlwfv7eLeaB1JmdslLTRFtoh5WhZDgJDOo2AY6fBJPvVs1 02j8hKENvt1HK9OR5aPz7vosj94pkxsyKIjXY2hQhoHaHzwss0/hyS/T6NS7Alz5UFrL 9Nhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:dkim-filter:delivered-to; bh=4oW6S8kVpXBL8eJL1sK5MkX/PV0AuHTCYMlAoQhtW6M=; fh=EoDQIxrGX5YoxE06pcRJp2YbYXp56qGDzCRNcLmuGVo=; b=twybvXdOZ+WhwYmX0ZnVKLh05V7ZehJfWDfpLFNJ6gowO2alXjsIBnMOl258+tErpc N3YUi+BnyT1JlLZShC2YYIKngD5oNIioAK+/Yp8rr1T0RPr9DwdnEev/dtO67xWQ1IHs T8vGsnwAetgNXzLOjrfn5xZsZ3nZCoxq1Bcz6T0EX3VJ3+pZxpPkvgaF3Uh+mOct4eDx 5xt6dYzU7OoljTlEr8RvkEjEt4fFrcoyFtIW1pmMPqeQqkEjEATkvZHbm28Zwk1R1Krz FY+tnmKqDg5p2wNcOOZfSecqQnq5+rCfXcOjYlnOnSZrzxey+W62wo49rPaEM78++2rF E9eQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@savoirfairelinux.com header.s=DFC430D2-D198-11EC-948E-34200CB392D2 header.b=dswJzgbo; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id u21-20020a50d515000000b005534fb7d47asi6340225edi.538.2023.12.27.08.25.55; Wed, 27 Dec 2023 08:25:58 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@savoirfairelinux.com header.s=DFC430D2-D198-11EC-948E-34200CB392D2 header.b=dswJzgbo; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C9C5D68CA1F; Wed, 27 Dec 2023 18:25:40 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail.savoirfairelinux.com (mail.savoirfairelinux.com [208.88.110.44]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 722C368C7B6 for ; Wed, 27 Dec 2023 18:25:32 +0200 (EET) Received: from localhost (localhost [127.0.0.1]) by mail.savoirfairelinux.com (Postfix) with ESMTP id 0AF369C4180 for ; Wed, 27 Dec 2023 11:25:30 -0500 (EST) Received: from mail.savoirfairelinux.com ([127.0.0.1]) by localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavis, port 10032) with ESMTP id ymxwdlNrpkrh; Wed, 27 Dec 2023 11:25:29 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mail.savoirfairelinux.com (Postfix) with ESMTP id B6F7A9C40F9; Wed, 27 Dec 2023 11:25:29 -0500 (EST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.savoirfairelinux.com B6F7A9C40F9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=savoirfairelinux.com; s=DFC430D2-D198-11EC-948E-34200CB392D2; t=1703694329; bh=eMK354cbC/L8hN/IEudRmz/ZCTtZMsxxkxINbs3b27U=; h=From:To:Date:Message-Id:MIME-Version; b=dswJzgbo3XzX5K2Bdd2yyZu57mmLx7wyMG3Du0GP0cnOcGzuyqRAMuEU8Pi2GZryn wMYRoaQgfqpASkwjyWWQ22Qa68fn916+0ZZiH97pufOrY6Nq3QwfscGluA8iex8c2D G4iFlButf5miqwD/YitJFgYqPcdW+ygpe2VliuWCPAAqBpUnhC/1iwEtdzdwRGiC93 PrPnKlLVk67xo3iGgAjDPRBkuFUkcYY2fhynVCBqacVOza3ymh7JUmOM2EIpqG9OjX LPDqTrLXD49oTITcZkVvx6LZL28GLZwSUs3geu9pPmxVCrdtu0M9a+uiq2agdhmScg WW84YQgQugpNA== X-Virus-Scanned: amavis at mail.savoirfairelinux.com Received: from mail.savoirfairelinux.com ([127.0.0.1]) by localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavis, port 10026) with ESMTP id rfFWWlr12yFg; Wed, 27 Dec 2023 11:25:29 -0500 (EST) Received: from asuspc2.taile0726.ts.net (unknown [192.168.51.254]) by mail.savoirfairelinux.com (Postfix) with ESMTP id 9EC999C29FB; Wed, 27 Dec 2023 11:25:29 -0500 (EST) From: Abhishek Ojha To: ffmpeg-devel@ffmpeg.org Date: Wed, 27 Dec 2023 11:25:03 -0500 Message-Id: <20231227162504.690730-2-abhishek.ojha@savoirfairelinux.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231227162504.690730-1-abhishek.ojha@savoirfairelinux.com> References: <20231227162504.690730-1-abhishek.ojha@savoirfairelinux.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 2/2] configure: disable locale use in spa plugin X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Abhishek Ojha Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: gbqE4gVQZE5E This commit requires to resolve the compilation error of pipewiregrab because Pipewire's spa plugin is requesting locale_t extension to compile. Which was added in POSIX 2008 but ffmpeg is using POSIX 2001 due to which spa plugin complains. __LOCALE_C_ONLY flag is set to disable the locale usage in spa plugin. Adding it in configure file fix both the library test and source compilation issue. Not sure if this is the right approach to fix the issue. Feedback/Suggestions will be highly appreciated. Signed-off-by: Abhishek Ojha --- configure | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure b/configure index 375327d5fa..442d004258 100755 --- a/configure +++ b/configure @@ -7106,6 +7106,8 @@ if enabled libxcb; then enabled libxcb_xfixes && check_pkg_config libxcb_xfixes xcb-xfixes xcb/xfixes.h xcb_xfixes_get_cursor_image fi +# _POSIX_C_SOURCE=200112 doesn't support locale +add_cppflags -D__LOCALE_C_ONLY enabled libpipewire && check_pkg_config libpipewire "libpipewire-0.3 >= 0.3.40" pipewire/pipewire.h pw_init if enabled libpipewire; then enabled libgio_unix && check_pkg_config libgio_unix gio-unix-2.0 gio/gio.h g_main_loop_new