From patchwork Sun Jan 28 09:00:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anton Khirnov X-Patchwork-Id: 45865 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:8786:b0:199:de12:6fa6 with SMTP id ph6csp929631pzb; Sun, 28 Jan 2024 01:01:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IF0eW0D97ZiAT5OAJs4n2Fn26+CZcFv8bZNOEjI4K5E5I7ln6Rsmx5jRIvTuGR5YOQB5mDx X-Received: by 2002:a17:906:f74a:b0:a35:87c3:e2af with SMTP id jp10-20020a170906f74a00b00a3587c3e2afmr834118ejb.40.1706432476722; Sun, 28 Jan 2024 01:01:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1706432476; cv=none; d=google.com; s=arc-20160816; b=ugjnUf3aRqJBfn/2h1U4tyjEsdJxN3HTT/6OEAGNPlOaRxwO5Xw/RF4ZCXjrEK8IM6 /z4bGIWN7sVu4Xq6MilzYMDU27QjeN23gEs5K53ENkeSvXw5qHblMAXuxNpJRfDbkh9e 7D1LrAnzRrhXhISsc1jQvRo7BfnZxxwhIs1RritFilBnBIttpMyJB3CXYfgkwyjkyHio n15HsnJ9MPYEBpUN1NPqe8VwOLk0BNNHCeRGqCB/O0f/x71HRxtRIwwiz/BDvk0yJeCm 8MKcebi59uDREWG626zEuugfNoFAlA9S6osvHye+GcMEJQ4H8yttDYKcDRJ4aaPIcEOw hFIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=SQXZ/hGkQpY666OmI1FdnC3rlD7OpoynID9CNFpZ4dE=; fh=YOA8vD9MJZuwZ71F/05pj6KdCjf6jQRmzLS+CATXUQk=; b=QVatM4R8jmD8iOKoBwuCoYun9WF5L2u8pzl5YJdYvSq928frI6V27TrrvbJX8CoLzm 10dbXrwlnj1B2t4pgUnjOahNqoHSTBYb13GZvb1x4GJD2pJwBSe60BBShZ8jSWNGXuyu xue0prs9kqseZ1/hIs5bxcJEfMek39Kir/KqH8FC0hTkFEgZqCOQOcukYDky0hF9ffPi /MH4rq162pJ8QaSonZu1eWaLvLi0+51m36G61aVANJn/27J/nAfpQHqYIYoKiOAm4SZE F7Cnx9aMNd0TRavRLwR9P3Qni0pdxKwbj5DKlikbC0iUAowhEVyaYFGY6Jdb4sOo6f1L 9ADw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@khirnov.net header.s=mail header.b=W9fW7sf4; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id q6-20020a170906360600b00a23619be213si2352683ejb.159.2024.01.28.01.01.16; Sun, 28 Jan 2024 01:01:16 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@khirnov.net header.s=mail header.b=W9fW7sf4; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8776468D17E; Sun, 28 Jan 2024 11:01:12 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail1.khirnov.net (quelana.khirnov.net [94.230.150.81]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C92AA68CBAD for ; Sun, 28 Jan 2024 11:01:05 +0200 (EET) Authentication-Results: mail1.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=W9fW7sf4; dkim-atps=neutral Received: from localhost (mail1.khirnov.net [IPv6:::1]) by mail1.khirnov.net (Postfix) with ESMTP id A0EFB19CE for ; Sun, 28 Jan 2024 10:01:04 +0100 (CET) Received: from mail1.khirnov.net ([IPv6:::1]) by localhost (mail1.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id HRVVh4SjiZBd for ; Sun, 28 Jan 2024 10:01:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1706432459; bh=raNw58H3x0Z4HBoJbCOhvRESH1BpyPVm9tsnodWwX70=; h=From:To:Subject:Date:From; b=W9fW7sf4n/z/5tE+dv2Davr2X0y3StwgvOeQ87Fk0GpTI2QDByh4b1cJKmy7qqN1U DmtTB8X53I9pPtyXtVamqMMXsz06siBQznG7B8QDckMe6j4whIsTcYTbEVebPJG7Wf jRlLRsH+wpZC1T4xOFBvia9LVn1QZcGldqLk+4qId48+5rbhRkDn/IhxFZmAfJLaPV 5z8JMcLKSJUS3ZcPYdX/OrtF4vciwfEpqFgq2SsY4V47BTHA73IjpnZ/9sIgzOQfpJ XGxY+4TFCbuGMk2QJg7Zms+Kx4eqZAIKDXCP91iVBZ7BhvIKDyeZa6eGie1Z5EMZQQ eDWAUylT3BSKQ== Received: from libav.khirnov.net (libav.khirnov.net [IPv6:2a00:c500:561:201::7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "libav.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail1.khirnov.net (Postfix) with ESMTPS id D7EC691F for ; Sun, 28 Jan 2024 10:00:59 +0100 (CET) Received: from libav.khirnov.net (libav.khirnov.net [IPv6:::1]) by libav.khirnov.net (Postfix) with ESMTP id 932F03A0534 for ; Sun, 28 Jan 2024 10:00:53 +0100 (CET) From: Anton Khirnov To: ffmpeg-devel@ffmpeg.org Date: Sun, 28 Jan 2024 10:00:42 +0100 Message-ID: <20240128090042.2878-1-anton@khirnov.net> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] lavd: deprecate the bktr device X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: Vhr0D1ruUNkZ It implements BSD-specific support for very old analog capture cards, which are highly unlikely to be useful today. After being added in 2005, there were never any commits to it beyond compilation fixes and generic maintenance. There have also been zero trac tickets for this device, and the only related web search result I found concludes that it does not work. The code also does some unacceptable things, like messing with signal handlers and storing its state in global variables. --- doc/indevs.texi | 3 ++- libavdevice/bktr.c | 3 +++ libavdevice/version_major.h | 3 +++ 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/doc/indevs.texi b/doc/indevs.texi index a0c684f545..d1b2bacf8b 100644 --- a/doc/indevs.texi +++ b/doc/indevs.texi @@ -222,7 +222,8 @@ $ ffmpeg -f avfoundation -capture_raw_data true -i "zr100:none" out.dv @section bktr -BSD video input device. +BSD video input device. Deprecated and will be removed - please contact +the developers if you are interested in maintaining it. @subsection Options diff --git a/libavdevice/bktr.c b/libavdevice/bktr.c index 196637852f..864726468f 100644 --- a/libavdevice/bktr.c +++ b/libavdevice/bktr.c @@ -264,6 +264,9 @@ static int grab_read_header(AVFormatContext *s1) AVRational framerate; int ret = 0; + av_log(s1, AV_LOG_WARNING, "bktr input is deprecated and will be removed. " + "Please contact the developers if you are interested in maintaining it.\n"); + if (!s->framerate) switch (s->standard) { case PAL: s->framerate = av_strdup("pal"); break; diff --git a/libavdevice/version_major.h b/libavdevice/version_major.h index b884fd4224..9f7b79b2ee 100644 --- a/libavdevice/version_major.h +++ b/libavdevice/version_major.h @@ -33,4 +33,7 @@ * the public API and may change, break or disappear at any time. */ +// reminder to remove the bktr device on next major bump +#define FF_API_BKTR_DEVICE (LIBAVDEVICE_VERSION_MAJOR < 62) + #endif /* AVDEVICE_VERSION_MAJOR_H */