From patchwork Sun Jan 28 09:40:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anton Khirnov X-Patchwork-Id: 45866 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:8786:b0:199:de12:6fa6 with SMTP id ph6csp941980pzb; Sun, 28 Jan 2024 01:40:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IE3x7ehKG84c1Uyo37JCzOGhb/dFfj3+id0sZgkiVB7lCYBpC/4MTZ+DuqvEIiIBy2TlcFB X-Received: by 2002:a17:907:76c7:b0:a2c:5139:8b11 with SMTP id kf7-20020a17090776c700b00a2c51398b11mr2175081ejc.56.1706434850452; Sun, 28 Jan 2024 01:40:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1706434850; cv=none; d=google.com; s=arc-20160816; b=vVIU5X83FJSPhF9xfaeyGoEt43hSi7+di27nNmDhJQT3l7HdHdFSPDsmocG0CrfqxE H+IYuR4v99fE7CamRpSMCd9KCjKkZvOPbicRQiQZWd0CvSzDrVaaNtkYMf7Zt3keHvOf yIFI8fr2iZxODOyjWPXwFHHs84OZtyxRlnORbJGJewnR1FPsAsWeyUDQttl7MNUokDta 8L29LEKOCBYgLP4ygVC17hCtlZyCgAr1uBxTxHxRXd7IArTG5w31NhU6NTz0hlwE1HYB pv0AAEHLWvITD/g1/EVQOpyjYQyV1sgg63W+k5wKgoRnO/fVjXFmpy0z6f0LnXE5PY0g HoqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=Q5CG9+7Dhk98lL/xnQtBrbvHp2e6LYUS2yaOaUrlkv0=; fh=YOA8vD9MJZuwZ71F/05pj6KdCjf6jQRmzLS+CATXUQk=; b=AqiLHmYgFubfTPxUWX5i4S3gg4HmlbAmzSFvhQcyQrvCZsezewpP4fyOKTeKYhW4Ab puwnJ5hPe7ShBxoRhkqbGlYH0hvMfcKTwi6tdyeOLYWM6FVixWD+KBAUKKQ8+tpmRUJK wRN9kt0Zxbt4HZ/NNd2xb8iWrH5OaE75ABUL3vzyuWvr1aodt7kXPVaecovlDV4vLD+5 IfHEL9WwZl6M7ymYsNCQ2fzKqf3rjAHU8Hhiu7GnsR2a5Y+MBYJO+p/f8E0a1PjQCG5M ur8QsegU43pPWPXBaxdtzn2dj61uk0UtywBDETa5dQe4Y/ef7YGCpxe3H7We0TOdzg8l t3CA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@khirnov.net header.s=mail header.b="IzQXILg/"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a21-20020a170906685500b00a3543f8bf9fsi1243977ejs.587.2024.01.28.01.40.50; Sun, 28 Jan 2024 01:40:50 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@khirnov.net header.s=mail header.b="IzQXILg/"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 92F6268D181; Sun, 28 Jan 2024 11:40:46 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail1.khirnov.net (quelana.khirnov.net [94.230.150.81]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6D5E368D14A for ; Sun, 28 Jan 2024 11:40:39 +0200 (EET) Authentication-Results: mail1.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=IzQXILg/; dkim-atps=neutral Received: from localhost (mail1.khirnov.net [IPv6:::1]) by mail1.khirnov.net (Postfix) with ESMTP id B0A0E1A09 for ; Sun, 28 Jan 2024 10:40:38 +0100 (CET) Received: from mail1.khirnov.net ([IPv6:::1]) by localhost (mail1.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id Rum_WkKJqXW3 for ; Sun, 28 Jan 2024 10:40:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1706434837; bh=Gi+DsDYpXHWFb5/uxIHlw/Tt3mrrDhNzdbC80SwtbEw=; h=From:To:Subject:Date:In-Reply-To:References:From; b=IzQXILg/5iCqT062/Z7tTnYHibkdIz07rAqwJbVdkzwc2q8GBMZWSYQam6VVho6ph UjA+OK0pfWdRCXcGW9rRFZTxtJYZ5vA2PMIp53+K4xESuK/jSPqwsohVw6zvDhDJj6 RDIJbB44ZUh6r5H8aI3P8YySf5dE6g59Nt//JcrF+4kd3NGcB4vCgIxg9QrC3uJesv 2dP1a5YO6XuRXRYdH2dNwfPMOvgbIB0Lw3GH/PneXv0v+WH/smM1qDUUZsFbSxZ8nX wTpS8a34QCLFeAdd+Us3a6Lek81ldRxIc2igBDWoTC5i84LKwX65n4tnMon6/+17Ms NiOKCoPPQFTQQ== Received: from libav.khirnov.net (libav.khirnov.net [IPv6:2a00:c500:561:201::7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "libav.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail1.khirnov.net (Postfix) with ESMTPS id BAD1091F for ; Sun, 28 Jan 2024 10:40:37 +0100 (CET) Received: from libav.khirnov.net (libav.khirnov.net [IPv6:::1]) by libav.khirnov.net (Postfix) with ESMTP id 9645E3A0534 for ; Sun, 28 Jan 2024 10:40:37 +0100 (CET) From: Anton Khirnov To: ffmpeg-devel@ffmpeg.org Date: Sun, 28 Jan 2024 10:40:17 +0100 Message-ID: <20240128094028.6054-1-anton@khirnov.net> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20240125011936.GG6420@pb2> References: <20240125011936.GG6420@pb2> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v2 27/31] fftools/ffmpeg_dec: stop passing InputStream to dec_open() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 0jrjOjw1vIXP --- fftools/ffmpeg.h | 3 ++- fftools/ffmpeg_dec.c | 50 +++++++++++++++++++++++++++--------------- fftools/ffmpeg_demux.c | 4 +++- 3 files changed, 37 insertions(+), 20 deletions(-) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index 02c614d0ff..c8cba72006 100644 --- a/fftools/ffmpeg.h +++ b/fftools/ffmpeg.h @@ -296,6 +296,7 @@ typedef struct DecoderOpts { int flags; char *name; + void *log_parent; const AVCodec *codec; const AVCodecParameters *par; @@ -756,7 +757,7 @@ AVBufferRef *hw_device_for_filter(void); * @param dec_opts Dictionary filled with decoder options. Its ownership * is transferred to the decoder. */ -int dec_open(InputStream *ist, Scheduler *sch, unsigned sch_idx, +int dec_open(Decoder **pdec, Scheduler *sch, unsigned sch_idx, AVDictionary **dec_opts, const DecoderOpts *o); void dec_free(Decoder **pdec); diff --git a/fftools/ffmpeg_dec.c b/fftools/ffmpeg_dec.c index 98cde0a040..0fde686eec 100644 --- a/fftools/ffmpeg_dec.c +++ b/fftools/ffmpeg_dec.c @@ -110,7 +110,7 @@ void dec_free(Decoder **pdec) av_freep(pdec); } -static int dec_alloc(Decoder **pdec) +static int dec_alloc(DecoderPriv **pdec) { DecoderPriv *dp; @@ -133,7 +133,7 @@ static int dec_alloc(Decoder **pdec) dp->last_frame_tb = (AVRational){ 1, 1 }; dp->hwaccel_pix_fmt = AV_PIX_FMT_NONE; - *pdec = &dp->dec; + *pdec = dp; return 0; fail: @@ -940,24 +940,25 @@ static const AVClass dec_class = { .item_name = dec_item_name, }; -int dec_open(InputStream *ist, Scheduler *sch, unsigned sch_idx, +int dec_open(Decoder **pdec, Scheduler *sch, unsigned sch_idx, AVDictionary **dec_opts, const DecoderOpts *o) { DecoderPriv *dp; const AVCodec *codec = o->codec; int ret; - ret = dec_alloc(&ist->decoder); + *pdec = NULL; + + ret = dec_alloc(&dp); if (ret < 0) return ret; - dp = dp_from_dec(ist->decoder); dp->sch = sch; dp->sch_idx = sch_idx; dp->flags = o->flags; dp->dec.class = &dec_class; - dp->log_parent = ist; + dp->log_parent = o->log_parent; dp->framerate_in = o->framerate; @@ -968,31 +969,39 @@ int dec_open(InputStream *ist, Scheduler *sch, unsigned sch_idx, snprintf(dp->log_name, sizeof(dp->log_name), "dec:%s", codec->name); dp->parent_name = av_strdup(o->name ? o->name : ""); - if (!dp->parent_name) - return AVERROR(ENOMEM); + if (!dp->parent_name) { + ret = AVERROR(ENOMEM); + goto fail; + } if (codec->type == AVMEDIA_TYPE_SUBTITLE && (dp->flags & DECODER_FLAG_FIX_SUB_DURATION)) { for (int i = 0; i < FF_ARRAY_ELEMS(dp->sub_prev); i++) { dp->sub_prev[i] = av_frame_alloc(); - if (!dp->sub_prev[i]) - return AVERROR(ENOMEM); + if (!dp->sub_prev[i]) { + ret = AVERROR(ENOMEM); + goto fail; + } } dp->sub_heartbeat = av_frame_alloc(); - if (!dp->sub_heartbeat) - return AVERROR(ENOMEM); + if (!dp->sub_heartbeat) { + ret = AVERROR(ENOMEM); + goto fail; + } } dp->sar_override = o->par->sample_aspect_ratio; dp->dec_ctx = avcodec_alloc_context3(codec); - if (!dp->dec_ctx) - return AVERROR(ENOMEM); + if (!dp->dec_ctx) { + ret = AVERROR(ENOMEM); + goto fail; + } ret = avcodec_parameters_to_context(dp->dec_ctx, o->par); if (ret < 0) { av_log(dp, AV_LOG_ERROR, "Error initializing the decoder context.\n"); - return ret; + goto fail; } dp->dec_ctx->opaque = dp; @@ -1009,23 +1018,28 @@ int dec_open(InputStream *ist, Scheduler *sch, unsigned sch_idx, av_log(dp, AV_LOG_ERROR, "Hardware device setup failed for decoder: %s\n", av_err2str(ret)); - return ret; + goto fail; } if ((ret = avcodec_open2(dp->dec_ctx, codec, dec_opts)) < 0) { av_log(dp, AV_LOG_ERROR, "Error while opening decoder: %s\n", av_err2str(ret)); - return ret; + goto fail; } ret = check_avoptions(*dec_opts); if (ret < 0) - return ret; + goto fail; dp->dec.subtitle_header = dp->dec_ctx->subtitle_header; dp->dec.subtitle_header_size = dp->dec_ctx->subtitle_header_size; + *pdec = &dp->dec; + return 0; +fail: + dec_free((Decoder**)&dp); + return ret; } int dec_add_filter(Decoder *dec, InputFilter *ifilter) diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c index 6216b7c684..5178bcbce4 100644 --- a/fftools/ffmpeg_demux.c +++ b/fftools/ffmpeg_demux.c @@ -933,7 +933,9 @@ static int ist_use(InputStream *ist, int decoding_needed) ds->dec_opts.codec = ist->dec; ds->dec_opts.par = ist->par; - ret = dec_open(ist, d->sch, ds->sch_idx_dec, + ds->dec_opts.log_parent = ist; + + ret = dec_open(&ist->decoder, d->sch, ds->sch_idx_dec, &ist->decoder_opts, &ds->dec_opts); if (ret < 0) return ret;