From patchwork Wed Jan 31 19:37:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Izen X-Patchwork-Id: 45947 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:2c82:b0:199:de12:6fa6 with SMTP id g2csp80567pzj; Wed, 31 Jan 2024 11:37:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IHrkoTICESxgolU+nF283ES5QnH+Z0KX3EnFlJTTjQTEdTTX2sK5jZ7ttoANCqivRg0DuID X-Received: by 2002:ac2:4a74:0:b0:511:2bd4:d4ae with SMTP id q20-20020ac24a74000000b005112bd4d4aemr219249lfp.66.1706729851904; Wed, 31 Jan 2024 11:37:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1706729851; cv=none; d=google.com; s=arc-20160816; b=RwoblYJwOseo/5waAcAhKFnboZvQu/DjXrFGSgEIVAEXq0aM1LpLNKmZEgWUCtbPUI 0/PVw8oBWioA3d2zoxLyR4USZ298fSKHi3Z+1hZ1cALhgxDNglqNOGpcDVfDoWZyr5gk ugUnf7yB9CdRdjX6CmwlJvr4lf9IEUGITVd3JvKHUBxlo2kBsAjeblI3yr1v8HSWyPP4 wThkj/7EiUylpoUlx2f2vpfpNah2Kk5rSEAhxTdLWCrtHpB+/CE2jjJ72FUvVl9dZS35 ighqt3kWNJ2n4gRPptx9geH9/U54TXz+bf93ebJqRE0zirZQ/FvvNmPw10ld32AtuaOS LKKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=6OJOC3AA7VVT6z8gVr7kqyS42cHedrnVackJ4c4OQeM=; fh=+bdjGe20eEUjtjncwA1dnEEVYNfJL4vyhV+sIRR4l+g=; b=oY+ve2RlTcmafyTE8L+QQRbxU3rAs9gnx79KXoS74eScX2sEwakZHCE81M/Ssy/Hyn KfkpZAFeqUZUJnKMvuW2Lzfq7I7FwrCYA7FopFBTXfvw+/qJGdIYBGYnZqa9e1yvdvCQ Z8/q7G/9uOTJqmn3bSg0yJ+qdQfdQ09khOV4gmW1gLELG40BqHFHOpxz79APEzb6pIDC 2LL5s98P16Jhhuvsk/FMmD9l5kTM9FJFFnWCd9kGU7HIkmapYbMYEp6qwDX9QgeKXMtB bNmt5QcpUPXx5RKA3trHnNVb4k7kASRTtCC1tofiLPpnABZD5jmfARR/uCtKGUTWwTxY thow== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=k2RfZaE4; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id l22-20020a1709067d5600b00a341e30b009si5569816ejp.1020.2024.01.31.11.37.31; Wed, 31 Jan 2024 11:37:31 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=k2RfZaE4; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 58B3F688051; Wed, 31 Jan 2024 21:37:28 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 63C5B688051 for ; Wed, 31 Jan 2024 21:37:21 +0200 (EET) Received: by mail-qk1-f182.google.com with SMTP id af79cd13be357-7853e4d3cddso2349385a.1 for ; Wed, 31 Jan 2024 11:37:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706729840; x=1707334640; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=kgPEXBitt9xE+86J/N6sP7F9kTfms33Wcn6RZAyM7Os=; b=k2RfZaE4s7kM6GMG7Xx6lUDRb0j713As+f7Hn5X9w5pLLiIASiQzixoEIvRKM/E8vt /Jmh8eNN6pcMnO2nRoA9+bpERAZ6QoIlCgRX/wPH0aBdq5ovgSwJ/04SAlGamUqqhF3B HW/I+IffFTJm6DxKp1GSQz9E0tOdYNczYjL1HA/l3sXpFXtp88lp6OsYUGcvKy7sqTGQ TCHlLVOqoTiU01wdlNxb5aZ25CW7ydLd6gh0nTtypNsVdHERjM0CAFnnudGu37al+uJT vie5IcfkIXIS3ZD9/hkxj+aiw///FI/2U+AgDZO9Pk0PAfq1SRTiGHv0dEMVCgg2VELd u1cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706729840; x=1707334640; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kgPEXBitt9xE+86J/N6sP7F9kTfms33Wcn6RZAyM7Os=; b=TJea3FsTawzS4i1HO8myDFwoUA8CnDRHOWCJ8Vy/47kDoLt0LW+dUf9b2VCQMNdWmL kuB9iI/QLr+A2P5k8Em4/W17SLO8ZoVPOdv73EiPkmRdvFWO+i8scVjfEykQOnZL0KiB r0vrWm0TJ82cgd9oFivfrK32XvdMJLbs7VUCmR3HIUwrP2M+p47dCM9bQC3S2YloWn4A 29R1ewVNdZ6rgmzxKf595MPYUKeLB/61KBH7o1tG7KSjP0DhscmCe2j12E8Ihzz+BW6f 9MQ9HBd8zhXt05FjUvAIs3WTYdge6pLYFStPpd3r2YiFGaGU0Vp2BG3ooofzztmQ6Kmo y8ZQ== X-Gm-Message-State: AOJu0YxSnqUp7Uyp7QXhsa/m12ExF8X1TTsHoPVXzc4Bg7hPbeAUpHyS ypSkuWca0bv9H7qtZg4OxnQcooEuRaEKj1f0+qzEO/4a0o7u5Oy6H2i6cvv2 X-Received: by 2002:a05:620a:17a5:b0:785:3dba:e1d6 with SMTP id ay37-20020a05620a17a500b007853dbae1d6mr397455qkb.7.1706729839868; Wed, 31 Jan 2024 11:37:19 -0800 (PST) Received: from gauss.local (c-68-56-149-176.hsd1.mi.comcast.net. [68.56.149.176]) by smtp.gmail.com with ESMTPSA id s14-20020a05620a16ae00b0078199077d0asm3241693qkj.125.2024.01.31.11.37.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jan 2024 11:37:19 -0800 (PST) From: Leo Izen To: ffmpeg-devel@ffmpeg.org Date: Wed, 31 Jan 2024 14:37:17 -0500 Message-ID: <20240131193717.407384-1-leo.izen@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avcodec/tiff: pass arguments to bytestream2_seek in the right order X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Leo Izen Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: se7cXdoeDQIh The function signature for bytestream2_seek is (gb, offset, whence); Before this patch, the code passed (gb, SEEK_SET, offset), which is incorrect. Siged-off-by: Leo Izen --- libavcodec/tiff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c index adb49e4525..3ce441aa2c 100644 --- a/libavcodec/tiff.c +++ b/libavcodec/tiff.c @@ -1701,7 +1701,7 @@ static int tiff_decode_tag(TiffContext *s, AVFrame *frame) break; case TIFF_ICC_PROFILE: gb_temp = s->gb; - bytestream2_seek(&gb_temp, SEEK_SET, off); + bytestream2_seek(&gb_temp, off, SEEK_SET); if (bytestream2_get_bytes_left(&gb_temp) < count) return AVERROR_INVALIDDATA;