From patchwork Fri Feb 9 09:11:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Connor Worley X-Patchwork-Id: 46125 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:a586:b0:19e:8a94:b663 with SMTP id gd6csp806639pzc; Fri, 9 Feb 2024 01:13:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IEzF7tekywgMC+SpsJta+KT3isliFUHDwiKOzwmKUkrIW+T1/BJmf0umuJoV9uIhvsv8fS7 X-Received: by 2002:a05:6402:3446:b0:55f:cef0:5fe7 with SMTP id l6-20020a056402344600b0055fcef05fe7mr779132edc.0.1707469995406; Fri, 09 Feb 2024 01:13:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1707469995; cv=none; d=google.com; s=arc-20160816; b=McwDvCZxZmuUQnEW6JUCSRwWAK6fkNj3JM2WrDo6/IQvCvyMFVvHMUcI6MZ27YB87u CFAAJ0Sx1FZ4WJaOthvC1imwPUO1sJVCfo+gRjB6OWVBY5dvs+QTcMTq5h7BBydsJJ2I fSJFys7vTMM1bKFFbelx7MnIGuVz/Cf2afh6ox1ndop5gzTaw83WortJZnu+fFSzFXTC lginqtAGqCjmxgeJ987scyu04a7+3WiQsea149/vaWpOYVxC3w1Yu/HNfk9Eig6NL1lS ZQ18MrTyy/SwmygrITEfv9BshjvRWQtha8krHb9Q0f+TdNItNaXZYr/C4kIQmFBx8Kj2 HkZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=Lk3ZPq5EneNEAtrq7feCfQaikwg/J3tyNAc6f2OLCBE=; fh=bPqs04kx5Y5rKIw5xQ7XBNnh91aCKjFM2JzTbMaxQkw=; b=FmOZkfjAKJRi0ZdKXlVfpeBHmVn4f5VE8RKvXlRdrQXnwHSB0uBkz0n30AzTZHMLA0 M8w0RGxaLcjH5xNiWRGtUdbRLifwsVoF0+YQ9rstpRb2tDHRrsy1zXLZBTpGpqoS3Fr+ NyKsaPhEfw8xaOOouawe0avV+8OqmDoA+ECtIAWOTtBhK0wKAf6anVGCQBOuFzEbWPdD 4aozcAxJy5B7thVL6G2LiZZ58LM7kLAs+Y3MG+q5htJ3bSCgTd5NB7O/6x0qJFXp9DPn SiNaChyDtwbE9+Gq7v19OGvNFE4/P428Noco6JO7/tedrAN9ns2J05VPqSEyi01T2KMx 2JtQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b="c7Nxq8x/"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com X-Forwarded-Encrypted: i=1; AJvYcCWwIMOnQaibPj6cb0qTHeBkTQevIs6T51VqPsISY4E2pgbQRxrXzGatGK4CBIu+W8XbDzobWAhajctGmgRwvlVk1Jz6hPyF6KR3+fkE9EflmYfPREsKO6UXDRrCX83VIJIwBr+f8yFbMlJVgZpz+CYNCP2mML9QE96L901A114wCi+YGDYrc/YiXlZR5rnPsyzflomEdASF4ZMSPxZZd7sjhQuOaiOkKAqHRyUtKnBi1OVt9pc96CjJ4gmsmm72GcbLuFXACEPOdJLGfOcMLSB8NOTHuNwfC+hjOVqXqfaPyagNUYmYBN4BmojpiN/NavP410RupnzO9xsZkmhEof9pIv9CqaDa8Ck5hZp7+gWtoctV6fxtuZFT6ACnBXZZWM0G4vkMtANe7A3m1Hx7YCJy0NxwAV14+KQ2+l9kDIT1yeKeeouar3uv41KTQPelVB/Fzxt3YYW3fQ1t/6Gdo3dwOhzksVaGok9/RYCBp/ZDTsWZHMCv/Zm8Sgt7TNgcekYt12tVZE6cyimS7jzfDh5ger6GgUOsq7m6sGwtHgMETTuJRh0i+kDNmne2/Jy+CH+NGKoVvm/6ieC4apdrhRNK6un+oJHSGM4t9broTJQixrNpYPtx0QMVF+aT1OxN+o/J6H/kzxt+B+heUOG+bkIy27rdxGP0L4XFa7+jLp7WV/D9icWr9QcpDjtZlFTv9G9H/61pTPa1K2m3lIYoK8TQ82MfSeVkVlUVr3Ih9RRwE7nE+JWfJQyukhNnBWySezNVr9h46+PSvdCqybtAj3u4N7vt5vrQ6Q5miU8zSJJWxBfQYc97MDFYJaT88Yr59HFsG/tcvYRpJOY2h6R6LXr0bcIgHQ9k43xVysBBl6ajft6TGVzbsqRPgYNrohqZYXXQ2PJIZB3iRJs8BHOkH8rJN7DMJE4FOULU1MYx8AHANveZzZ4TSJTZ+lECTiSQWfVYz+ +U7B4iH4JRxPEJn1n5Bbj4rg0lJlV2uuWVZekGrdSZKjzhoXpMIY1Oc55K1YKEMi0aEAYjNK93QAK1Q6FaJNqkY94yjD2O4Z/qwrsRnL3Hm5UPjgrwc9uQOL/myxmr9Nsr2QTHkPc3j62URIVjOoZC4xaLvNjJldtol/x7KG3bYJ0E9OI6lITywgg94QkhWPEfk8HQ1Bi6SYGWatlitY5Ko3kE/EjQ2g5YG5MngvSwlLBOGnOp6hJicLqX0Rda02c9FbrQUMgVMgj0Pbbv6ilUU4pj5l4l8dMtMj9xwOd6DjkglxgE82LxpBBGvLcRDeyNrsSQbQvvzLx4vSGLh4Ibu7FNHmDux0dV0eE5Gu7SlStBPtXbKYJrNoFMLUi3ReSrQ6ZOW97M5qHM3j8gJqLRYGhZ1ttHyc6yY1wLnqRIC3Xh2ICKnLrDzxr2e3cfCP2ttKDPa6ympOYZrKZ5bKeJ6VIEemwhX/JIZTMaF5KEC9jIUc2cgyKDpHTlsBoLPxlBIAO7xb3lpZBrA5xgaiiOtKBIUvyt9mwGErsWNIug3DCvUSly0khlFZIA3hin2bmJuqY/ZMPzaxANkYgP4FT/7yQojE8chuN2Y6DDW9p2PIaMRUXC5AiBd+bi6Iyz Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id v24-20020aa7cd58000000b00560129c0e89si633626edw.413.2024.02.09.01.13.15; Fri, 09 Feb 2024 01:13:15 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b="c7Nxq8x/"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6813068BD2C; Fri, 9 Feb 2024 11:13:12 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3A7C768CBF8 for ; Fri, 9 Feb 2024 11:13:06 +0200 (EET) Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-6e0523fbc27so369478b3a.3 for ; Fri, 09 Feb 2024 01:13:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707469983; x=1708074783; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+CltWwCu0Nn9gxs3ePYOR9x4YWCQ+Xh8L/Ms7oKwk1E=; b=c7Nxq8x/hISfKBsgJC+MP9fKCBpmZIRcL5EmiuMV7DoE8r2BSMW3yMdIuV8gxqY5L1 E/FAlyZgZgsC3OBJivDm766kSgBMHRnkljoy23c/z9ytjF1pVB5C2VSEyYOEaKPUWQzg lAr4hgvses+rhm8BpQTx6QTSQSy5VkO29VhEEqmZWS9reHA6DAOVrdbFmFWi2tjcCKyG u4scEYQhb5RWhaGPb0IAXVFT6BLas3ng8uVAypYWpNWBY7QOGdoD0uVYfWCTA0x0MqaX a/I6P+EGfU8zt/s1Ce8i3hv/nLQvdnmVw98gQNMYHqEFvkJyim+nI1s8EnSRUkFcwrXj auSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707469983; x=1708074783; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+CltWwCu0Nn9gxs3ePYOR9x4YWCQ+Xh8L/Ms7oKwk1E=; b=LmQoBgy1doVW+wvo0CikvB8kueksmi/VAEsBzHV4eZqrBE1WdNX/XZXUcHI93u09ry GG2R4njhisyG74o6Hsw7cFyhtncWD8Qyiu0/ldTkZm4o8m+oiPdy+0IQOgIRobJhf6Zr 1Zy+ufTOi7t/eHgIwQqgQ4WK0i8AtkuxtuMzid1UMmsQe9tI6oTgyQxn4oqa/FS/uQQR xEhDMJ/R0FFdEzso6HnPaWcUi+DxsNPGemGM/S6e2SjWwFrxs6vwlgK5pxQtIhRxbQw3 YVSPwZTTDdrSlmX4y9euLZ9Cl6xz1fQW9HDB8Aq50NT8KZcXDnsZkmiPj8ptl74gZoqd dY4Q== X-Gm-Message-State: AOJu0YzvRTH+t/lrYe2MRe9GlYc3WskbrCkg+hlj0nX9Ab1PFOEyUXyI 5iqrmoibiJ6ULnDy7Omv/al1Vtus+84C/54fQqH6Fn/M6FrLHbsJQY0koo4hRC8= X-Received: by 2002:a62:e503:0:b0:6e0:5ebe:89f1 with SMTP id n3-20020a62e503000000b006e05ebe89f1mr1060898pff.13.1707469982674; Fri, 09 Feb 2024 01:13:02 -0800 (PST) Received: from localhost ([2601:647:4600:84e0:d085:ac8a:daf1:f5a1]) by smtp.gmail.com with UTF8SMTPSA id gx4-20020a056a001e0400b006e07f1829b0sm1157844pfb.219.2024.02.09.01.13.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Feb 2024 01:13:02 -0800 (PST) From: Connor Worley To: ffmpeg-devel@ffmpeg.org Date: Fri, 9 Feb 2024 01:11:43 -0800 Message-Id: <20240209091142.65668-1-connorbworley@gmail.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v2] lavc/dxvenc: fix failing FATE tests X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Connor Worley Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: X++JElzBNF/i Prevents access to uninitialized parts of ctx->tex_data, which were causing FATE tets to fail under valgrind with --malloc-fill set. Signed-off-by: Connor Worley --- libavcodec/dxvenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.40.1 diff --git a/libavcodec/dxvenc.c b/libavcodec/dxvenc.c index ebc48aace3..b92d99981c 100644 --- a/libavcodec/dxvenc.c +++ b/libavcodec/dxvenc.c @@ -234,7 +234,7 @@ static av_cold int dxv_init(AVCodecContext *avctx) ctx->enc.tex_ratio; ctx->enc.slice_count = av_clip(avctx->thread_count, 1, FFALIGN(avctx->height, 16) / TEXTURE_BLOCK_H); - ctx->tex_data = av_malloc(ctx->tex_size); + ctx->tex_data = av_mallocz(ctx->tex_size); if (!ctx->tex_data) { return AVERROR(ENOMEM); }