From patchwork Fri Feb 9 09:18:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Connor Worley X-Patchwork-Id: 46126 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:a586:b0:19e:8a94:b663 with SMTP id gd6csp808787pzc; Fri, 9 Feb 2024 01:18:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IFc6xVAVbRwOhG9XcSdGDLsKcm6d0p9BDg+fi38jlx1+0DGUDNt2rF4tLjHZ2pzT+2Pxc22 X-Received: by 2002:a05:6402:b10:b0:55f:8657:c7f6 with SMTP id bm16-20020a0564020b1000b0055f8657c7f6mr924688edb.14.1707470328829; Fri, 09 Feb 2024 01:18:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1707470328; cv=none; d=google.com; s=arc-20160816; b=T+YxPpJNSu972TJRUq8pFeKfHiMrC0PS0CYz/p8AMtvOMEt74jlhq2tjVUUhyyeFxY BIwTQysF3gmkC+JriU1E3mXgCeE5plEv97oSDFKupqohwMWQc1kqNP7b3KraA70V18k7 ffeznq0YWe33GZHbAuVeni0d2VKf6Zxk9kUnQDKNp1EP7NIrcDHeKVe8czGrY2iQVbhZ LoyAmwSMld0VNhrf6qOimDMKnGkIwhwCeh23m5wMwMaRl8JYzqv4X3H061xCqjFZlzcq D1SA0I9O2XBSRYehqpGK8HeRI3+5pfbuAca5bQChOuB1mZ7+qjioo0eWGDNzsKllroZf L4BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=btv1Jm31Mi388ZhlaAlHGSgSZ1lfJjHiJX8WboCjgDM=; fh=rVfeZvWUxhL5cdKBhh9GOx+a/wVKDibYVm0JVAiVlmc=; b=Q4ot2CSQGyk2VfQV3zVg2ikp1T+5SfNAPsJsjJVcyJSSkWcgetD34TTbc7YY8slaBa icIxcbkrZTbeAwDYiTEX2h8tgSm8gErjRCqwkito/tIUV0TO1KVYbDJIc449R8Sr8HXB JvWf/RFqTEY0mW/LkrtobZpKWWE9n80AOSWbD8DR53t5iPtbVFKnm7COGigNXr4lOvmy tqQQFzrV0wVcxb/ChTo60jXdwm2LFgTXUG9SrAgQ3ceMNIli0cPq6BXBkN5l5ppb26Sf kJyKKD2OeANYUzWMP8Nwja+y1dI6y4XdWCUNn1ti/nMZmW6YLaL9GU463TDwKKHfODGI WCrg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b="bXJyv/jR"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com X-Forwarded-Encrypted: i=1; AJvYcCVH66y1zLpSzjzq8OAhFFRvwySjs4OguTJ8+UOK086NjXKbs7rlUncKjgE2RlNY28EKcveknSojR6ki5BAQWtRh/NSpMnOXbHmqirZUAJZFGtDncWk3DhZergEo8x7b2WtyjcqazsRzGwrcPeKijcdYTm85mCwWiiKgFmN+OKLTJDlRqGMuMPMOvuh+aGvBini344zQwfVapVjjda53JOI1ZXT+vUOpQH6QhY4TuYeaIJ/63AeSDMc1J7VUtKP88IdfL6fyAx7qDitMb7hsvyBDEibFHV85uFoEkDqApQQ098bxBeQt3YyfRoR+lyy4KOrYZKWpHiCr0ktRkGiUO9kgyrqk/LgJX3076Y7JcktfQVkdhknHujtbTePsY6PiRgJiX+lRp28s4vEYgx7F1lvS5bN9WQ6Oi+Yg/TyGjcH80JGRBXBVLAJ5ofMm8WO4R1jKqa88UgIRYz4QyuNW7hci61op+uYwfKBlehwAUL+Fe8b41eur3DIkfG3Ce8sWWryiZgg06fQ0Jyb7SEq2lyvqEcNi8FJR2a+BZ9tlWH0mFjus32luZ154Lanin8lSUL8zTikaEs6DbNHXtyw2k5nALeLjiyfG+gLrngeTfnFbYO3DVogBoNkmPImzHvwEIdstdLPbKw3fe1cAdrFaxFOt3pZSy1ZHq9evpYQRQqcQ83Qjx0nSsiPrehynyg1l5+rikt5sU5KuCRkOp+8VrRzrVgowf5ju40vDYijVSb2HjFI1TRdUKr8QwamCterMACuv3vTNasix94NPo0doGoe1XCphXZ4u0qrWbO7QpcbYth1lTC6T8gx3cu6SxJSIJ8POozdoQNcGGcYk1d811ZubK+Wo9vVHSiChlXec+gSV2wMoRjeQUt05k4ckL1SsTwN/uhyx+dg2Xh5zT7MpqKWRXrlbI8h2ZzsE9O1r35rZuM0pSL+HasxtIrR0mzLxWq6WtT 6iRPkegt7wjHQGqebTIZm7btVQLP9TJ6WDWq8qzd8Yfb2MhytgEx4ywwmLcKz6Gd+rawDeq4wUWob9oq+b0Bq9h1OUaF6/uzFXKV8w4oKxYyf12ECljZtVz01QFL8L4cF57oQ7/VFnq6FtD58cwlf3FcO+VFcz/yxr8X42D4R0vdwzrsZG6BcRJfiHp8eY5oUm1ZCZ2rmHepS7mYXwNDz3GUIH5P+nLdd7DzJ7pKLDFtBuJ5OPIl0duPLUqd6BPlJr2kt7e3IZiJ8TQZga0aicKdHeZxiPYc7s/AmFwwH1muwa3GuYyurqRYdaH80A32hsdfzVdXoaYu42QfkR2v0gVZ4QZWJJacyBCoz76/NBnojgKuxjcbIVsYpHTzBKjk8QdMM7y8pbfmRqpCCy6yNwdah1c5y9TG4q6ILfv9BzVdvY3u+0P/Oo8ChljZnbIWr+XEMpnZ94NckOFV7E64YrfgFSUTHtPQ2PQDhdGYGnIhnTWRKsAzL0DrXqzS8mgvTqCRJRVsSwLBT0VgJMygegusgcw/fHLmPyLrQlFfT0zxpkTSa3zvcssbeMMDPPGjQZJpG2ZrmjL+0Ftfe4SjoF/EK2KYmcH269FcZ7g1nBeMv5bqgld8B2y37Nhyvx/yYiOz450ZHFXBOvEw== Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id z21-20020aa7cf95000000b00560ebb44462si691621edx.479.2024.02.09.01.18.48; Fri, 09 Feb 2024 01:18:48 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b="bXJyv/jR"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D67B368CEBF; Fri, 9 Feb 2024 11:18:45 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 427E4689245 for ; Fri, 9 Feb 2024 11:18:39 +0200 (EET) Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-6e096229192so69885b3a.1 for ; Fri, 09 Feb 2024 01:18:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707470317; x=1708075117; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+CltWwCu0Nn9gxs3ePYOR9x4YWCQ+Xh8L/Ms7oKwk1E=; b=bXJyv/jRsKlys+9AU7HYVdGhsbLciFOdg98Pt//RPXdBqpg8F4RlIt+J/f84OH4c8h tpv3UFTJhlUyZyvcSiQZ6JQtRqp2h38byXGSWGSjYs0bMxuC1TG3jKoRbAop10oiRwJt 1M+f3WqniFOBCem5Hlz9djD1eUj6EIn9dgqLJDHBkTrw49nBi2VeCYdAAKTChFgs9baY BwyUGtdq6nLA2HVWsdl3rnPNSerWmrtOUm3ECXLQ66hNo/5NZpEFqEcHLw70H8vSZe3c guadB1zDmQBz/3qAvTDhIkvAoi5yQOpiM4oxQahO1KpUS9IsS5Abl8KdS+4CxdmGQdQn qWKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707470317; x=1708075117; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+CltWwCu0Nn9gxs3ePYOR9x4YWCQ+Xh8L/Ms7oKwk1E=; b=Se828Uq0Y71G9VD568QEGUEJSzoPiD//fEZjUZqogegyWwgH8nx5eOKxc2zJm1gPVX mZRiSyMGzp25tWZj3/L6l0Yd9VTfuAvGho/YcM916Kh0F0IjXILGdhlYqx9E4PW4tXUO xOL5V4hS9X6rbLFfWZrNUyNN1T3xvNfGps4p1kYoCmsHW5Edje2IEaqqcVeLwTogDEYV YnJwPbgRmt9btTZzXwqwKZQb/S9112Oqt7430bjSTULdBEI/P8PBMXkHMkXb5Uo8N4Q7 u8od/Al3yGx4V8e9Mb6h647LiBDtesjHRAq0pnUC/VTbmqEg+EfsBAdcYLi5oYBpoKsZ QbPQ== X-Gm-Message-State: AOJu0YyrUi7jtV6kSpc5i+N2LljAjiLFTYq5vpLpHI6+825Eyb9pfbXI 5qGkpTjcdqcA/h/1635zGsrT1LOf1NXhl/iczUl/fhKdbIF1Ih2Ym724+N1ojdc= X-Received: by 2002:a05:6a00:2284:b0:6e0:465e:cdd5 with SMTP id f4-20020a056a00228400b006e0465ecdd5mr1403810pfe.23.1707470317092; Fri, 09 Feb 2024 01:18:37 -0800 (PST) Received: from localhost ([2601:647:4600:84e0:d085:ac8a:daf1:f5a1]) by smtp.gmail.com with UTF8SMTPSA id f5-20020aa79d85000000b006dd6c439996sm1174286pfq.161.2024.02.09.01.18.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Feb 2024 01:18:36 -0800 (PST) From: Connor Worley To: ffmpeg-devel@ffmpeg.org Date: Fri, 9 Feb 2024 01:18:32 -0800 Message-Id: <20240209091832.67363-1-connorbworley@gmail.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] lavc/dxvenc: fix uninitialized texture data access X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Connor Worley Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: hiJ+fvzbOv1S Prevents access to uninitialized parts of ctx->tex_data, which were causing FATE tets to fail under valgrind with --malloc-fill set. Signed-off-by: Connor Worley --- libavcodec/dxvenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/dxvenc.c b/libavcodec/dxvenc.c index ebc48aace3..b92d99981c 100644 --- a/libavcodec/dxvenc.c +++ b/libavcodec/dxvenc.c @@ -234,7 +234,7 @@ static av_cold int dxv_init(AVCodecContext *avctx) ctx->enc.tex_ratio; ctx->enc.slice_count = av_clip(avctx->thread_count, 1, FFALIGN(avctx->height, 16) / TEXTURE_BLOCK_H); - ctx->tex_data = av_malloc(ctx->tex_size); + ctx->tex_data = av_mallocz(ctx->tex_size); if (!ctx->tex_data) { return AVERROR(ENOMEM); }