From patchwork Tue Feb 13 07:34:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "J. Dekker" X-Patchwork-Id: 46232 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:9002:b0:19e:cdac:8cce with SMTP id d2csp1140931pzc; Mon, 12 Feb 2024 23:34:45 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUzsFT43Op8L8eP2BsuHhasjdQ6FppualxS+uNxzAP2TxnK4QmTde48aViOB02e6DXhydq4v0meqY+B42UEkWIttiEJNb157ELiVA== X-Google-Smtp-Source: AGHT+IHa0eSr17iIWsooMgmQoJs6HnMFsFtqdmwsI7OHZzf5Ow71205Qa6e3x8Uxc3Qv8lEahCEl X-Received: by 2002:a05:6402:514f:b0:562:5fc:71f1 with SMTP id n15-20020a056402514f00b0056205fc71f1mr97854edd.24.1707809685003; Mon, 12 Feb 2024 23:34:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1707809684; cv=none; d=google.com; s=arc-20160816; b=XN7tEOGqyRE6WASCNZftwqd5oa90bQz7r/EDIoVedoWeqESIsnOvozO1ylW461s1/l IBgV3IRMmf7UngE6Zv4XxpLQn76WPOP85Rkyxzy2iDGV5KMdjuZBKdZmswanHL2RW7uG xVMm0RJ+NYQsBpzFrcdfGBZ+a/DQUGC8CT8ATUR0snXUZSIlpu4vHV505zgAdse4Vzos Uw5HifYLjy7/KT1wOwvTEhxVhFOuGFatqg+Qc0nMxVUedDtIs6/K3J70JonCiaz9kp2d 3cg9PXtrekx50hARnEZL5y0Z3zeBe5IFZ7HG4PSoCKyNcP7oVzN7lGQ+79z2aqJwW0jj Ew9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from:feedback-id :dkim-signature:dkim-signature:delivered-to; bh=yAm5ij2SqLmx7G9MwW9RkKg1MMkMOovsNxysnB2ieNM=; fh=nrI4NnYnVyAjDGGydJQAy1VD2tX6xWmjhnUaklrZ7/o=; b=vexG+wKdCaQ3gXlIZo1hm1HVsfDZ0W6N7UHeFFjyEVinVFBobR8YLxSyNE9kzP9m+w mCpb9Fg7RuBm1jdwV2yr/BYKncs6LGLyxRVSr1+yH3c4LND+AIrjHNNVxx3yldRjy6ru go6ZQuirgiN4Mh4ZnPqPWauEAzz1GHyCEnjBmecekCc1uJAh/nSTUhTvxJIZBMdDT+st hWWKslcN6q7VEoXzSiQ48qOyiVFP01jWvOzpxiPt87jKL2xYNv6YKcxZ34BanvTMBVNG gWmilUzmQSyvY5HhL/dlzbBp/FbY9pI4+FQtbooKpjqnilbEs5dFqjkZ9KM2MLFVITJc M86Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@itanimul.li header.s=fm1 header.b=DDzfvJfq; dkim=neutral (body hash did not verify) header.i=@messagingengine.com header.s=fm3 header.b=amfYm1H5; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org X-Forwarded-Encrypted: i=1; AJvYcCWtQjaRLS2hZbOwLMfkiUqvXYl6OG4v/rXqY/qOz6/NJWzFFP++gM5/1071W9zWypHTTR4Wl06NbVjGfpp+uF8FDCwam7LW+pzC7Ufre9gVbiYV91qoJKyR74VX4oWkxVQwfHP1UReNBFAQV5NGTfqnpStaIWM4anUyhyHUs4/wZGcj6WFLMzevKSFUp+q5uRwPpGPflWBupfkPk+j77YSF1qMUuInoXI9fDWgzDm6gXxZ4+xGI9kL9BS28+udcrRMofHtFFfVfh6fKKijIL8lHITYdULYQo2UAzhQkbk6Uh3nFaCPyg6bhkxquL1fGt71TKEFwbti4fIuhp1+yVOwqkkGmQw3sGwiEROpWilOiFhISgBSdWVe664ttdzMasO4GBhzmCcOa3920UqXW6zMFfjYnYBSrjb5MGv+vlpWPBo+l+VrFySODlmxKXsL2GIRdb2w+gpxtIO1h6l3IpKw3xuWtp+gwsmZfHSH9YF4yUgeJrwzq6jP4uBsc/3iM+QwNiSgOqwa2Qd+c+EtFG9QDeiA73g75PfsLmvJO2d3YFKprNIS6wqdWaJjidKO53BhV0L5CMGO7/XC20e1NDvZPoif7a9zq91gdf/WlyF3TToSfseFZ8+SqtEcf50x6zPM61aNMEIPTpth6IPyMMQYCRz3nDUkRETVA6iKe75CTFZfepwFHmGoEmo//dX0rHwzjGrpZdzxA4liVArBZwacb4RLDohzvctniRgiSPYLSYhMjhLHvA2D6ZyLlAC86MEx6K6vw0YucD4SrMh3vEyCe6qkJD9UH1taubj1Z5TS6POeSUavoteAaOh5r0OOkiSDuqfj3/tV4T/1GeKXutMybtpsQIxqePsrDwzj+E4q4DoG9vjhMSzgJ03UCAETF78u4+XJ/ZWhOYOYWNMSvo7r9kosEsMpDpCsQg2K/17YIK9RO3bNNUgkMtRRwkbcrab52C1 lUZXozcuVJM9+EhMUO+C8TXz7515GcyamAV/BjiknuH5JTORyMzj1kiITmhx6faVWt/etvQc6Vn1ITC+vLmaafMMlonDfl4fBSycifVvg733oBQ9OkH781LjvKwxA01vLWZEMpXstYJSZMuZy2fNRBNy664+tGaM647vtIbLiI+sR8xUelzXrz6wJG8Sz40nmrFMEh41CW+4Q7LIEnAypR7qGsrcy6oxOCXrfVTXNbfPtNiH2qHculr0o0t0xiudR9eL0oWMjUbq5YkjXAQMtMA7sDAFLTdfVQfdJdtFm/Qj1aklyabUnUtkZr5WL30QHPxP8Qa8c95Q4acfjMBALXkUq8Pl6E5UOQRJhEHoXDsEYgpNJOEWhMULY0f+ct9BFXkNPkm67rYHADBgMBQdoRL6taPlwuYhD6j0iJUQHQnrMZnhhP/KmGPDySGf9sx0Zret2fOFGNH0V80zF7QpnK39fG8aunVrjagjwnnvzl1iQ/cPstfIlWW7rayy8rFKUngdspS2msGhNODYQnk9d1qkn77Rp9NDCJKB239duNqKzdXNi3FQz/Hea2YGn7ZvGx/b5Sko0SDkd08gat/hjE3NO9h4NJS7piAA== Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id t7-20020a056402524700b00561ed2c5ee8si543490edd.58.2024.02.12.23.34.44; Mon, 12 Feb 2024 23:34:44 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@itanimul.li header.s=fm1 header.b=DDzfvJfq; dkim=neutral (body hash did not verify) header.i=@messagingengine.com header.s=fm3 header.b=amfYm1H5; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C393368CD68; Tue, 13 Feb 2024 09:34:40 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from wfhigh5-smtp.messagingengine.com (wfhigh5-smtp.messagingengine.com [64.147.123.156]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8D4A968D0B4 for ; Tue, 13 Feb 2024 09:34:33 +0200 (EET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfhigh.west.internal (Postfix) with ESMTP id 107681800082 for ; Tue, 13 Feb 2024 02:34:30 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 13 Feb 2024 02:34:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=itanimul.li; h= cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to; s=fm1; t=1707809670; x=1707896070; bh=9RhZIEt/UaGW6EXVVmh/Z CFwtP+s21DoK1wkh9bOPWQ=; b=DDzfvJfqM2RQChInz/omKp/SZrq3YEq+/8Q4e SBY3Yv+SJV3g8+THo9YJZiiNYzyrOx2hogm/002F68OSdps+c4wF+gXLdyMSmQvh dSwZur1xMdGdaSxryD3b+ps+1iS2wOqsnf4Goj7FPtIYtGFZ8G4WTanqOSo6isfy GO+93Drf9x0mdtarDMOzr/l4VXBB+QJAI8FoZDps4QKd6yMM4PCLR1UOq9VnJFX2 T+cJYBny2yuVOQmMt8+BLYHcxaYunSMMK0vJLUI3MM6r30bB1nUCKlbdWtB5LDUM DRpRHIaWyzlST7AyxNsdgz9rtgpbLQVUUTcef6Ozdwzak2wYw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:feedback-id:feedback-id:from:from:in-reply-to :message-id:mime-version:reply-to:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1707809670; x=1707896070; bh=9RhZIEt/UaGW6EXVVmh/ZCFwtP+s 21DoK1wkh9bOPWQ=; b=amfYm1H5HVrAvRP8iuMmuu8eXaAh9DwoUEd+pvLti7BR u4MrR6QD2AVkqiPNDBrLnfz/EcbBSzbx8bt1stss1uG6XQH11Hnlb519HMxJGszF a4RXmlBTiJmUA9QcHSj1OiW3jX3QxwTH5fWx/kGHF6OlNKfEDLVg+n/+dzkQ1fsh fJqOJ/nJxDYK6G6gLGGuM0bGtO1uWz1tkSPEm2EIKDM4LBRRwUG9l3UR9neueltB 7+nvLk6SeEO5KBzGthji3nDbarld+johsGy2Pnb0VOP+VRNRQLgNBCQ5pMFdOT2O rF5AfBUxiRZSOGQStCDEQz8mxZ/1yXIRboz4Di003Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudeggdduuddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgggfestdekredtre dttdenucfhrhhomhepfdflrdcuffgvkhhkvghrfdcuoehjuggvkhesihhtrghnihhmuhhl rdhliheqnecuggftrfgrthhtvghrnhepueetgfdtuedvjeejjedvteelffeuhedtfeetud fglefhjeeukeetvddvtdevieeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm pehmrghilhhfrhhomhepjhguvghksehithgrnhhimhhulhdrlhhi X-ME-Proxy: Feedback-ID: i84994747:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Tue, 13 Feb 2024 02:34:29 -0500 (EST) From: "J. Dekker" To: ffmpeg-devel@ffmpeg.org Date: Tue, 13 Feb 2024 08:34:25 +0100 Message-ID: <20240213073426.47433-1-jdek@itanimul.li> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 1/2] avdevice: deprecate opengl outdev X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: qQm5bS+KkByd Signed-off-by: J. Dekker --- These devices are fundamentally broken and usecases should be switched away from output devices in general. Discussion in the thread tended towards deprecation rather than immediate removal to give time for users to figure out the best alternatives for their usecase. libavdevice/opengl_enc.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/libavdevice/opengl_enc.c b/libavdevice/opengl_enc.c index b2ac6eb16a..0c81ccc1c4 100644 --- a/libavdevice/opengl_enc.c +++ b/libavdevice/opengl_enc.c @@ -224,6 +224,8 @@ typedef struct OpenGLContext { int picture_height; ///< Rendered height int window_width; int window_height; + + int warned; } OpenGLContext; static const struct OpenGLFormatDesc { @@ -1060,6 +1062,14 @@ static av_cold int opengl_write_header(AVFormatContext *h) AVStream *st; int ret; + if (!opengl->warned) { + av_log(opengl, AV_LOG_WARNING, + "The opengl output device is deprecated. For monitoring purposes in ffmpeg you can output to a file or use pipes and a video player.\n" + "Example: ffmpeg -i input.mkv -f nut - | ffplay \n" + ); + opengl->warned = 1; + } + if (h->nb_streams != 1 || par->codec_type != AVMEDIA_TYPE_VIDEO || (par->codec_id != AV_CODEC_ID_WRAPPED_AVFRAME && par->codec_id != AV_CODEC_ID_RAWVIDEO)) {