From patchwork Wed Feb 21 11:10:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "J. Dekker" X-Patchwork-Id: 46413 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:1b29:b0:19e:cdac:8cce with SMTP id ch41csp227878pzb; Wed, 21 Feb 2024 03:10:32 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCWEdS4AxOEDUL2MIJ4x+SrUxy3FxsbVozPSSFO7q2QgjZM+W+9Ncd/LQIZMUuesoVUE7q79lh3HwVvI3gJckur94CcmkQBYbnABbw== X-Google-Smtp-Source: AGHT+IEhn8v4NmTpKrC4YVLtVkBPSrCOT+HLaaoVJgNy3RgMe+5JnfNV20ODt9zWqn2OwP59kDOI X-Received: by 2002:a17:907:c284:b0:a38:4eae:b12d with SMTP id tk4-20020a170907c28400b00a384eaeb12dmr11976838ejc.7.1708513831809; Wed, 21 Feb 2024 03:10:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1708513831; cv=none; d=google.com; s=arc-20160816; b=Gqr9C3tqjdqTXEjghd9TB+sSsrfBosBUdz9RHFDpEoL8p3PRJbuzSTbHkdrlB5eT2o En7RP+5jyziW9vxeCSUJw3f2RuEFyjauKb6nn+9w6XD+vMyEtTM3pGjlNdAohlR/frcS tyiDgo12NP5prBJPy/A127dj9o2MC+IJVhYJhyZExSedFZZy6yjNFMZiftHkJiz3qH8q OwLDiwyi2HAeZD8hjMsAdZxYMT/oQkOfVxOPiIhWAmpgiI/lowHZeNZsi+ZeuAZqb86a 1A2+Lz7Bq1sio66SSJgRCHfJnNgUbel/6TvT9hseAyOhgSG9JfjFQP7mjs2iOnuzY383 e6DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:feedback-id:dkim-signature:dkim-signature:delivered-to; bh=ael9yfwsze4FG30DpPY08p/n/mW23R+1lbzm6IaB5yI=; fh=YOA8vD9MJZuwZ71F/05pj6KdCjf6jQRmzLS+CATXUQk=; b=RPIuWkXgRFYKzNrGmCFUNIe+AiIjGIZ9un+h9+/u5oANTXk7+zYcEdeieVY33ERvau pNc//aioAyFxasONVdJL5TxpV14Sm/vUlDxDU9gD7k0Gj2/Ge4PoZcNXSe7zi1U0Oh+2 7jPwNLoad+uH558pJE6xcYVRc/IsWK+hemO5eGBkoNUjgD8pzbTpv3u2D4l6cowvbAMp K7NKtMo0ka65DZC37rbHFRbyYxePQB+Ma/r/bPevJ+b6wneeUMHB4B0x4yCvdERtF9QM 0AdWVFmGRS9y4yte4A5a/20DEBqoMtBPKg623iPof9x0ZLfhvObj0KcrlU0EvQiQo49n CYIw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@itanimul.li header.s=fm2 header.b="M/n7RovG"; dkim=neutral (body hash did not verify) header.i=@messagingengine.com header.s=fm1 header.b=d+G7Hahz; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id hr13-20020a1709073f8d00b00a3e5f4e8053si3538284ejc.674.2024.02.21.03.10.31; Wed, 21 Feb 2024 03:10:31 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@itanimul.li header.s=fm2 header.b="M/n7RovG"; dkim=neutral (body hash did not verify) header.i=@messagingengine.com header.s=fm1 header.b=d+G7Hahz; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C86A068D1CD; Wed, 21 Feb 2024 13:10:17 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from fhigh3-smtp.messagingengine.com (fhigh3-smtp.messagingengine.com [103.168.172.154]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 60F7268D192 for ; Wed, 21 Feb 2024 13:10:10 +0200 (EET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 42BB711400B2 for ; Wed, 21 Feb 2024 06:10:09 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 21 Feb 2024 06:10:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=itanimul.li; h= cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1708513809; x= 1708600209; bh=Sq/5Lxlm5cCdgbEdR5Cbh+InzAn/+hoDsAFnueggBFs=; b=M /n7RovGKX5ZobIdz3BrU3VFLvOCM+vDCwrpgY4osrh/3Xs7BfI7IUBEXgRCvEiKu R6ihfRoVQBh/31kOGbk96OOHKyp09jJC1JmBKjeytCKAkldekzbO4v+npUtUprnX hfpkRfFuHk93J2+PyGIvB5MWI/Gr4UeMHUyG+QE9zXXUqhrCERtQIkGgidb5K1Pi 9F7f3EfNJe8PsJAcrllCTHb0WJ7GLo/gNx744O3SYsc3Lb2XnGK7Or0m53XFxAOJ t/SJyyYphDP4TqERwsyuu9l4uvg6qj1I29are/+lAlT44+P1gRGbgbqlUOabrEz7 ySswUHjh7wAQQIRyFsQiA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:feedback-id:feedback-id:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1708513809; x=1708600209; bh=Sq/5Lxlm5cCdg bEdR5Cbh+InzAn/+hoDsAFnueggBFs=; b=d+G7HahzIRsBSwS83ZQVPszGgFzQT YFD47/4B0Vuv9p27tD9Bl0hXAfTvIVXXZ+JfDDtvB9wh0lw/8gdMijRnLid/dGPx 7v2lTCVI1AIhcYttWJ5stmyCD3p6bwA1qLXu0UO1N/h0L9gx5N1bRfvxfCHl3gDJ ufgSYwtFHTECNbrGyY45I9G+d0UrrY0VhGxHXt14BQoY8T52xnlzfMIr+e04LCE1 z0/SM90TxFjd1AI/POMGJiznsuIWr6KETEQf6RY/MGVBrsB9pqeO5u9CBpRFy7U3 DuvVNJPq9awlfFaJFBjmDPh7gaerCyyUbWQc3wxAe+r1V8vW+Fxy9Z7uQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfedvgddvhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffojghfggfgsedtkeertd ertddtnecuhfhrohhmpedflfdrucffvghkkhgvrhdfuceojhguvghksehithgrnhhimhhu lhdrlhhiqeenucggtffrrghtthgvrhhnpeegvdfhffduudegheevieekieeffefgveffke dtheekieefhfevueetueefhfetteenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgr mhepmhgrihhlfhhrohhmpehjuggvkhesihhtrghnihhmuhhlrdhlih X-ME-Proxy: Feedback-ID: i84994747:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Wed, 21 Feb 2024 06:10:08 -0500 (EST) From: "J. Dekker" To: ffmpeg-devel@ffmpeg.org Date: Wed, 21 Feb 2024 12:10:02 +0100 Message-ID: <20240221111003.185240-2-jdek@itanimul.li> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240221111003.185240-1-jdek@itanimul.li> References: <20240221111003.185240-1-jdek@itanimul.li> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 2/3] avcodec/x86: disable hevc 12b luma deblock X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 8KDNr08UO3df Over/underflow in some cases. Signed-off-by: J. Dekker --- libavcodec/x86/hevcdsp_init.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/libavcodec/x86/hevcdsp_init.c b/libavcodec/x86/hevcdsp_init.c index 31e81eb11f..11cb1b3bfd 100644 --- a/libavcodec/x86/hevcdsp_init.c +++ b/libavcodec/x86/hevcdsp_init.c @@ -1205,10 +1205,11 @@ void ff_hevc_dsp_init_x86(HEVCDSPContext *c, const int bit_depth) if (EXTERNAL_SSE2(cpu_flags)) { c->hevc_v_loop_filter_chroma = ff_hevc_v_loop_filter_chroma_12_sse2; c->hevc_h_loop_filter_chroma = ff_hevc_h_loop_filter_chroma_12_sse2; - if (ARCH_X86_64) { - c->hevc_v_loop_filter_luma = ff_hevc_v_loop_filter_luma_12_sse2; - c->hevc_h_loop_filter_luma = ff_hevc_h_loop_filter_luma_12_sse2; - } + // FIXME: 12-bit luma deblock over/underflows in some cases + // if (ARCH_X86_64) { + // c->hevc_v_loop_filter_luma = ff_hevc_v_loop_filter_luma_12_sse2; + // c->hevc_h_loop_filter_luma = ff_hevc_h_loop_filter_luma_12_sse2; + // } SAO_BAND_INIT(12, sse2); SAO_EDGE_INIT(12, sse2);