From patchwork Tue Feb 27 03:48:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Wu, Tong1" X-Patchwork-Id: 46561 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:c51b:b0:19e:cdac:8cce with SMTP id gm27csp1767662pzb; Mon, 26 Feb 2024 19:49:52 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCU1NMYthGWYg7ooed8IEM8YoC6RJnCn2422GGbq8OGMtSANAlEHcGRc5eSwUrVfeF2VXqvZ6sBnIWFT9TgXgWjKpf7Tzy60xDAi0w== X-Google-Smtp-Source: AGHT+IGirnt2obgEN3aAgnexxQDu5Fgnoyw8SM3oXODqZ4/6l1XdNEITWhXitamoSrfwMqkmwbga X-Received: by 2002:a05:6402:1b07:b0:565:7f43:a0e5 with SMTP id by7-20020a0564021b0700b005657f43a0e5mr5436603edb.20.1709005792270; Mon, 26 Feb 2024 19:49:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1709005792; cv=none; d=google.com; s=arc-20160816; b=ZBe7cyY92+WPkT7ptOnIoUnl72xahCKDdF4NwmCE/24PcKMpSnOnty8Pp3TMEAuaFZ NOhXc2ZErFNFNQ++u8mR3MLm15XKyQAakW89ALMJ1qY0BICFdZKiQ3p5DVYwAbhpP7iY 7Omin4UWOBGp2sEXay48+g3/+OQFHpMU5u9rLjsDWUS4PDJOQ+w8sWWuu+RI+/ZSpVDL rtEzcekSigsqxH8rsMY717xOvO35L6+tTNS3PYxoTuyNKoc101j/K53R+9xDzmKkS9GK MwnE6d/ac1JLm3hi65JSq4LQDA1SpMP8r96+81rNpDPqgONUhlqURxw8x1WtroEciku8 yn0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=PHCNoqngv6otIZ33hprjn8kSYzIggu29nT3DA/heSIY=; fh=CX/m9qTuMDwrotqtm4RkAOJT6yXlKL2vcfWDitFPXZs=; b=E0pC8zkUujE3C+gEBAorCxLqntZS8F17eNP1G5kydpgRU9vdzNXez2/PT3qs2hxb2R RVvZWFcEoXZU334K4dkWKLcCMkfpDwliP+DOr+rplLLyv4UWw+UwVyKWcVYNuZ0B6IYy xwMoqo9GwZwRAxdI2f0RpTwp9nNx2CWxmS2nzqiZfkYyajsewxO4V4S1CfePD52iGI0W 5EjFWLxbPzLNqL2Vfw5rF1EyzpwsdFUiALTSH+02rBDH+4gld3/Yo1ga5qrQoIOfQPlO MVNKNY/3OKTuAiHHA6zI/cEWEADjramdYd93ZiMWMtJnhspE9XwLjZSaPH2pREnLb2lC rD0g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b=FE0bfPZh; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id b21-20020aa7c915000000b0056400f8616csi329915edt.566.2024.02.26.19.49.51; Mon, 26 Feb 2024 19:49:52 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b=FE0bfPZh; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 28B2C68CA88; Tue, 27 Feb 2024 05:49:48 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7A92368C8C2 for ; Tue, 27 Feb 2024 05:49:40 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709005786; x=1740541786; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=mkw4fZpHl2JOBNbAmpzj9SyvYpvi6OQaW8paIOdFyWQ=; b=FE0bfPZhes4/QRhI2wjVlr0HrbXuI7fv3YPE+zbjck2cFQ76t+HC9kRk glGa/3VSWm2sD8EpuSReBaXY/BOHxsNlALUiaPo7P5Hrn/p4K4J32Jmq2 Q6kKol19esTy/aSR44BrSWlshhbBt49JprK8yQepaNgxCN3OtiIbLnPLJ 0awJzxRRcgfTOQXY7wKQw1lKFDd2SKIvwz/kth3UXmve91EnsXeyQFaSx UjiVm0qDJ2LJ2U/xA75Zu7TFlCQMzCmklzqFFw97Qo71LJHqgK6GBRONA PKwIUmzipLyShXs6hytgiA8CTiV9Lj3ZwYU9EFLPMiZpxOV1nk3DOyyUp Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10996"; a="14478512" X-IronPort-AV: E=Sophos;i="6.06,187,1705392000"; d="scan'208";a="14478512" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2024 19:49:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,187,1705392000"; d="scan'208";a="6862351" Received: from desktop-qn7n0nf.sh.intel.com (HELO localhost.localdomain) ([10.239.160.66]) by fmviesa010.fm.intel.com with ESMTP; 26 Feb 2024 19:49:36 -0800 From: tong1.wu-at-intel.com@ffmpeg.org To: ffmpeg-devel@ffmpeg.org Date: Tue, 27 Feb 2024 11:48:34 +0800 Message-ID: <20240227034835.897-1-tong1.wu@intel.com> X-Mailer: git-send-email 2.41.0.windows.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 1/2] avcodec/vaapi_encode_h264: use is_reference to fill reference_pic_flag X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Tong Wu Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: Db0MbzNjuZWU From: Tong Wu This codec supports FLAG_B_PICTURE_REFERENCES. We need to correctly fill the reference_pic_flag with is_reference variable instead of 0 for B frames. Signed-off-by: Tong Wu --- libavcodec/vaapi_encode_h264.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vaapi_encode_h264.c b/libavcodec/vaapi_encode_h264.c index 37df9103ae..4a738215c1 100644 --- a/libavcodec/vaapi_encode_h264.c +++ b/libavcodec/vaapi_encode_h264.c @@ -759,7 +759,7 @@ static int vaapi_encode_h264_init_picture_params(AVCodecContext *avctx, vpic->frame_num = hpic->frame_num; vpic->pic_fields.bits.idr_pic_flag = (pic->type == PICTURE_TYPE_IDR); - vpic->pic_fields.bits.reference_pic_flag = (pic->type != PICTURE_TYPE_B); + vpic->pic_fields.bits.reference_pic_flag = pic->is_reference; return 0; }