From patchwork Thu Feb 29 12:47:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "J. Dekker" X-Patchwork-Id: 46652 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:a919:b0:19e:cdac:8cce with SMTP id cd25csp559869pzb; Thu, 29 Feb 2024 04:47:22 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCWC+NPldJ+CsgVEY6vqzv6LuN6em6V/DqYjOIadhtMRvnJ1ZeprNS2q36KJ+VhilEY7cHf0l2whDOB1Ih+yeLwfz3SExr7esAxCfQ== X-Google-Smtp-Source: AGHT+IFPvpZcGxrfQyNPHk61veYzX+l9l4cBLPUsuDaXKmyQ/ECAbraLn1kvM7zEMNiwrrb8zQ5i X-Received: by 2002:aa7:d9d2:0:b0:566:aa2:ee58 with SMTP id v18-20020aa7d9d2000000b005660aa2ee58mr1130465eds.40.1709210842531; Thu, 29 Feb 2024 04:47:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1709210842; cv=none; d=google.com; s=arc-20160816; b=iLrHjClqaG7ClBlEIHVYsm1hEQ0a6UW+XXd0CbZNtU8GH+c6h6w/OV8M6g6h52IYtX 1Yr7HSGbODwllFUGBGifWu5kgHIWm3fM6KGK4GSH/avTDg1EIlXoNiaLySrzCkGV/FqW tpvMP+LFKkRJ/1TlCm6EQnyHXa6inqqQPwFB5007QNXdm2PPlom+CsKtkP6jZ/Zapcsh /92M8hboFgF56IVmRlFeDpU6tfdaAIENGIkXIRjBhix3TP2yikgSlFoZd69aJXuH7lQC QahqRdmGU4KwIFcY/fWsb9qaP99zVbIYPrs0k9NxNjUwqsUB6RFhwFBtBhKbRARmCogr kNXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from:feedback-id :dkim-signature:dkim-signature:delivered-to; bh=KQOkP9eMHROU9mWAII38xZS+l5X92yvNIPM+gt73MB4=; fh=YOA8vD9MJZuwZ71F/05pj6KdCjf6jQRmzLS+CATXUQk=; b=thXKlGSFzTS0TVTsDBkGERp8C4rTm4rDCrB8hidzHm/mYw3Hw0sHgKZjJo1jk33neP CJ5lqijv2C+AhJ2H81CZK6AUjPdEjmkHnnUyYGJgPHrneUi56nl42PoSB0TmLA3n+lUx n2KW3CouIx66ldZ/rtzpoFBhSGIPVdR8rJTjNuv4AUrIcbjEAloIaNiCfKzKoDClhv8B xM80fN0ojIXFuFzv1wV6yA1Wdqk8dF458nsp8zubieLgpxfHxBxLAYtODIHCEj1tjlQU iPoOhGZihYUxBqoiDJu0hMnoLgQN0qX7FwaQOO8lEAnp74U8UOvZg5xAv2I3HF4rgmeq mtCg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@itanimul.li header.s=fm2 header.b=HVMcNEYS; dkim=neutral (body hash did not verify) header.i=@messagingengine.com header.s=fm1 header.b=Xxf12xPT; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id eg10-20020a056402288a00b005668f67640asi530542edb.269.2024.02.29.04.47.22; Thu, 29 Feb 2024 04:47:22 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@itanimul.li header.s=fm2 header.b=HVMcNEYS; dkim=neutral (body hash did not verify) header.i=@messagingengine.com header.s=fm1 header.b=Xxf12xPT; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2DCDB68D14E; Thu, 29 Feb 2024 14:47:19 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from wfhigh7-smtp.messagingengine.com (wfhigh7-smtp.messagingengine.com [64.147.123.158]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 511F268CF92 for ; Thu, 29 Feb 2024 14:47:13 +0200 (EET) Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailfhigh.west.internal (Postfix) with ESMTP id 4AF2A18000CB for ; Thu, 29 Feb 2024 07:47:10 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Thu, 29 Feb 2024 07:47:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=itanimul.li; h= cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to; s=fm2; t=1709210829; x=1709297229; bh=qXOOb8HZn/iPSJmdzFuPp GrqJgO4hmo4SJraF+NQPCQ=; b=HVMcNEYSeQ+3HS/C90Ns27no2bdSqi593BxlP 8TsLHPGzeKqrKa1ofjyzT/RPJGu+BLVHesqE1bXMZARnNCFTbA/SS0WRmbLjd2nc mDe4os3gEqiETKn1Ec36rgW6dqVnLK4Be3P/6oYv37Vl33RJ4JNSjLknSZ07SpFR nU8tP/vLK75/WU559cOcZlf0J7L1eeWCoDGBj6ZOpViEYdyXlmYfnku4w/Iz6Yv9 bD16HjqQu5SFdvwxT8jPH5NPp6OHyfVCgV3CDUSL7E1NLTKtf/wvuqxdc+jWQV88 97V7WtpI+8nsGp2Mga6VAQ210gYcPQuzYa9esXL1irzdnxVaw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:feedback-id:feedback-id:from:from:in-reply-to :message-id:mime-version:reply-to:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1709210829; x=1709297229; bh=qXOOb8HZn/iPSJmdzFuPpGrqJgO4 hmo4SJraF+NQPCQ=; b=Xxf12xPTINUzxKJKy+j8CL1Fd4s+35b8kD9uNmpgnCPW I4AicNDrVICc4JmYhApx0XGZZKv0F9ntHqzkcV/DfcWtVXMSoNuCXaQ7VpyxcLFn /4653oh/I5dx/Z3NQRxtpef0jk/cI0zXCeIYGLx4YGM4hNcvyuyNLv6c0mFGXSAU 9UtBmdc+nXSGYwSW08X/6T6J7Ga/znMCMRLpRXmY3KUX+ARaQx72h+FbxnthF6fo UtHqiCq4mtVcyOPvpg7fBCvpdmqclbpTuhoy46CZ8jHnTwdj2K22ABynVgPoXWeA T7krtfoj3Sbtf0HwIFhygx336jLWfO8sre45lVLEVg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrgeelgdegfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffoggfgsedtkeertdertd dtnecuhfhrohhmpedflfdrucffvghkkhgvrhdfuceojhguvghksehithgrnhhimhhulhdr lhhiqeenucggtffrrghtthgvrhhnpeeutefgtdeuvdejjeejvdetleffueehtdeftedugf elhfejueektedvvddtveeiieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhep mhgrihhlfhhrohhmpehjuggvkhesihhtrghnihhmuhhlrdhlih X-ME-Proxy: Feedback-ID: i84994747:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Thu, 29 Feb 2024 07:47:09 -0500 (EST) From: "J. Dekker" To: ffmpeg-devel@ffmpeg.org Date: Thu, 29 Feb 2024 13:47:06 +0100 Message-ID: <20240229124706.524355-1-jdek@itanimul.li> X-Mailer: git-send-email 2.43.2 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avcodec: deprecate sonic X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: D+k6uDUWpSGw This is an experimental and research codec of which ffmpeg is the only encoder and decoder, development has stalled since 2013 and these files don't exist in the wild. Deprecate the encoders to be removed next major bump, decoders to be removed one bump afterwards. We also disable the the encoders by default in configure, the decoders should be disabled by default next bump. Signed-off-by: J. Dekker --- Since this codec was added in 2004, there has only been one major non-maintenance, non-bugfix commit in 2013 (6026a5ad4f). That's 1 out of 107 total commits touching this file. This isn't a matter of the codec being unpopular like a niche game codec or some other codec with media found in the wild, it's an experiment which didn't continue and we continue to pay the maintenance cost. Deprecating the codec instead of immediate removal gives a grace period for anyone interested to pick up the format and make it the most advanced audio codec in FFmpeg if they so wish. It encourages an action to be taken whether that be improving the codec, or leaving it to be removed later. configure | 3 +++ libavcodec/version_major.h | 4 ++++ 2 files changed, 7 insertions(+) diff --git a/configure b/configure index bb5e630bad..f11c035796 100755 --- a/configure +++ b/configure @@ -4234,6 +4234,9 @@ do_random(){ $action $(rand_list "$@" | awk "BEGIN { srand($random_seed) } \$1 == \"prob\" { prob = \$2; next } rand() < prob { print }") } +# deprecated components (disabled by default) +disable sonic_encoder sonic_ls_encoder + for opt do optval="${opt#*=}" case "$opt" in diff --git a/libavcodec/version_major.h b/libavcodec/version_major.h index 161442df95..97e4c47d45 100644 --- a/libavcodec/version_major.h +++ b/libavcodec/version_major.h @@ -57,5 +57,9 @@ // reminder to remove CrystalHD decoders on next major bump #define FF_CODEC_CRYSTAL_HD (LIBAVCODEC_VERSION_MAJOR < 61) +// reminder to remove Sonic Lossy/Lossless encoders on next major bump +#define FF_CODEC_SONIC_ENC (LIBAVCODEC_VERSION_MAJOR < 62) +// reminder to remove Sonic decoder on next-next major bump +#define FF_CODEC_SONIC_DEC (LIBAVCODEC_VERSION_MAJOR < 63) #endif /* AVCODEC_VERSION_MAJOR_H */