From patchwork Mon Mar 18 21:31:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Jan_Ekstr=C3=B6m?= X-Patchwork-Id: 47208 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:958e:b0:1a3:31a3:7958 with SMTP id iu14csp1290230pzb; Mon, 18 Mar 2024 14:34:04 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWOLVdAhGhlh6KkUvOVfq4eAXr+f7ahFO4zI5fNerjYxyvvt00fxXb6CJgRktg5Hf1EmrlOiL6gwQ88vZFSIYRMdSVxiCy1Y2NYLg== X-Google-Smtp-Source: AGHT+IElmXW9zGtsYbv6RieveWNV/83arQRS6GeFwWfHZvf4vIyY98zfiL/Grpmq4JDhAp/wrBq7 X-Received: by 2002:a19:8c57:0:b0:513:c9ea:67 with SMTP id i23-20020a198c57000000b00513c9ea0067mr8319896lfj.24.1710797644262; Mon, 18 Mar 2024 14:34:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1710797644; cv=none; d=google.com; s=arc-20160816; b=Q9zQ+gKTSYNlucZyCU/6EsDK1NZBzq4cM1vvD6lAGqYFIYR5mIzZHdOSm1Ctk2l3uN lT6IJy1B0gFjBJHbJavGCc0Vsbhg1r99PgGKY2U68oXYEfsZbYgsbXtxu4eKh793aq3M nIoZlBeXjLa06nAAasI2fOOBxjWTPc9HIY9SZhOrL+IFj6INaj5r4/dDG6ehpFQaNNPG jWDPDsn+Q57mit4QYWN/vRWexOFMIhi+ZS7Xw2TBMY6/HWkxqI43te9DmDx8+SqLWgH+ NWfyJTZToJDt674fdp9Gp/ngP9M2GqmNuNySb83NeFqIaYDN0nX7HCNYn4aVbBJL/+ij zFTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=6Msjg7n2fnXyMi+W6vW0Ri1uCwI2Hvosbuf5Kn79UH4=; fh=YOA8vD9MJZuwZ71F/05pj6KdCjf6jQRmzLS+CATXUQk=; b=fuKwvWh1NmfQXJMSMIMFktGrNVFpx2paLAnExU5JzSpDfOBPHXxmnNj7N20pK0MW7i ZY/NuiGfMhh14MMrjJtoCXn7yWxrL3uan2C6OwvsFZ9m2eoLw9AcQMDTlLLQ6SlAUNJt omW0slQ06/7X+DyMjD1OVidsiTwiyCKaJZndsY94wrF839B9cKZB79IS1Z1CCu9hkrEu Y6BAd8/vh8u8eU1Fmv0lNEix1Uy6UxT0ei9hJyjB6wSpAgkxx+mVnXj3PMYwhQqm1iVe gkibkutamUPHBrlxWbvQ1t1svXyIbLYeenUlAVY7KjjsePw2zciCcAR0A8LLgxMG13Y3 p3wg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=adlPArV2; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id l19-20020a170906795300b00a45ed887cc1si5040202ejo.1008.2024.03.18.14.34.03; Mon, 18 Mar 2024 14:34:04 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=adlPArV2; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F06F068D3E5; Mon, 18 Mar 2024 23:32:11 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8BD9168D3AA for ; Mon, 18 Mar 2024 23:31:56 +0200 (EET) Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-513d717269fso5010604e87.0 for ; Mon, 18 Mar 2024 14:31:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710797516; x=1711402316; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=fAXfuriu4eU6oZ6cp1B4J6LZfZy106V2Zy0WhnT+6MU=; b=adlPArV2ar8/YtWcFOMRORSQP+b2hfyMI6EiYZAKzTKH1CNclMt483vIuxW0BwZhxL LXhXPq0hRNDhLF2VkeqpUVkHdpllsitGR2D9uuX4TIsUVgLE3KrUAYmKH4OnGgVDxHgy 3mYm/pSnNju9KcceBCTI9szssEFQmpbuGZ2+Su63A4rtnMSvyV0eBKLCIy3Mzoixcd7X 5lW5niD9jtzIeRouddu5L1Y5kizyGge9ixlnOSgdZYq8eYohgZ4376PnSe+PGw6hZmRD lQ7XWExTjScH51eCa3Xxi/MeHUJvyKTKXTPn2T3d1jynMqExvM+DI8miaQP+6WArpUFw Tq9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710797516; x=1711402316; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fAXfuriu4eU6oZ6cp1B4J6LZfZy106V2Zy0WhnT+6MU=; b=vC/OfBdUMsuR8FairOQUAfsfhjGEZgVxXuDAUrD3vIHNB7JRydJ3SvHN9Z6TbiovDO XzOq8ioGlDXLE9Qbz+Wc+km07Zy3nnsdJ/jAP1K6HgpdoEspvmO+Q0k+GStCQl0r17wR fDOGSjsboANwQjzHZqQy48NBs8XAcN0BNhPnVeZuQzwbX4vTvpHpy3X7XMSp/g2nlHnm +x3XKriSvFKRJFEB6Mg9kB8j3m2mdCUAFdqivPw2tq5uF+8nLxfMM3rhPhxP8/GDV7/K 0TNeUj2SV5HD1m6othI1H8NM/scAv6MdTyop7qgLM2JWr9ZD87A9R+Cw1YtLpOsjA09a TpYg== X-Gm-Message-State: AOJu0Yza5T/AxESLn2PH1ekaluC+DouKSRSGHfEIyOoOjFWG1ksqeiVQ RgqT9kFjv7RGLqf5KN/izi9yiQJLAitQzOqWKT/eBWGOBPrLkZRydFRSjROU X-Received: by 2002:a05:6512:473:b0:513:da61:9b46 with SMTP id x19-20020a056512047300b00513da619b46mr6803876lfd.53.1710797515680; Mon, 18 Mar 2024 14:31:55 -0700 (PDT) Received: from localhost.localdomain (91-153-198-187.elisa-laajakaista.fi. [91.153.198.187]) by smtp.gmail.com with ESMTPSA id c13-20020a056512324d00b00514b5462dc7sm186929lfr.56.2024.03.18.14.31.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Mar 2024 14:31:55 -0700 (PDT) From: =?utf-8?q?Jan_Ekstr=C3=B6m?= To: ffmpeg-devel@ffmpeg.org Date: Mon, 18 Mar 2024 23:31:37 +0200 Message-ID: <20240318213141.1376789-15-jeebjp@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240318213141.1376789-1-jeebjp@gmail.com> References: <20240318213141.1376789-1-jeebjp@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v10 14/14] avcodec/libx265: add support for writing out CLL and MDCV X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: NQj/KcUtu71S The newer of these two are the separate integers for content light level, introduced in 3952bf3e98c76c31594529a3fe34e056d3e3e2ea , with X265_BUILD 75. As we already require X265_BUILD of at least 89, no further conditions are required. --- libavcodec/libx265.c | 89 ++++++++++++++++++++++++++++++++++++ tests/fate/enc_external.mak | 5 ++ tests/ref/fate/libx265-hdr10 | 16 +++++++ 3 files changed, 110 insertions(+) create mode 100644 tests/ref/fate/libx265-hdr10 diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c index 92183b9ca2..70ec6d3539 100644 --- a/libavcodec/libx265.c +++ b/libavcodec/libx265.c @@ -28,9 +28,11 @@ #include #include "libavutil/avassert.h" +#include "libavutil/bprint.h" #include "libavutil/buffer.h" #include "libavutil/internal.h" #include "libavutil/common.h" +#include "libavutil/mastering_display_metadata.h" #include "libavutil/opt.h" #include "libavutil/pixdesc.h" #include "avcodec.h" @@ -176,6 +178,86 @@ static av_cold int libx265_param_parse_int(AVCodecContext *avctx, return 0; } +static int handle_mdcv(const AVClass **avcl, const x265_api *api, + x265_param *params, + const AVMasteringDisplayMetadata *mdcv) +{ + int ret = AVERROR_BUG; + AVBPrint buf; + av_bprint_init(&buf, 0, AV_BPRINT_SIZE_AUTOMATIC); + + // G(%hu,%hu)B(%hu,%hu)R(%hu,%hu)WP(%hu,%hu)L(%u,%u) + av_bprintf( + &buf, + "G(%"PRId64",%"PRId64")B(%"PRId64",%"PRId64")R(%"PRId64",%"PRId64")" + "WP(%"PRId64",%"PRId64")L(%"PRId64",%"PRId64")", + av_rescale_q(1, mdcv->display_primaries[1][0], (AVRational){ 1, 50000 }), + av_rescale_q(1, mdcv->display_primaries[1][1], (AVRational){ 1, 50000 }), + av_rescale_q(1, mdcv->display_primaries[2][0], (AVRational){ 1, 50000 }), + av_rescale_q(1, mdcv->display_primaries[2][1], (AVRational){ 1, 50000 }), + av_rescale_q(1, mdcv->display_primaries[0][0], (AVRational){ 1, 50000 }), + av_rescale_q(1, mdcv->display_primaries[0][1], (AVRational){ 1, 50000 }), + av_rescale_q(1, mdcv->white_point[0], (AVRational){ 1, 50000 }), + av_rescale_q(1, mdcv->white_point[1], (AVRational){ 1, 50000 }), + av_rescale_q(1, mdcv->max_luminance, (AVRational){ 1, 10000 }), + av_rescale_q(1, mdcv->min_luminance, (AVRational){ 1, 10000 })); + + if (!av_bprint_is_complete(&buf)) { + av_log(avcl, AV_LOG_ERROR, + "MDCV string too long for its available space!\n"); + ret = AVERROR(ENOMEM); + goto end; + } + + if (api->param_parse(params, "master-display", buf.str) == + X265_PARAM_BAD_VALUE) { + av_log(avcl, AV_LOG_ERROR, + "Invalid value \"%s\" for param \"master-display\".\n", + buf.str); + ret = AVERROR(EINVAL); + goto end; + } + + ret = 0; + +end: + av_bprint_finalize(&buf, NULL); + + return ret; +} + +static int handle_side_data(AVCodecContext *avctx, const x265_api *api, + x265_param *params) +{ + const AVFrameSideData *cll_sd = + av_frame_side_data_get( + (const AVFrameSideData **)avctx->decoded_side_data, + avctx->nb_decoded_side_data, AV_FRAME_DATA_CONTENT_LIGHT_LEVEL); + const AVFrameSideData *mdcv_sd = + av_frame_side_data_get( + (const AVFrameSideData **)avctx->decoded_side_data, + avctx->nb_decoded_side_data, + AV_FRAME_DATA_MASTERING_DISPLAY_METADATA); + + if (cll_sd) { + const AVContentLightMetadata *cll = + (AVContentLightMetadata *)cll_sd->data; + + params->maxCLL = cll->MaxCLL; + params->maxFALL = cll->MaxFALL; + } + + if (mdcv_sd) { + int ret = handle_mdcv( + &avctx->av_class, api, params, + (AVMasteringDisplayMetadata *)mdcv_sd->data); + if (ret < 0) + return ret; + } + + return 0; +} + static av_cold int libx265_encode_init(AVCodecContext *avctx) { libx265Context *ctx = avctx->priv_data; @@ -336,6 +418,13 @@ FF_ENABLE_DEPRECATION_WARNINGS return AVERROR_BUG; } + ret = handle_side_data(avctx, ctx->api, ctx->params); + if (ret < 0) { + av_log(avctx, AV_LOG_ERROR, "Failed handling side data! (%s)\n", + av_err2str(ret)); + return ret; + } + if (ctx->crf >= 0) { char crf[6]; diff --git a/tests/fate/enc_external.mak b/tests/fate/enc_external.mak index 4095a4b51a..30021efbcd 100644 --- a/tests/fate/enc_external.mak +++ b/tests/fate/enc_external.mak @@ -12,5 +12,10 @@ FATE_ENC_EXTERNAL-$(call ENCDEC, LIBX264 HEVC, MOV, LIBX264_HDR10 HEVC_DEMUXER H fate-libx264-hdr10: CMD = enc_external $(TARGET_SAMPLES)/hevc/hdr10_plus_h265_sample.hevc \ mp4 "-c:v libx264" "-show_frames -show_entries frame=side_data_list -of flat" +# test for x265 MDCV and CLL passthrough during encoding +FATE_ENC_EXTERNAL-$(call ENCDEC, LIBX265 HEVC, MOV, HEVC_DEMUXER) += fate-libx265-hdr10 +fate-libx265-hdr10: CMD = enc_external $(TARGET_SAMPLES)/hevc/hdr10_plus_h265_sample.hevc \ + mp4 "-c:v libx265" "-show_frames -show_entries frame=side_data_list -of flat" + FATE_SAMPLES_FFMPEG_FFPROBE += $(FATE_ENC_EXTERNAL-yes) fate-enc-external: $(FATE_ENC_EXTERNAL-yes) diff --git a/tests/ref/fate/libx265-hdr10 b/tests/ref/fate/libx265-hdr10 new file mode 100644 index 0000000000..571c837cac --- /dev/null +++ b/tests/ref/fate/libx265-hdr10 @@ -0,0 +1,16 @@ +frames.frame.0.side_data_list.side_data.0.side_data_type="H.26[45] User Data Unregistered SEI message" +frames.frame.0.side_data_list.side_data.1.side_data_type="H.26[45] User Data Unregistered SEI message" +frames.frame.0.side_data_list.side_data.2.side_data_type="Mastering display metadata" +frames.frame.0.side_data_list.side_data.2.red_x="13250/50000" +frames.frame.0.side_data_list.side_data.2.red_y="34500/50000" +frames.frame.0.side_data_list.side_data.2.green_x="7500/50000" +frames.frame.0.side_data_list.side_data.2.green_y="3000/50000" +frames.frame.0.side_data_list.side_data.2.blue_x="34000/50000" +frames.frame.0.side_data_list.side_data.2.blue_y="16000/50000" +frames.frame.0.side_data_list.side_data.2.white_point_x="15635/50000" +frames.frame.0.side_data_list.side_data.2.white_point_y="16450/50000" +frames.frame.0.side_data_list.side_data.2.min_luminance="50/10000" +frames.frame.0.side_data_list.side_data.2.max_luminance="10000000/10000" +frames.frame.0.side_data_list.side_data.3.side_data_type="Content light level metadata" +frames.frame.0.side_data_list.side_data.3.max_content=1000 +frames.frame.0.side_data_list.side_data.3.max_average=200