From patchwork Sat Mar 23 11:14:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marton Balint X-Patchwork-Id: 47363 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:c889:b0:1a3:b6bb:3029 with SMTP id hb9csp158328pzb; Sat, 23 Mar 2024 04:15:03 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXvStzrDmkHRWMzZFStns3a3tAl6QgyFAbm74AvFrzA9abxskBUAItuhgS3GPjbHc9gf11hoBsJPfaR8fRC2LKvtzffeed/mWAJUg== X-Google-Smtp-Source: AGHT+IFk5A55kRd8R79o7j+DxeWDEPb4MN4sw+SFXQ7d+UwkpTCquEiLpsnYS2OfOKywsxpTutfY X-Received: by 2002:a17:906:a2c9:b0:a46:d9a7:d631 with SMTP id by9-20020a170906a2c900b00a46d9a7d631mr1524734ejb.12.1711192503051; Sat, 23 Mar 2024 04:15:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1711192503; cv=none; d=google.com; s=arc-20160816; b=IdWTbi9TO5tN7jkWh/DY/u9K7Yj7YMHOjlJ4XlJayT5GqNj5yqEvXZmO0oaOR6UDPf rJonXPD3gsbFmew6ZR3fxGiTMy8XgWoAPZ9SuaMH8Z6cj43aWCzq6qC8Ll2A13YzUA0e pUmcvZuqe+AZ/zEatXkGLxianTq/HTvuVcTFYgtFr1gEdStZ2jwvc4TNfLjfxeZpn4bw rBOPCK60wL4whbZ0u9Ah0RvwgpbEbU3mo95EPcgNr0FnbyA00Q9JQ7pPkiJqxxsa3SIJ TU4vHn21TvJaQLnVCRfYoqScU0VdESSxlB77vsETT6+7c8PjW8rqwEvnTQa0Y4Fz7rsL voYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:references:in-reply-to :message-id:date:to:from:delivered-to; bh=VFDR+8B3svHqcttB6DyEMOOJxo3GLU3GT2dGcKuOfug=; fh=s+G8Ss4JbeMFkWPSp2LmIH/LXFyBlALRiww1j3FPjHY=; b=Q/QY5ykyGIfE0jMJz1MH6J0Kfjo28i1Al6qG0d44UfP3ZvAagB65yfY4H9iLYZJ0Y7 DiZ1cQTyKbOEuT+8OUQMabOntzs12mKJU3swleRejnG0smzn4EI/vvyVy6lcSg4/JbxS fE2pbeIxonmyWnW2EZt7lUIb3pBmqkgPC8mGTARVTHjpuRC4yRfHtul7SuPvMYKRSpvH c88xeFwXln3+9kr76w+v4aDt9YvHBN3mEl1mJmmE+Wg4E2mtG+TOL7K7E4nxcwXLOOgz 5zRo9GOx4d8puf8rmHLbIwedNEZC78+NIhghGC648a3Cejmm8WPIX913pVzEMvOZV0xq 7kag==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id x4-20020a170906710400b00a45811c5fa8si730764ejj.222.2024.03.23.04.15.02; Sat, 23 Mar 2024 04:15:03 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 748C468D47B; Sat, 23 Mar 2024 13:14:56 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5CCA168D3DC for ; Sat, 23 Mar 2024 13:14:49 +0200 (EET) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id 36D33EA1EE; Sat, 23 Mar 2024 12:14:49 +0100 (CET) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zEvR7qg-IIw7; Sat, 23 Mar 2024 12:14:47 +0100 (CET) Received: from bluegene.passwd.hu (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id 31B2FE9A30; Sat, 23 Mar 2024 12:14:47 +0100 (CET) From: Marton Balint To: ffmpeg-devel@ffmpeg.org Date: Sat, 23 Mar 2024 12:14:14 +0100 Message-Id: <20240323111414.25547-2-cus@passwd.hu> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20240323111414.25547-1-cus@passwd.hu> References: <20240323111414.25547-1-cus@passwd.hu> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v2 2/2] avutil/timestamp: change precision of av_ts_make_time_string() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Marton Balint Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: Pyn8VBZl0ACH By calling the av_ts_make_time_string2() from the function we can fix the precision issue. Signed-off-by: Marton Balint --- libavutil/timestamp.h | 4 +--- tests/ref/fate/filter-metadata-scdet | 12 ++++++------ tests/ref/fate/filter-metadata-silencedetect | 2 +- 3 files changed, 8 insertions(+), 10 deletions(-) diff --git a/libavutil/timestamp.h b/libavutil/timestamp.h index 7e6da894df..fa53a46b98 100644 --- a/libavutil/timestamp.h +++ b/libavutil/timestamp.h @@ -73,9 +73,7 @@ char *av_ts_make_time_string2(char *buf, int64_t ts, AVRational tb); static inline char *av_ts_make_time_string(char *buf, int64_t ts, const AVRational *tb) { - if (ts == AV_NOPTS_VALUE) snprintf(buf, AV_TS_MAX_STRING_SIZE, "NOPTS"); - else snprintf(buf, AV_TS_MAX_STRING_SIZE, "%.6g", av_q2d(*tb) * ts); - return buf; + return av_ts_make_time_string2(buf, ts, *tb); } /** diff --git a/tests/ref/fate/filter-metadata-scdet b/tests/ref/fate/filter-metadata-scdet index ca5dbaaefc..d385920fcd 100644 --- a/tests/ref/fate/filter-metadata-scdet +++ b/tests/ref/fate/filter-metadata-scdet @@ -1,11 +1,11 @@ pts=1620|tag:lavfi.scd.score=59.252|tag:lavfi.scd.mafd=60.175|tag:lavfi.scd.time=2.7 pts=4140|tag:lavfi.scd.score=36.070|tag:lavfi.scd.mafd=44.209|tag:lavfi.scd.time=6.9 -pts=5800|tag:lavfi.scd.score=55.819|tag:lavfi.scd.mafd=55.819|tag:lavfi.scd.time=9.66667 +pts=5800|tag:lavfi.scd.score=55.819|tag:lavfi.scd.mafd=55.819|tag:lavfi.scd.time=9.666667 pts=6720|tag:lavfi.scd.score=18.580|tag:lavfi.scd.mafd=22.505|tag:lavfi.scd.time=11.2 pts=8160|tag:lavfi.scd.score=49.240|tag:lavfi.scd.mafd=49.444|tag:lavfi.scd.time=13.6 -pts=9760|tag:lavfi.scd.score=51.497|tag:lavfi.scd.mafd=51.801|tag:lavfi.scd.time=16.2667 -pts=14080|tag:lavfi.scd.score=34.165|tag:lavfi.scd.mafd=34.337|tag:lavfi.scd.time=23.4667 -pts=15700|tag:lavfi.scd.score=58.310|tag:lavfi.scd.mafd=58.315|tag:lavfi.scd.time=26.1667 -pts=18500|tag:lavfi.scd.score=16.504|tag:lavfi.scd.mafd=19.603|tag:lavfi.scd.time=30.8333 +pts=9760|tag:lavfi.scd.score=51.497|tag:lavfi.scd.mafd=51.801|tag:lavfi.scd.time=16.266667 +pts=14080|tag:lavfi.scd.score=34.165|tag:lavfi.scd.mafd=34.337|tag:lavfi.scd.time=23.466667 +pts=15700|tag:lavfi.scd.score=58.310|tag:lavfi.scd.mafd=58.315|tag:lavfi.scd.time=26.166667 +pts=18500|tag:lavfi.scd.score=16.504|tag:lavfi.scd.mafd=19.603|tag:lavfi.scd.time=30.833333 pts=20040|tag:lavfi.scd.score=13.764|tag:lavfi.scd.mafd=19.060|tag:lavfi.scd.time=33.4 -pts=21760|tag:lavfi.scd.score=64.451|tag:lavfi.scd.mafd=64.551|tag:lavfi.scd.time=36.2667 +pts=21760|tag:lavfi.scd.score=64.451|tag:lavfi.scd.mafd=64.551|tag:lavfi.scd.time=36.266667 diff --git a/tests/ref/fate/filter-metadata-silencedetect b/tests/ref/fate/filter-metadata-silencedetect index bc53fea047..e66ffe5fdd 100644 --- a/tests/ref/fate/filter-metadata-silencedetect +++ b/tests/ref/fate/filter-metadata-silencedetect @@ -1,5 +1,5 @@ pts=0|tag:lavfi.silence_duration=0.523107|tag:lavfi.silence_end=0.690023|tag:lavfi.silence_start=0.736417 -pts=46080|tag:lavfi.silence_start=1.27626|tag:lavfi.silence_end=1.80751|tag:lavfi.silence_duration=0.531247 +pts=46080|tag:lavfi.silence_start=1.276259|tag:lavfi.silence_end=1.807506|tag:lavfi.silence_duration=0.531247 pts=92160 pts=138240 pts=184320