From patchwork Wed Apr 3 22:51:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 47776 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:9f96:b0:1a3:b6bb:3029 with SMTP id mm22csp708027pzb; Wed, 3 Apr 2024 15:51:47 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUtxHWNXF2Fa5UXuQInRzDO99Lh0YC5pkHicAsggjKdNmw539k61CD0qJ/j4BhkLPHoc2nZfD988VJWoSuTRAm5PqgM3sTwbOm15w== X-Google-Smtp-Source: AGHT+IHZGb+5Y5ehqh1ycNRDIeNq77izLWktnJQB86DAqqV9WhLjti9w93I+/0pMW83LHjsVh7CO X-Received: by 2002:aa7:de01:0:b0:56e:418:5558 with SMTP id h1-20020aa7de01000000b0056e04185558mr539311edv.29.1712184706944; Wed, 03 Apr 2024 15:51:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1712184706; cv=none; d=google.com; s=arc-20160816; b=RXuLhgwybvK+1KyrKiy58J3aHK9AKSZtiw86gBJXNPeKBmeyhVlvyNbzjHkoLRg1OT SjkVnGO1a8mUC6KllezxWcIQyHj1EBCMz/yERsQhUq7rRyOUjYZ7icIdqQCBwxVxGqm5 qS3mUrisj7C74ASN0feaTmmz5/D+yqfgKEth1gTZAX3X0h+p96lwb4iQ5SVj7GVBjs+T Av4QNL1K/LtOfDC6tTxAu+Y5F9g/1b6WEcwNB6Dev1/B8FVS4YK08Er+39vfJqpbVwqC yzbFeh2KV6zHAUzKvpgVJQW2Vn4qisNutANpE6u0AE5pcT0MEzKNLsKJL6WdO1TaCRB7 tSsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to; bh=KIGQ3i7oFF3/c76tTH57t+DgzNg8Vt+5onrcw8IupEk=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=tutfwtCPepPaSOPKD9/6MN0VeAmh98xsizFlYc4uQHrKPzyCM6Pu2cp6zfcVhk+JH+ VgMgK7gne/+L7Zy9+2rBjAyjrfBWTKLeD06SWboQfOkDc+fuDgq9H6Oql5OATUWSXbGo MunYv3J+P5VCTUCgf2TgHVX3SJQZvJUl7BHyGh6msAWdKcEa1vm1W7wUCDEtL1K8c4ee zwksI0KfmODRSIR5jxHQhRQ+8ZRu14i6UHQU9thE1lkicqW0AgOanabUXBn2gauOlkuC 4xK3e4D6/8NEThkQeJGur/XwoOHx6g3vwOKgxmwOCOl77P+LknOawo+k5Ikhb/X7GfsD kxwQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=a5DVIO1w; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id q6-20020a056402518600b0056bf2d405b6si7523383edd.31.2024.04.03.15.51.46; Wed, 03 Apr 2024 15:51:46 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=a5DVIO1w; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9E72C68D0B7; Thu, 4 Apr 2024 01:51:42 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BEBCC68CF08 for ; Thu, 4 Apr 2024 01:51:35 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id EC0A9E0004 for ; Wed, 3 Apr 2024 22:51:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1712184695; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc; bh=/J0sgHzxiEYLyziiKSUi6HZ5Rek7u8hIyUkeBWEcFFk=; b=a5DVIO1wEqPt2vlD7PPBKIqMCbNTO1Nh+xCmBF/+xRAJd7tfxWHYa0Esz8K8Y2rBOCDjm/ I/VeJ9+uUng5QEfNvy58tKai44LgsQCfNOv4XeFSZxLYTdSs/piZvThMWcJdSeRwWuK+IH 4tMeTg4hvR2aIAF6S1QwFxyynkZNUTh3aFLig3EbkEnBPUeflleH57fOifsi4eJOlMmhkk pIWWHWLG9tKPvePa72qN1OgjeeUMqPp120S57Pqbk+2Sk98cZUzMJTnj4aXw8tXR/FolY6 s3KTVcmCV4xNDdFy5H8jLEq9ZpIiHldmMV1BhErp4Likp8XCwdzerKQBQtQW1w== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Thu, 4 Apr 2024 00:51:30 +0200 Message-Id: <20240403225134.31764-1-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 1/5] avcodec/wavarc: fix signed integer overflow in block type 6/19 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: SsmCck42JotA Fixes: signed integer overflow: -2088796289 + -91276551 cannot be represented in type 'int' Fixes: 67772/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVARC_fuzzer-6533568953122816 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/wavarc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/wavarc.c b/libavcodec/wavarc.c index 7083494cd81..b4b26958e6f 100644 --- a/libavcodec/wavarc.c +++ b/libavcodec/wavarc.c @@ -647,7 +647,7 @@ static int decode_5elp(AVCodecContext *avctx, for (int o = 0; o < order; o++) sum += s->filter[ch][o] * (unsigned)samples[n + 70 - o - 1]; - samples[n + 70] += ac_out[n] + (sum >> 4); + samples[n + 70] += ac_out[n] + (unsigned)(sum >> 4); } for (int n = 0; n < 70; n++)