From patchwork Wed Apr 3 22:51:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 47778 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:9f96:b0:1a3:b6bb:3029 with SMTP id mm22csp708134pzb; Wed, 3 Apr 2024 15:52:05 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWDj3ucH2VnBMQhMHN/eKR6Jz5mf8rQvHAms+IV0EhVBcL2JYbYr+1DPOnUVPkwWj9WuoPDlxL+J51TvdXfGYCJ68pQkQ1GALHGOw== X-Google-Smtp-Source: AGHT+IE8runwRAS79xdXTHMl/fDPtZNYHT9Tn19TWbQqR9hXuSPaIiGhNdE35KkyQ+PCCWU7EGwj X-Received: by 2002:ac2:4d91:0:b0:516:a25e:7909 with SMTP id g17-20020ac24d91000000b00516a25e7909mr424363lfe.2.1712184725047; Wed, 03 Apr 2024 15:52:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1712184725; cv=none; d=google.com; s=arc-20160816; b=0C6osADOGQNnXO9BI2Fx019i+NWH0GECCm+VSpqWWCVtLRWZdNDCP+aUYx3g+GfIE6 UuSXa7Cq9XH9/HQn+HMAghkYvTEvJTAo/ALksaBN5qqj2mMMYWGW8K8oQUbdkKvKNugq +8eSjtiMOaWlGUTANK3+MNSQJHEqmEJnPMIIbdO059o09njjFz3MMAVRLHUmP2XhmiA+ PWpdS2PHmQqbu94w9OuxHKTmVRrbzGGat4rIKTaYQhCImYNMWBJxMPbqFy6IC3Wn82B4 04hBMEc3LU3NaWOsHPzHpwDpk39cWsyHJyrDNbDnWyuirogG1IsSdUGJYkVyJLF04JkI NQ/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to; bh=6shEeMZexh6Oso1PUh7WccHwm/fFec/OdgT7B/E69yo=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=bxLcw2U9xUFp9OWPzyvxWhykRkRyOzdHObAGvgnmANmZmDFK4SkVy/oEWydsAexody xhF2ZXraQqPLvTiaZ21bMyDMFFC0+SMQ8VQRDAsRMRs9lfo2k0KxwoCAkMpKcnalqSoe 7ZaMU9fkAvH/HTPjbCtt26gb09tdfuEtt26oqThlQigd4hWiPidaPr1A5BT7z8/gi6Ka YX4UvzDNZYuvn//82TIapF1XzUN7Jg/0wjrWi7omhqGgWtencxePVs9xiBFMqLkHEEya BdQmFJZJQsovB6F2BpBWSpM9XiNf/ldv8ezDR8437gY/TvpHjESwzuyibESm+0g5MHbY NlmA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b="K6/7guUM"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id y17-20020a17090668d100b00a4e876843f4si2241399ejr.542.2024.04.03.15.52.04; Wed, 03 Apr 2024 15:52:05 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b="K6/7guUM"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C144468D0D2; Thu, 4 Apr 2024 01:51:44 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8F8F168CB86 for ; Thu, 4 Apr 2024 01:51:37 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id BCC661BF204 for ; Wed, 3 Apr 2024 22:51:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1712184696; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:in-reply-to:in-reply-to:references:references; bh=KdP6gybbGZz76uH2taJ7EWrhQIWsAsQvpu2/scKbPEw=; b=K6/7guUMbKlpBgsmJ8x5UtaDHYHdHIGRTZx0ILexS0lPrW/nlo/Rh2FV3M7xXQb/QSvWrA ad1n8/uNaVw6UexUrccZnzWDoma/oolLpuig4AF1mSbCgnd4ABoxoKvs7ZLydSWYmnvBdz DnHts4rZhhjl2Br09GHpD68aFkUZIH86eUeDoLSdsTO9NYbDflOzak0Kq1AIKKRaaj34b6 2yxVie4GMOSevAxh4gA/EKWR+ZumaIroChAq/2ZxWJZZ9aw+gcnU/ppOzay+jT1IAaBDg6 qvJnCLYs4hREZftHmYzvMlJhRuX9MWGUPjL71pRpkozrUY+Vq0cSkoFzrz7siA== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Thu, 4 Apr 2024 00:51:32 +0200 Message-Id: <20240403225134.31764-3-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20240403225134.31764-1-michael@niedermayer.cc> References: <20240403225134.31764-1-michael@niedermayer.cc> X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 3/5] swscale/utils: Fix xInc overflow X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 38xe/Ew2OLxh Fixes: signed integer overflow: 2 * 1073741824 cannot be represented in type 'int' Fixes: 67802/clusterfuzz-testcase-minimized-ffmpeg_SWS_fuzzer-6249515855183872 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libswscale/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libswscale/utils.c b/libswscale/utils.c index d34c8d1641e..df14eb016ce 100644 --- a/libswscale/utils.c +++ b/libswscale/utils.c @@ -593,7 +593,7 @@ static av_cold int initFilter(int16_t **outFilter, int32_t **filterPos, filter[i * filterSize + j] = coeff; xx++; } - xDstInSrc += 2 * xInc; + xDstInSrc += 2LL * xInc; } }