From patchwork Mon Apr 8 18:20:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Plowman X-Patchwork-Id: 47936 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:3f98:b0:1a7:a0dc:8de5 with SMTP id ay24csp80455pzb; Mon, 8 Apr 2024 11:21:13 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUt7MLkkh2MoTLdCAsulL++BsvuovRSwr47byTMtF+tqWMSrPLLUqNzNzMxAjnxOHbmTzC4uv6uNAALKLMs7egOmum7fQ78YP386g== X-Google-Smtp-Source: AGHT+IEsMT17jMZeCSgPc4nG7AtGhBi/InfNnOSlTAq+FRKtju0ukZy1qSqZrD/bIsX/WBphG5wY X-Received: by 2002:a50:9b1d:0:b0:56d:fdb3:bcc5 with SMTP id o29-20020a509b1d000000b0056dfdb3bcc5mr6636610edi.12.1712600472744; Mon, 08 Apr 2024 11:21:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1712600472; cv=none; d=google.com; s=arc-20160816; b=nfgiPA1iUakReLh06ub2TfOKjZ3HlHC1ituIdKvJEIrbWnJMeOFDUmQdftz7hnDrTq PjN6oIKwgcw/mEmXYBd1N9Pv0/h5X8OrK5on0Sstb3PVlXP0okl6QOjDTZhnKa2FS8B6 6TJswPE0ToM/70fLlbaIfPFwZn6CjHyXsFqXnoFO7PNQ/50FbssZRCkf3moN/sLfoaEK XK57G2+790u504bt8npF6f9cZn1/Da+ISIgcLGo1xVL/gy3jXNrU70oizwNODSBY4pp8 vUAwiNmMUft8qNJidXKnMfchamIpJY9ODNmstOb9cgLG/FGLbpRl01MeaQA5q6FPOm0c t4UQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:to:mime-version:message-id:date:from :dkim-signature:delivered-to; bh=dsTfxSvc0lUov+OCCkzbUVpzMV6hOIMXw1f9WmLkc5Y=; fh=GABYHefZpsCOOVRn8a1IgmYuOvaCu1oFlwEOjvaxWTE=; b=HqyM0ZB3ZEsT45xKCJhxoVzxq54Ch42Ot3oKMiBV2i7Vu7DGusaDjx2LdiU9Qev34S oWdErH7hzhC5NjYAUZGQpLLZkFsZ7TfU/XbLoO3m1xMIJd5FmRT2KM7D+EJ1VADWAwTc 4t4g2SFxFfiMx0vlNjKWDmY/rT0r/Xv1L7LW9bsbVnMvmOapdrbgD1ePed/3QoHH9D53 Nb3t6Wlze2rZA9pUFm9IAQp10ZmA5FR3ALpAaeA4o8TuQDI9aayclH/8e2uu5tlmbB0T V+3mHw36eh02riVOt31BpG+Bkyt8wZ13w4Q+DIRzav+/EVtqk4MJohtSaPQ05WoFeSCB JVAA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@frankplowman.com header.s=s1 header.b=TwGsLGtS; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id u24-20020a50c058000000b0056df27d4a53si3974979edd.670.2024.04.08.11.21.11; Mon, 08 Apr 2024 11:21:12 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@frankplowman.com header.s=s1 header.b=TwGsLGtS; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DA65168D2E4; Mon, 8 Apr 2024 21:21:08 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from wrqvqsbb.outbound-mail.sendgrid.net (wrqvqsbb.outbound-mail.sendgrid.net [149.72.70.187]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E25CF68D1D1 for ; Mon, 8 Apr 2024 21:21:01 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=frankplowman.com; h=from:subject:mime-version:to:cc:content-transfer-encoding: content-type:cc:content-type:from:subject:to; s=s1; bh=GbR6ljCxNTu2wrgyyGLX1ylz201YIHzZBov7nCtbdT8=; b=TwGsLGtSHv4lfGFrFqCXMkibbARg6ry00NuOBJ2Mn+ujycTXCEasSScrNOf+YOnWt7wr rwR+1RDbpO4yqZxyil+U2YQqi6nvEs9gzortoga2H8ZPDYofn9uSLFviQ1J0Yge+q8aXDc iiZsiyxM/ntUBpzhp3RyCuj0I5Q7eW0+Yqkf2Bxj3B9U0A+AlUzUsaYB7BQjkMUNgcauyT aMBzLfzPDy2h78zOM5SHca1+spAy3LFFneGtxFCvAz2R3O2Fre1TzVmROlqfJNgQDPs0VL eOuPvo85xeShXk626Jmy6blJDBL2ukPGRB/CLFzBRIjxFnENMgFAN31rODZsbzQw== Received: by recvd-7d655c67dd-gr9c8 with SMTP id recvd-7d655c67dd-gr9c8-1-6614358B-4 2024-04-08 18:20:59.143315979 +0000 UTC m=+1804792.469242333 Received: from localhost.localdomain (unknown) by geopod-ismtpd-9 (SG) with ESMTP id OrpLjK_1TwuIACyci7aCEQ Mon, 08 Apr 2024 18:20:58.822 +0000 (UTC) From: Frank Plowman Date: Mon, 08 Apr 2024 18:20:59 +0000 (UTC) Message-ID: <20240408182051.514137-1-post@frankplowman.com> X-Mailer: git-send-email 2.44.0 MIME-Version: 1.0 X-SG-EID: u001.Z0KJCHpts8tvDq7PHgz5cpqJ+vJcSmdTtST/g91WT3qAbNxUpEMGIDQq91mXy3Yjvepp8fYsFUJzGsyhT1EwBcl8YxZnspu0c4tIBnLtxHZ1dnecGNg9fbrmOyLuhHz8VkXh27Ea6M/uR7CsSDq4DVNeL2ydp+EpUkZoyYPZO5eo/67R70XPlcZQXfBV/fHshEYFqUUyzFcfO+cHcD0avAfakPj6aSCfQn+e00nCt5OEOu1JWyN77frAKC0xIyEh To: ffmpeg-devel@ffmpeg.org X-Entity-ID: u001.qzljkbu34TNIX4NwfTiKWA== Subject: [FFmpeg-devel] [PATCH] lavc/vvc_parser: Fix integer overflow calculating framerate X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Frank Plowman Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 2NsTa8NmvWTn num_units_in_tick and time_scale are both 32-bit unsigned integers. Storing them as ints was causing overflows. Signed-off-by: Frank Plowman --- libavcodec/vvc_parser.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/vvc_parser.c b/libavcodec/vvc_parser.c index a6a5be27ae..e3501fa139 100644 --- a/libavcodec/vvc_parser.c +++ b/libavcodec/vvc_parser.c @@ -191,8 +191,8 @@ static void set_parser_ctx(AVCodecParserContext *s, AVCodecContext *avctx, if (sps->sps_ptl_dpb_hrd_params_present_flag && sps->sps_timing_hrd_params_present_flag) { - int num = sps->sps_general_timing_hrd_parameters.num_units_in_tick; - int den = sps->sps_general_timing_hrd_parameters.time_scale; + uint32_t num = sps->sps_general_timing_hrd_parameters.num_units_in_tick; + uint32_t den = sps->sps_general_timing_hrd_parameters.time_scale; if (num != 0 && den != 0) av_reduce(&avctx->framerate.den, &avctx->framerate.num,