From patchwork Fri Apr 12 12:35:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: LuMingYin X-Patchwork-Id: 48028 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:670b:b0:1a9:af23:56c1 with SMTP id wh11csp232508pzb; Fri, 12 Apr 2024 05:36:23 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWuoHcqUhiifWjHj0ukgn/ZVif+DLeQer35qS3pmmZDqYYTEugSr0qMQarjyyxaeqBSh9t3zE6PKpY/Ar1dZoD5cLnoHH3XjGJTGA== X-Google-Smtp-Source: AGHT+IHG4inzZ/VHeQ8fBL41G/ivv3z/BK6AHPWtAnwPDlTjZ2zdbSGXMXSVsDuy89q0UHA4T/Z5 X-Received: by 2002:a19:ae06:0:b0:516:c076:74cf with SMTP id f6-20020a19ae06000000b00516c07674cfmr1580147lfc.36.1712925382729; Fri, 12 Apr 2024 05:36:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1712925382; cv=none; d=google.com; s=arc-20160816; b=G1TjbhMSLfhUejyPCpGo13umYY3mIduytt9Fdo+cGVKYxcdyKDUISPaV3J8tdo0j9z +rA7bIplp0NQn5QkISAKsml1ZqOWgyWseDrNrX7tSlUt961V0s6A+BHhKN9Xrz7pz4jg SJ9VI9Vxp8O9t+4U/Ia/n+kntOymCDeKNeYhIcpvWEI2sec9JI7qy2YubT5bpk3bN1LV 8Q0uNdz+3s1cfIDVdqOug7SnNSWHVeO+S5uaznYR6aw/tprIb4snZb5GHglxbAGbYLWF YmKMjXi6a3EGTjDZf6AMMzSdE5+tG+GVVxuC29bZzx/jkHRwMJl9E3/iU0kFd8WRM/Ts aB2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=/hjZf2oGZhDYvHOTcLduWbbhGP0dU2oFQYDCytOn+0I=; fh=h93Jk9zXtjyzsFd9PKvKbdVr/RKQn4bW7LGFE3/Lh8E=; b=DRuq54Bc48XtDkgSipq0CC0dbi/RWaZd/nTSgBMGnT7IdQhTjCmRqOTKlUL6+MnODQ 3wLC/6d2+AF7VJY5P7dWM+bu40ltA0BY1lOj4CNpeueE5tcWiI9XgoGK6i5iIYgi1Col p+Ap9+1lOhsW9Z+ZkCe0jqVvbfKs0A9vdD2br6jKmDKLFsEwzOh2OpGS+LCa37Lcd1ab oXHh/xcnM40mIYt+WA79wuFv87BscWpAQBXgSIJjizj+UvgGK+jXMd71hDsjndIn3MIv RsTiS3//4x+2RTG2I3CGP1Fa/Qh+SGGglcd4tUcQs0SqzmtI2cFTWyuVhCNRCTDYs0GG XOXQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@163.com header.s=s110527 header.b=YwEIRPJY; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=163.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id b7-20020a056402278700b0056c53edca63si1696759ede.281.2024.04.12.05.36.22; Fri, 12 Apr 2024 05:36:22 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@163.com header.s=s110527 header.b=YwEIRPJY; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 755AF68D26B; Fri, 12 Apr 2024 15:36:18 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.5]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 31EB668CABE for ; Fri, 12 Apr 2024 15:36:10 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=r25u5 u9eAcAjIt/EPQZGBxj8PW0imALAVVjJK4EHIik=; b=YwEIRPJYSYptQ2s0sTsK7 ++cnpJfUDFalo8DWCLtOkwyDdkTj3NmpC22W+XSU2fmFUBujt7ZVeo3SZfHbaRBm PhTG8Tr4tSAQNrDhMdp6veF/VTvAZfB1P2YJAVTczJNyL0fb3m401kHUBlo92+ou 1YX5F68FFvPzYSLSVZiBRQ= Received: from localhost.localdomain (unknown [111.198.54.11]) by gzga-smtp-mta-g1-5 (Coremail) with SMTP id _____wD3X0uwKhlmEDG1Aw--.24607S2; Fri, 12 Apr 2024 20:36:02 +0800 (CST) From: LuMingYin To: ffmpeg-devel@ffmpeg.org Date: Fri, 12 Apr 2024 20:35:58 +0800 Message-Id: <20240412123558.1262807-1-lumingyindetect@163.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: _____wD3X0uwKhlmEDG1Aw--.24607S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7Grykuw1kCFy7Zry8Zr1DKFg_yoWDtrX_Gr yrJr1xJr4Yqa4jqrW2krWFqFZ7KayFyFs5Wa4qqr1Yvw1fJan3XFn7WrZxZFWSqw4fKr9I kr95Zr1fXr1a9jkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xR_5l1JUUUUU== X-Originating-IP: [111.198.54.11] X-CM-SenderInfo: poxpx0hj1l0vphwhu3i6rwjhhfrp/xtbBLxq+92XAkk+bhgACsb Subject: [FFmpeg-devel] [PATCH] fftools/ffmpeg_demux: fix memory leak on error path X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: lumingyindetect@163.com Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: isyAwBHMfM2J In the file ffmpeg_demux.c located at /FFmpeg/fftools/, a pointer variable named ic is defined at line 1531. At line 1589, the program allocates a dynamic memory area for it using the function avformat_alloc_context. When the if statement at line 1668 evaluates to true, the function returns at line 1673. Throughout this process, the dynamic memory area pointed to by the ic pointer is not deallocated, resulting in a memory leak. Signed-off-by: LuMingYin --- fftools/ffmpeg_demux.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c index cba63dab5f..2cfcc3c69d 100644 --- a/fftools/ffmpeg_demux.c +++ b/fftools/ffmpeg_demux.c @@ -1670,6 +1670,7 @@ int ifile_open(const OptionsContext *o, const char *filename, Scheduler *sch) "Error opening input: %s\n", av_err2str(err)); if (err == AVERROR_PROTOCOL_NOT_FOUND) av_log(d, AV_LOG_ERROR, "Did you mean file:%s?\n", filename); + avformat_free_context(ic); return err; } f->ctx = ic;