From patchwork Fri Apr 12 23:16:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Almer X-Patchwork-Id: 48034 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:670b:b0:1a9:af23:56c1 with SMTP id wh11csp572914pzb; Fri, 12 Apr 2024 16:17:31 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUFCi1IZf/Olobx47TNzRVQPWgRPFpY8VJhts7z5AvPmD3S/zJ/dHFq0igTJMG4pG7qnD/AdLUmOe7HSbiJhzr/CePT1eUM23eWNw== X-Google-Smtp-Source: AGHT+IEMz1fE1Vjek0+sczabw4A6Ut4yFbjS9Lim48Ff747awAr2zAFFQX/4PpcH9O8ytWx89qMl X-Received: by 2002:a2e:818a:0:b0:2d9:fbbc:e6fe with SMTP id e10-20020a2e818a000000b002d9fbbce6femr2335129ljg.28.1712963851071; Fri, 12 Apr 2024 16:17:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1712963851; cv=none; d=google.com; s=arc-20160816; b=PXk5vt2JXGlUzQG6n+AHwcYMuWxIJt9ASPvHGXvd8wLiPqQofZ3TbamF8oT6+d/duT H46XBQxNXEhlVQBd7gMaqUzYurCqXoVDfo9u2x7uApD5M2GoTpMBinVdVs+uguccR27s u3fDW22muPt+ndJ3BjMiAxEqa5dUPAEHdzbW9avNyakbVLLBwJLPtqItDRBccrnCvOE8 oYixr1oisC+NKNN2LN+/OOPOKoifW8JlzcVp6DdZFHvNL+2lD7T57YujeEOzuNChrqer bkqxkyzx0Z13V202gIWJ5a/5sKQdx9vlSfP4PRqnwxG4CRouUZmcLnG1ns2deLqWuxK0 xdHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=q2aMuOYIBMLpwbhQ0XKN0/zhURiSqRzti5rIfvrg+VA=; fh=YOA8vD9MJZuwZ71F/05pj6KdCjf6jQRmzLS+CATXUQk=; b=qgjb9tH+ywEVDTsZzJxfhRevIacBj/a7J9FPWpVIFnDxU3bOUAErmmWUOivXsemhCV Nbd4OyZ5M0wB531I+Yzx/Ug9yLsk8BAnhiXkQxFnURmck3HFcspZ5MYu6r2hzdfNxaLZ /CCo0YHTbDJQol6hV0R8+nTZMRkMDBu5HSbQzTDav1FXjLs7dQa4gN4o2NhVzyw2LcNI yS6T+Mie39FT1evg9p53TsP9wNnn6+bExBbTjerfkY3oc7CsicytXblv4CkJdb3fq9j8 DJ79S7VXnthNPpO/eCpAO3K1wSIpzlIMK5zMl0sE6jTTmQvuFC+GC9aa/MXpLcGVhJZ7 pn4w==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=grHeiPkb; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id x25-20020a05651c105900b002d6f3680b6dsi1228398ljm.79.2024.04.12.16.17.30; Fri, 12 Apr 2024 16:17:31 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=grHeiPkb; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D022B68D2EA; Sat, 13 Apr 2024 02:17:22 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DAFA068D0BD for ; Sat, 13 Apr 2024 02:17:15 +0300 (EEST) Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-5c6bd3100fcso902774a12.3 for ; Fri, 12 Apr 2024 16:17:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712963833; x=1713568633; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=TwBkgYYO3ynJ+ggnnBynPTXbbrkL5cVrV4UCMUpTouw=; b=grHeiPkbRkCiVuRHUBIMu5MV7iruiEeigIvrEEx3rsKV9bBG/3Wnz6WztdWGAZnL1g QIHmG7Gzlng+an4rivztl/x74G6li94QyRdVDguZv2FLkgaYOk6059UYqYK+cg2YaO7O TZmNn/avg/iG1IHRhYxT5eNQw5hB4krI3Krgw82qjeBZavtqH2+2X6y+fTwSdnZETJiI Rhd088/HTjqVhhOm5rpkxQ7iSeWhmbUJ5ROWB7WUC12UYDTEkKH5BtRrrmbsvERJdM6k eDUjMpSS34xQQxoFzbIkxt4BSLY1HRNwdjlAQX8z5NDIhdkaLCcztMXZfhfAegb8jbVz 6aJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712963833; x=1713568633; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TwBkgYYO3ynJ+ggnnBynPTXbbrkL5cVrV4UCMUpTouw=; b=ftMt0MW8DURq6gsx/Q9C7xwzPblfFE+I+mzqS+fRhy1RPCIJs5AulXnom/4cCAJuDA Z5P0dtN40t5mAusyKxLbDMS5LKYnaZ75IKy/n7vVfSmuMY8hsPIvblONqf0dtHqh3Tws ft6ZjucHhGWBdACC9M65f7crHniMaxLDC0NCh5SX6IM7x94HbwZMhItFFhcWHJGDHM2s e9pVxrC2n9/gOTKhNxJweTtC1e2t8YtFT+qMEH8Lcm9f5lNAc9yNIg88SIIYXj8iWvbf PVgd1N73+lumrDMliK7rjX4f0Pla26ee9HbKg+dzU6YbrfHvF8KHVUPcpR1rfthVpLOv vdAQ== X-Gm-Message-State: AOJu0YzBxqV7t1X7jthxg7PCxOjLlndSEad4HnWz1cnQb+OrioTllwnB gpxO/pJGV9QGI85Y4nfIy/71HGtAiJUsxWQ3f4Z1hZuRekim2UwMebwhBw== X-Received: by 2002:a17:90b:710:b0:2a5:badb:30ea with SMTP id s16-20020a17090b071000b002a5badb30eamr4249757pjz.36.1712963833195; Fri, 12 Apr 2024 16:17:13 -0700 (PDT) Received: from localhost.localdomain ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id x23-20020a17090a165700b0029b59bf77b4sm5438284pje.42.2024.04.12.16.17.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Apr 2024 16:17:12 -0700 (PDT) From: James Almer To: ffmpeg-devel@ffmpeg.org Date: Fri, 12 Apr 2024 20:16:57 -0300 Message-ID: <20240412231658.4625-1-jamrial@gmail.com> X-Mailer: git-send-email 2.44.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 1/2] avutil/test/opt: test the AV_OPT_SERIALIZE_SKIP_DEFAULTS flag X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: nfBWeJV/S+o3 Signed-off-by: James Almer --- The floats are set to "1.0 / 3" and the serialization prints a value that's not exact, hence them not being skipped. array_int is weird, though. Although it's the only array that doesn't set AVOption.arr libavutil/tests/opt.c | 5 +++++ tests/ref/fate/opt | 1 + 2 files changed, 6 insertions(+) diff --git a/libavutil/tests/opt.c b/libavutil/tests/opt.c index ccf3a54f96..32301ba842 100644 --- a/libavutil/tests/opt.c +++ b/libavutil/tests/opt.c @@ -279,6 +279,11 @@ int main(void) if (av_opt_serialize(&test_ctx, 0, 0, &buf, '=', ',') >= 0) { printf("%s\n", buf); av_free(buf); + if (av_opt_serialize(&test_ctx, 0, AV_OPT_SERIALIZE_SKIP_DEFAULTS, &buf, '=', ',') >= 0) { + if (strlen(buf)) + printf("%s\n", buf); + av_free(buf); + } } } av_opt_free(&test_ctx); diff --git a/tests/ref/fate/opt b/tests/ref/fate/opt index f4fce1bd49..43bf0929a3 100644 --- a/tests/ref/fate/opt +++ b/tests/ref/fate/opt @@ -179,6 +179,7 @@ Setting entry with key 'array_int' to value '' Setting entry with key 'array_str' to value 'str0|str\|1|str\\2' Setting entry with key 'array_dict' to value 'k00=v\\\\00:k01=v\,01,k10=v\\=1\\:0' num=0,toggle=1,rational=1/1,string=default,escape=\\\=\,,flags=0x00000001,size=200x300,pix_fmt=0bgr,sample_fmt=s16,video_rate=25/1,duration=0.001,color=0xffc0cbff,cl=hexagonal,bin=62696E00,bin1=,bin2=,num64=1,flt=0.333333,dbl=0.333333,bool1=auto,bool2=true,bool3=false,dict1=,dict2=happy\=\\:-),array_int=,array_str=str0|str\\|1|str\\\\2,array_dict=k00\=v\\\\\\\\00:k01\=v\\\,01\,k10\=v\\\\\=1\\\\:0 +flt=0.333333,dbl=0.333333,array_int= Testing av_set_options_string() Setting options string ''