From patchwork Sun Apr 21 23:07:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 48205 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:c906:b0:1a9:af23:56c1 with SMTP id gx6csp1952759pzb; Sun, 21 Apr 2024 16:07:22 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUkeHKALYelcHL43QSzgdhIutJl9Ul94ebuVRKVn2fcX9Q/HtuMeg/+DR2rxyIYW+tVtBLmdj45Rq9Jm76hKZrNPqzIe2di6LC2AA== X-Google-Smtp-Source: AGHT+IF6HMTPwAWL7PYqYgD8gU/RQnWnIBdSH/GtnL68b33U5TwLkBw3Jtm9XO0M+6lz1pSKqYsK X-Received: by 2002:a5d:604d:0:b0:346:47d6:5d17 with SMTP id j13-20020a5d604d000000b0034647d65d17mr5266442wrt.57.1713740842318; Sun, 21 Apr 2024 16:07:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1713740842; cv=none; d=google.com; s=arc-20160816; b=Cw+kxNPtlzRxShlS4CVuKs4yWt8TdsUGcIlMaFI4iFbkgs3SCJmC+Hdv8Me3Q7P26D Df6MXcROWT/pP0pJF8uJGx1po0rkqEQx4Ov6sxvfVMFpdIOm5LZlYGBSQTPDF6VxBjN5 LOBwIoDKqlrpzu9lA+uJhxyqIKkaz1gbplEZ0Lk/2pecTFCeCCc8QVFiHdPAWoIdESCF mCU5T66Lit+NQHYdiQI5+8IDymc15lavuFIIjM+gp2yWJHuo4mOE7X3tO4EK8N92iExS xdMI1q16EnDB3crjyhwylxTvoDNyMiSuTYPfLHmp1gflFyx18Bf9J5TY7ScTqud6qTSg U9Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=TKGB3YszTT+99iSGXto8npsVc8KEbIiKkvTiou7FSio=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=yxmFwDWh5WOwrngkCYEVNKdqEgQn21QGicy4lE+HhCijFZ/Y/nsvDQ03WWOI3VXQXR /iM5222pOvglchr9Fxy2EdAGi1/qzTL5hS9fb/vUTQ+CRefdSu7p9+8hqDRm39M0hmrg Mb6duG+TpnAKmVqKSsxh/u1GnHB3bwBETaEBo+VEPCeEBtpHJSOYKUNogH4DVpiZQmG+ 4n5Kac8JWAyrmwbyEoGU7jYCuua01lZd9KL3ONsp3+iKH/dQyIlAbonZiPqOKIKtzcpH jg5qHNTUhOO30RaMXdaHULsWtKyajvNQR1JdHw1ha6dQx/R/VCaWjuqr+79RWzyAeFnv Mtcg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=YOLHZ+Lh; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id dn10-20020a17090794ca00b00a558e3813cbsi3357646ejc.269.2024.04.21.16.07.21; Sun, 21 Apr 2024 16:07:22 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=YOLHZ+Lh; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9F71068D2A4; Mon, 22 Apr 2024 02:07:12 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0515E68D0B5 for ; Mon, 22 Apr 2024 02:07:03 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 5946B40002 for ; Sun, 21 Apr 2024 23:07:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1713740823; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cv4o3fewE8KMD/ZIvzV2TU3C5BNNsCpDqk7cwj/9fDs=; b=YOLHZ+LhchTfkXx/JZdyXX/YkNcWb5hWwzIWDlYPH3mkgYzDeIY9aYKDJRu5n4TfLoXohV MG8zAYhXY2uSjR3MgtuvD30F1DOTmnJ9WjRmfsPoU/+dvj0MGYTa0BvZA0iOzNNSFU+pf/ dugDpmIt+BfUtvX3hGva+W4Sdh/Yp6LKuk8ACNmBiDCqoK5gunYn9z/qljz+CgH1yawpXj SR85d9RBndkThmATjfsKc6BnvDFxC1z2oUpP8c//WG86DfvyeKeKTBo3QJ0fKtaSlWOXSI LcTlbyvDeGs3j6jxMWe7GUnj9TZeGrIUP49s+XNj2OG59NDu+Pmp3olW42+SYA== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Mon, 22 Apr 2024 01:07:00 +0200 Message-Id: <20240421230701.4178782-2-michael@niedermayer.cc> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240421230701.4178782-1-michael@niedermayer.cc> References: <20240421230701.4178782-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 2/3] avfilter/signature_lookup: Initialize bestmatch X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: Ngg7QYo5rTP4 Fixes: CID1500345 Uninitialized scalar variable Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavfilter/signature_lookup.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavfilter/signature_lookup.c b/libavfilter/signature_lookup.c index a3086b38cca..dc0a2ef2b24 100644 --- a/libavfilter/signature_lookup.c +++ b/libavfilter/signature_lookup.c @@ -535,16 +535,14 @@ static MatchingInfo lookup_signatures(AVFilterContext *ctx, SignatureContext *sc { CoarseSignature *cs, *cs2; MatchingInfo *infos; - MatchingInfo bestmatch; + MatchingInfo bestmatch = {0}; MatchingInfo *i; cs = first->coarsesiglist; cs2 = second->coarsesiglist; /* score of bestmatch is 0, if no match is found */ - bestmatch.score = 0; bestmatch.meandist = 99999; - bestmatch.whole = 0; fill_l1distlut(sc->l1distlut);