From patchwork Sat Apr 27 23:54:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 48317 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:1509:b0:1a9:af23:56c1 with SMTP id nq9csp1207814pzb; Sat, 27 Apr 2024 17:04:28 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVBsenDHge56V8nRSGKhwFWyek3EeA/Jji4L9kP4GMBVye+lMQ+N+ltR1GYyN8AjjaelH+Uu0S4cL03LTncc0q3HicnoSVbXWF8og== X-Google-Smtp-Source: AGHT+IFXsjnMQr6XyPVOl/3KB+G8y1B+6U4dA/lYzhpln+1YkSHZOMVH23bcm4ggJHyRVCzZGi1R X-Received: by 2002:a17:906:68c6:b0:a52:6e66:dca4 with SMTP id y6-20020a17090668c600b00a526e66dca4mr5440385ejr.32.1714262667722; Sat, 27 Apr 2024 17:04:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1714262667; cv=none; d=google.com; s=arc-20160816; b=bvW8x2v+Z50e/M+zUeXEIiinZt1nLcyXqlG8NNBhgkiztGjiqfCARKPTpKuEnW2DHG yje11igl5dP8qlc3EfxxhokSGxfRTSJ7BsBm8860sH+7vE2FbBGx9Xl4wf0IlDrENA6j 8UWEjnZMxA1cS325NMbFWPM5uOu8zn2P5T4yCUHai8FVPl8ByJO/siIEnIKnPYuawjer WG+XZkaqB2SXOt9miXazlUOu3aFMyU+eCgX71hw59KyZxKBeX95o2PPesMYJ1uuCtNZ2 33C9mijyBeKiltRUqqX57xCcWAm50wvst9N5zfd4Y+A+ZM00911IKyjNI0p3xVCQcVyn xFEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=Ex4JZOyDd9qNQZUvENJ4E3+lq+sngkzALSi6zakZDH0=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=lhBnyZLze1MqENB+CJLtr6IgpPtfvqlLFjOJvRJcF47BunA6NChRw+yGWbLPajtivv WjDJ+mWhKtM90h4N0oumMeb9xJJ2RfThIfHHHRJ3ASXxGPTFiqWnGGXYMljh5+XrNtph otwKQ0XiLg0qnAbT4nkyVDD3B+1UKhYuwCk9kUKdFFdU/tGzbBkXERWMlnb9PGK6vVA4 MXKQhHcbeTLR9QeGyCGvj+Z9OZR+Up3l83d1Ho2vZjNycod4aA/dfENp6yjSioctjyto 8DnefSv1BeCsiVZOpyHRDavt+aVRlfPr6dFkrHGw7HtkaEEWqELjDK0x2ynbhvsd+DjO cQtQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=WwbLAtBe; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id v5-20020a1709061dc500b00a5199ccf789si12322198ejh.182.2024.04.27.17.04.27; Sat, 27 Apr 2024 17:04:27 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=WwbLAtBe; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BC31768D41D; Sun, 28 Apr 2024 02:54:44 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 99FA268D3E1 for ; Sun, 28 Apr 2024 02:54:33 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 0D7AC240003 for ; Sat, 27 Apr 2024 23:54:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1714262073; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cBCR9vvcONBUDHCi+5SomMz6iOA545Ar2SyPDRziw+E=; b=WwbLAtBeuJSdLxjpTgvlyEUINpgKCrFDozagwWPaduNFkZAEw0fKgcEiMnhlBiuJ8qmOqa Mj720I0r0/laHgfBY2D0YgURqlw5ZIa8wfEU4ac4Zcbgfbkn4+Wl0Sl8p7DK0CCHixRNE6 Fhbi6r8Cu3xUXD5cERYhLpLZ8V//itPHu6iGc5VWJ0Mz8m4sz9DTO07mhGBHSpolXvJk9I 2epOQy4wwy9sCQGKbClUowdVLjgCUACOEzOsLsJ++OJgV/UjLJrjuzkMhSpbDtcqP90oyo B1xghgXi11l5dBf6eO8D9rw9gYv7lq0YtYrZs/vKzPUR1ew/I7N53MW3B/lpKw== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Sun, 28 Apr 2024 01:54:24 +0200 Message-ID: <20240427235424.3075968-10-michael@niedermayer.cc> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240427235424.3075968-1-michael@niedermayer.cc> References: <20240427235424.3075968-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 10/10] fftools/ffplay: Check vulkan_params X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: ydnrNzww+i85 Fixes: CID1550133 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- fftools/ffplay.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 63a9806fb80..cc00e209d52 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@ -3839,8 +3839,13 @@ int main(int argc, char **argv) if (vk_renderer) { AVDictionary *dict = NULL; - if (vulkan_params) - av_dict_parse_string(&dict, vulkan_params, "=", ":", 0); + if (vulkan_params) { + int ret = av_dict_parse_string(&dict, vulkan_params, "=", ":", 0); + if (ret < 0) { + av_log(NULL, AV_LOG_FATAL, "Failed to parse, %s\n", vulkan_params); + do_exit(NULL); + } + } ret = vk_renderer_create(vk_renderer, window, dict); av_dict_free(&dict); if (ret < 0) {