From patchwork Sat May 11 15:51:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?R=C3=A9mi_Denis-Courmont?= X-Patchwork-Id: 48725 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:1706:b0:1af:cdee:28c5 with SMTP id nv6csp196134pzb; Sat, 11 May 2024 08:52:05 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVsjpuZK76cRS6FaN5VsmBDGLJPwL4l1pitXJwCeXs7VgAheSGOp2Z3MSmYxUZtBbwX7YgeA7Km/j9IwXXzl7QQSITL4CCi1RFAdg== X-Google-Smtp-Source: AGHT+IHvWs4prsYgOVPD5zy+vpRHx6QhFyUbFpKlsBDZyv4li9ccl1NvrFOKy42DLVeyxm7I5N58 X-Received: by 2002:aa7:dada:0:b0:573:58a6:5a4d with SMTP id 4fb4d7f45d1cf-57358a65d5fmr3195832a12.35.1715442724784; Sat, 11 May 2024 08:52:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1715442724; cv=none; d=google.com; s=arc-20160816; b=yAUQbKXkOop5Hcgr+kl8oIDB1RebVjcaFtvLIx35DEY6i7egOoQABgdysXaGwxeaXL FW5k0yXosPwJcFRT+BZsH/KD2a77wafLjxwk/qzR8mz0zOZmbUA8aU59ngDQ4zvANMUj 4XFkSVXMlotjSblDbA90sdJsu5Oak3rEYUzcO3zEHmA+BUlUCA0BAc31GjogBar33qEC HirrN3U+PxyqYU7fS10+dcsrwv4enN+4lWW0FBHjaXUrxPG9hq7i/x4nAEG3WpqjH61v TuEEY9HGIFROMn7BtvtlWty2Zw9+Mk/honCDrbuV3HmiCtKWurd3Tj4eUj2EOP8SiqP6 vv2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:delivered-to; bh=ET9c4hK8Ygm8KWBobNDGiOdJty8WHFKzv076iJKXl/k=; fh=YOA8vD9MJZuwZ71F/05pj6KdCjf6jQRmzLS+CATXUQk=; b=sdMzt5XJfepe8UAxXLF5LAzTTjgg2ZIvjMrqZ25gwMbrXziISUsVzxTixojDGiyl4g deOptSM76UMqTEK1ggg75BMr8X4/xMua3mRuUMEi/Lkzr86txB5lKk+CpTwly+KHOVJE /zK21tDMurAMY3yxDnw0flDf4HbgTsNYZKDzFvxowIt7rNDN8q1+ryi51KPqcULA1hi8 wlvwLW18e338tPPsth33OiCjvFD7tVSDEyyh44NP+7AzHVSV3PkXDHP6zsSWZOZofD+6 VWKHQNZpbX4ojC/VUcZhkLHlLvaikZVZo/YdkZzgU95XSkcfQpsQUBR+bEzScCyyspwF cSKQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 4fb4d7f45d1cf-5735c9e85d7si1492894a12.637.2024.05.11.08.52.04; Sat, 11 May 2024 08:52:04 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4618768D56E; Sat, 11 May 2024 18:51:51 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from ursule.remlab.net (vps-a2bccee9.vps.ovh.net [51.75.19.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2149468D409 for ; Sat, 11 May 2024 18:51:43 +0300 (EEST) Received: from basile.remlab.net (localhost [IPv6:::1]) by ursule.remlab.net (Postfix) with ESMTP id B0D9EC006C for ; Sat, 11 May 2024 18:51:42 +0300 (EEST) From: =?utf-8?q?R=C3=A9mi_Denis-Courmont?= To: ffmpeg-devel@ffmpeg.org Date: Sat, 11 May 2024 18:51:42 +0300 Message-ID: <20240511155142.59542-2-remi@remlab.net> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240511155142.59542-1-remi@remlab.net> References: <20240511155142.59542-1-remi@remlab.net> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 2/2] lavc/vp8dsp: restrict RVI optimisations X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: TvhjWhH+jvJq They are actually awfully slow if the CPU does not support misaligned accesses natively, so only use them if misaligned accesses are fast. --- libavcodec/riscv/vp8dsp_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/riscv/vp8dsp_init.c b/libavcodec/riscv/vp8dsp_init.c index dc3e087f01..fe4fa5b867 100644 --- a/libavcodec/riscv/vp8dsp_init.c +++ b/libavcodec/riscv/vp8dsp_init.c @@ -45,7 +45,7 @@ av_cold void ff_vp78dsp_init_riscv(VP8DSPContext *c) { #if HAVE_RV int flags = av_get_cpu_flags(); - if (flags & AV_CPU_FLAG_RVI) { + if (flags & AV_CPU_FLAG_RV_MISALIGNED) { #if __riscv_xlen >= 64 c->put_vp8_epel_pixels_tab[0][0][0] = ff_put_vp8_pixels16_rvi; c->put_vp8_epel_pixels_tab[1][0][0] = ff_put_vp8_pixels8_rvi;