From patchwork Mon May 13 01:20:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 48832 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:3a48:b0:1af:fc2d:ff5a with SMTP id zu8csp61397pzb; Sun, 12 May 2024 18:20:37 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXzvkJxpz5kdFaDEQKWjNAq/T+lFkPMvzqqRyOJcOfLTn7RPAG5xdrdybLn9nqWtoi4GkRrnk02bsseaHoDTlbfoNlZFS7iawgL0Q== X-Google-Smtp-Source: AGHT+IHeSJMtnwvxg+Yjjct1v37YFAICj2Ky5OzpM/bdFcrUNpPQLpLacbnjICzXkuVqYWQfw8sB X-Received: by 2002:a17:906:1c10:b0:a59:9b75:b84 with SMTP id a640c23a62f3a-a5a2d5d4492mr505306766b.35.1715563237139; Sun, 12 May 2024 18:20:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1715563237; cv=none; d=google.com; s=arc-20160816; b=cUlRgDqTr39b/39qfddXqe7yXMNauKiXXxQZwIGVMYnsIlRWACCD6KwAhM8ICJIIJ6 Xyv6SY2POoyByl2xxq0rqLENMg39H+DVyAf15VjHVz1mxzkL7ybQBnHoNW4V6XF8T7DJ TZ26xrywm04TNd35egzDSN6Sq6fFum/AcER1O7CqBgdjp6k0CBFEkr2D+NcWsqk+jqIV kBRAggNoLS8Jxr88v3vfoTvRMrNPEMpAVuXJxCQYUmuiwZIul8iz1HJmKhLfMXrCYtZY EPJUjUWjbPCnT0ewvULobs+LFiiTyVAvvEUh2IKPDTlYO9Lme49nTev451ItnwK/u0zd 62eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=hOHQYSXzsnRyYWiCyvi3QQxetog2M02dz5S/GT8jI54=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=AYRkq+8l+CpDt95MXYZblJ0cm3i6VJTJGurbjRnbB1mnVfv296m/NAJoXekOLl1N5R 4dKvRnXKQFnd05r2UbQFyslC7PfyYT5ZaDc5Q8yRzrMZH9iECEkLxSyPmEVMOjlSFCZC ZYuwmyea/D2AdlpTNngSi5IFgr91PI4XzND1aQqgK65RZK9Tm0VJeQ68uMkY+MpMsr+U bG30oT1Aebi8KC/1yWCbNIZpk37bB378Yu9IGIWx9jbq6UEFBTaG5ZD77waudvrzezdH Zdw1af4B11QF7jXxTx6J59gzWkA3ERwusfG9/f3L0gz2OF1YppXeAIevM5mwPr5LWwvD COkw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=mi5IIuQa; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a640c23a62f3a-a5a17be669dsi447038366b.747.2024.05.12.18.20.36; Sun, 12 May 2024 18:20:37 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=mi5IIuQa; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7412068D48C; Mon, 13 May 2024 04:20:22 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 45CC568D2E3 for ; Mon, 13 May 2024 04:20:15 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 867C360002 for ; Mon, 13 May 2024 01:20:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1715563214; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fZFh++mMr7PkJOkYYBzB7uSyJpgpqO8+qOkJG+i6OPw=; b=mi5IIuQalQCF5qRjOHhW+1aCYSKbdgRddOFOD+uvAlJiAJjeeiUe6oj15mW4l/gtknafKO ROhnyXhvrQ5psYB5kYSVASXT/NCkJ5o1+SaH4qOqlY92D5TI2r01B8uc9ct42CFFYffnRb 4GAGUfieEvUSvozKft3tQtyzJXFsrdt9aPgglj/Ejn2sPlCK3/uMA4S8fUWenfmYEyMSH3 pmIIRxy7VJRfdgt/syD6Ewckt5bK6lhbyD/HxdepgaxNKW3WYrs+rd8qELagaLbD0OB4MN VcH/XcbrloY1o1BkDxcHdxDdbUxlcGDGxMUZuMd8EP/yXhid318EtGmQqz3XOA== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Mon, 13 May 2024 03:20:09 +0200 Message-ID: <20240513012011.1049366-2-michael@niedermayer.cc> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240513012011.1049366-1-michael@niedermayer.cc> References: <20240513012011.1049366-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 2/4] avcodec/pcm-dvdenc: 64bit pkt-size X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: DEQeUPBuZjPi It seems nothing prevents such overflow even though odd Fixes: CID1441934 Unintentional integer overflow Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/pcm-dvdenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/pcm-dvdenc.c b/libavcodec/pcm-dvdenc.c index 1e7ee644f66..71e9b6915ad 100644 --- a/libavcodec/pcm-dvdenc.c +++ b/libavcodec/pcm-dvdenc.c @@ -116,7 +116,7 @@ static int pcm_dvd_encode_frame(AVCodecContext *avctx, AVPacket *avpkt, { PCMDVDContext *s = avctx->priv_data; int samples = frame->nb_samples * avctx->ch_layout.nb_channels; - int64_t pkt_size = (frame->nb_samples / s->samples_per_block) * s->block_size + 3; + int64_t pkt_size = (int64_t)(frame->nb_samples / s->samples_per_block) * s->block_size + 3; int blocks = (pkt_size - 3) / s->block_size; const int16_t *src16; const int32_t *src32;