From patchwork Sat May 18 03:57:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 48975 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:3a48:b0:1af:fc2d:ff5a with SMTP id zu8csp3253308pzb; Fri, 17 May 2024 20:58:36 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVpotnPOuSrmQdG+uUPC7EGz+eC9sjToKYBQgI+BOtPSDgwQyl7piGCt8erBHJLbU2sW4YtNCT01fMeE6p3gudsdC6EQBazKFaDaQ== X-Google-Smtp-Source: AGHT+IGczkXfJefmO7tuvxoCieDOHl/LcNkES80qEIVTLbqhoTzSAZYCGL2K5bOFpr/spEQLzd7Z X-Received: by 2002:a17:906:a0c7:b0:a5a:580f:8e74 with SMTP id a640c23a62f3a-a5a580f9031mr1180038666b.5.1716004715955; Fri, 17 May 2024 20:58:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1716004715; cv=none; d=google.com; s=arc-20160816; b=gPeMTtXgwDsj4KQF+Z7m0UvaD90cq4PHbmWRmCU35ISJz1Hhlbd/4VyTiDdvIUJUBh pdrFrb759bVlYJ2V60BKQZtlgR6yJOyPCm8yD5rIidKMFsBzzr2zIyYMqc3m/+gJakdm dhvTwrEkFhRFnvsnYVoTXQMfJF5SwqRfUr+BIw80jMUT/tZULdyQipgKM+ZATy9rswWL uK4bDJ0wYE2YdX8aEAEZR2G6jEjV8UFFR5fQhanoQmjik2tYgwLJD92nXf6kK3HLiZSV 9//cvqhWBmQ0Jo6fvs9egZNXPrXncA4dpprhPBRSBFzH8c66ul9SE6uZkrHlxWEl6mZU wrZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=1emgmVsSxBAXM3iJdySEbuyniF5LGSWGmE0dCRJmWlg=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=ZROCEhBg1XcBwNLei+80QSRuo+tigxyp7+eptpwjRS8hOylPoPH6kZ9pk41PKKWp2g sT6DcqN9KKI2aY63fECVzi6C88j8H45vp31TimDkRs+uLoNxvQlR4zdFQ7IU/HRgnt4U FiV9HJL1HQxo2z57xMTJmKQz9RmwrazyFMNvEgp+HeT+4ovNJRdc2Q1pvjtLyAMfZbzL d0MjiqmOEeOIloBk1lhHKyFb7uORSginBIgk4TT5ZOol6vlN6FjQ8zO37SS49nr/C+Z2 11oqRpBGRfPzYZhayx4QbrcClF1/6OJ8ORk2Lh06fhhCWcMVy5geE8YF+iuJKSrnhfjU IxBA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=S395uNDo; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a640c23a62f3a-a5a1c9c8372si1072049166b.458.2024.05.17.20.58.35; Fri, 17 May 2024 20:58:35 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=S395uNDo; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8D04868D293; Sat, 18 May 2024 06:57:58 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8490E68D225 for ; Sat, 18 May 2024 06:57:49 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id AEAFFE0004 for ; Sat, 18 May 2024 03:57:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1716004668; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6X8ii1FNA1DJDJELRYD8nKYxoB1Pd7T2fjWm/OQQMfM=; b=S395uNDoUzeNyOwZXq9A83CHelzsWHOachWqZWdHJVu1adEDOKBREuhMjY0G5fpgG3HnIC Q6aoFK+82pvxKDNWsr7OiA8sx9nt3rYk6V0yCkzE+EVaKQ9Je2TWxi/Qgmjqu6pHCtQLrl 3MowFLoCVKZ8OaO+lem4m0zgCTTpKWyQJK7eAU3dl6Qvwxvy985SlHth+WyuqIKk72JaEC YmCSxB7lBTy9Pz6caAETLU7TSqmwDv4QOXt5ON8G3QLypY+DYjE718VUhiTzO94pOyE0gj wluiBrj2wR6ceox6iPzsEi96Dkar7oxWLl5IoDCAjTz9wymCnj7OfhNE5jQyJg== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Sat, 18 May 2024 05:57:39 +0200 Message-ID: <20240518035743.766552-5-michael@niedermayer.cc> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240518035743.766552-1-michael@niedermayer.cc> References: <20240518035743.766552-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 5/9] avcodec/vc1_block: remove unneeded store to off in vc1_decode_p_mb_intfi() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: S32OUNWfrDfi Found while reviewing code related to coverity Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/vc1_block.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/vc1_block.c b/libavcodec/vc1_block.c index 1e8e294ad89..322acebfe50 100644 --- a/libavcodec/vc1_block.c +++ b/libavcodec/vc1_block.c @@ -1771,7 +1771,6 @@ static int vc1_decode_p_mb_intfi(VC1Context *v) if (CONFIG_GRAY && (i > 3) && (s->avctx->flags & AV_CODEC_FLAG_GRAY)) continue; v->vc1dsp.vc1_inv_trans_8x8(v->block[v->cur_blk_idx][block_map[i]]); - off = (i & 4) ? 0 : ((i & 1) * 8 + (i & 2) * 4 * s->linesize); block_cbp |= 0xf << (i << 2); } } else {