From patchwork Sun May 19 20:07:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 49042 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:3a48:b0:1af:fc2d:ff5a with SMTP id zu8csp4063795pzb; Sun, 19 May 2024 13:07:54 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVXavSdeuefUTCppLmX4y6xtZQNP3CORf38dcLRTdmhagy3e23FVEm9iHNOB/LOxRgdx0H3ofrjf6r/sv+doIcb6Q5WF+u7pB665w== X-Google-Smtp-Source: AGHT+IECPkmGsbPGvOsxaB7/6jUXkDqJO0FsC8lm7Z5GkX9h1j5Zp6KSbTj7+eu5nXPeAk82i+yx X-Received: by 2002:a50:d512:0:b0:572:a1ec:1562 with SMTP id 4fb4d7f45d1cf-5734d5ce1d0mr18593791a12.13.1716149274482; Sun, 19 May 2024 13:07:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1716149274; cv=none; d=google.com; s=arc-20160816; b=fKqCtRN89gKuMGsZsawfYvrc7ENVM2aTwjdFbaxVtED4wwEoI0CTm5dawuVOuB87we UZVjZgn5IAlw14FibTXMac+EjEinIVQ9QVhZrYVKofjHvoIXxxmfEzwJn5G4tUrw4w8/ sJylfvnUNW1A4g1aEKCvlflXx6sCJF9uY98R5b7Us+8Xta2F9bEhbbdpxe5GBoDtRD98 zhVfVsC9jMjXHz2yQHIfT8t6LlBEinQblE98gVoytZmXYnj6Qz9dQjgA03AJpf+DEUB2 TDG/r3E3isWfiFl8Imc4Bnb+meGdoytwphjUMxU6tco1NZwvSGnEZyGrmixU1UNnAU0v Shsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=nT+cjT43HMU0Hki2AeA6Yek/rkDq3vKbASbPt7ggSHc=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=v1sxAliZmqJHmwrtj4KsgICnMGhn5qPKPtMJE5+eyrL5iHQp2HVljwvi3XDbCuuWU8 ydHv8kQPVshMC7onZLnyg8cXxv4s1pg0JWnpgwJgZet64cDhI7+RNmxS/7QRWBprY01e LxxHh+MpA6vkFoYegFq41jV46cF/3NqOI0lIO5sX4lU2TCAfaGSOJiTtXWQBzIvTYHi7 ZkkNn65Bmlw95t5ZOBriDsnoQK4DVYUpf4FRgLNaUp9Mf5YWabLaD/5MX3we9Gu4RNk9 mdYdYEXrRJCPyNGcriK+bc0H6zgP8j0/Bz7hCouPYxBfCkC/JLYlDqNefj6/Qmy2LfkP DjTg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=ICNyBlXj; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 4fb4d7f45d1cf-5735a4ad977si10485261a12.104.2024.05.19.13.07.53; Sun, 19 May 2024 13:07:54 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=ICNyBlXj; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5825868D097; Sun, 19 May 2024 23:07:44 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A018A68A604 for ; Sun, 19 May 2024 23:07:35 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id CBDF120002 for ; Sun, 19 May 2024 20:07:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1716149255; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AI65mqpTzFQ12L/xFrii2+xw/iHDZXQrSmDhh5YSeTc=; b=ICNyBlXjGbxYHOaUZN4j1gcH+dx/npZnZZS/d5A+TpFy543sPOpm4vABoZ6rNa0ZZPMSfe rn8vERcHK3Oa0OoqCejP0CpBRqfdyuutbg9Ag8RimlF0rJBcuVRDtXlH2A8fwrRQNbAqVv eOelz4gTDiAWiVcjWElucBAkcEvatpMZcva75uiHotTVSfLFXJbmYXpQJ3e3hZuHQubHyE tZH48apWQjUvhIvQFIRHnZ1uM29V6EgXC9HMEVbS1qbJSi9PVtiiJLX1KE/MUiuyZjGk7c YCJ7n6P02UWW3pd/vQ1f3S3zAg8cdJwwrS8LzPotC0HcvycfT1CUdk6jEQVxBA== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Sun, 19 May 2024 22:07:32 +0200 Message-ID: <20240519200732.1951501-2-michael@niedermayer.cc> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240519200732.1951501-1-michael@niedermayer.cc> References: <20240519200732.1951501-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 2/2] avcodec/tests/jpeg2000dwt: Use 64bit in comparission X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: y4olrSoV/z5D Found while reviewing: CID1500309 Unintentional integer overflow Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/tests/jpeg2000dwt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/tests/jpeg2000dwt.c b/libavcodec/tests/jpeg2000dwt.c index 6148f0dacfe..520ecc05a3a 100644 --- a/libavcodec/tests/jpeg2000dwt.c +++ b/libavcodec/tests/jpeg2000dwt.c @@ -52,7 +52,7 @@ static int test_dwt(int *array, int *ref, int border[2][2], int decomp_levels, i return 1; } for (j = 0; j max_diff) { + if (FFABS(array[j] - (int64_t)ref[j]) > max_diff) { fprintf(stderr, "missmatch at %d (%d != %d) decomp:%d border %d %d %d %d\n", j, array[j], ref[j],decomp_levels, border[0][0], border[0][1], border[1][0], border[1][1]); return 2;