From patchwork Sun May 26 23:52:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 49286 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:542:0:b0:460:55fa:d5ed with SMTP id 63csp2958822vqf; Sun, 26 May 2024 16:54:05 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXuNbnFH4B4byujP1M/8Pm2hZm88xUIeVL0HrTFdZ+5ZuFAQK6yOgozV/wjX4q1GX4afQFu6BUdhGgq9QIFfG1Ix2A7F9znA06ABw== X-Google-Smtp-Source: AGHT+IE0blfwWIs5oK6IHgWftfRPHtwLJAgMX1o4cZLe5nB8HPuRvwqD5phVZPz4LCpBh2SsON8X X-Received: by 2002:a05:600c:6b04:b0:41f:e7ac:cc72 with SMTP id 5b1f17b1804b1-421089f9a09mr56201395e9.40.1716767644762; Sun, 26 May 2024 16:54:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1716767644; cv=none; d=google.com; s=arc-20160816; b=lbBM/j/cM4OYTLFEkwHJNVEZOhVvid1k9xSNjOuSboFINXIVcLtDZqYirYT8BzzG6i Gp09xzQurP1jBDBzg5cmu/eR4NozCTRMHUV8ZQjcIcAPIJ2D+VuSzctFGSsz/WV2FD/M i+cA/4M25z9MSHPi8Ju/r8cz/6a1znP4tjeIhC/FH6MrfGgCCeWxRL92WNRSFfD8CTI7 WDr3BGmEbUu4WrFF/vHJDJ8bMrUahnr9eIV2rbbplIf6etSJDW7L+VIKNvQLxkGWyh67 vFucwZXsrrmfLgcMVB8CLqeCEdMCl7kKiKh5Eplv7UhSrJa8QapgewkBOBwXuB5ijaLr Vlzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=CB4qiIfTCZ6SfjA77ZjuoTMYngI00bSu0T1MDzk1J9I=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=J4IHwk6Y1V4yOreMdHn3x5AVpWeXxEkPQnWb+9F4Qv+ePb6p0sqwdxZX5w707Ajau1 Sn1u5KVg5FiG7j3VBipg7vRjRR8MO514fu94R3UG5vk5b5vVItOBQDiTNSZn7tJNOdAo jLmx2ITYCw9i6h/WvET6Y42coxjaOEy1VlipA9ZzjNe85a8n3Mb3rPZi5pfL71ryVqpj SI/TE1mRtKCaZDTwoBW24g8M7VU+4gk/ulicQF+eJrRCPQgmI/6OqaSEQZ+OcjtDf2u2 UoVT4tvCJMDdUBy2j/e3ezovf0rKtFbjkzHceZd8EFuv6BMnYeTstpNhgIOwn+o61tMF /rlA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=Gz5BqQJi; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a640c23a62f3a-a626c801234si329137866b.119.2024.05.26.16.54.04; Sun, 26 May 2024 16:54:04 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=Gz5BqQJi; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AB72968D5BE; Mon, 27 May 2024 02:52:51 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8B4AF68D1C4 for ; Mon, 27 May 2024 02:52:43 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 7961D1C0002 for ; Sun, 26 May 2024 23:52:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1716767562; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PMu+pXVwkJ28lIe9LqEyDSiEYWV0LDKZMmSs2LDyeoc=; b=Gz5BqQJiUbUcBvUnYMp36XiKonz3BnOtF8pE04/13+WgzO6YD9ncdJLK2HNMabO8WDaecd cmgz+BeFAkx96dV8IRnJ/PUgXdtHbYAl9DfiKAUUIrhAQl0a96NfA86/eMjMtOjN14rYbi hPYFPF2g7mTuKTUdUOQ7b8E6a0DrbkHn7R2K2gzbEHQR6mU0boPw+ZeINGHgcfvNwc1COR 8kYkDz+nq6gGj1r6KyzpDnxsjfZkQm04HYC5xMfuFvNXrwHyY1Rkd7RcWzi+BcjiIe21g4 iGTC+p1lF4irgOZ9aFKAM2QYNCRdjQe3y4QpMQkTS+1564w7Zc6s+p+7GuYT9Q== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Mon, 27 May 2024 01:52:25 +0200 Message-ID: <20240526235230.2876318-13-michael@niedermayer.cc> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240526235230.2876318-1-michael@niedermayer.cc> References: <20240526235230.2876318-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 13/17] avdevice/dshow: Check ICaptureGraphBuilder2_SetFiltergraph() for failure X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: WNH4d9EOm+L8 Fixes: CID1591939 Logically dead code Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavdevice/dshow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/dshow.c b/libavdevice/dshow.c index 911b0ecc078..557cf33161e 100644 --- a/libavdevice/dshow.c +++ b/libavdevice/dshow.c @@ -1465,7 +1465,7 @@ dshow_open_device(AVFormatContext *avctx, ICreateDevEnum *devenum, av_log(avctx, AV_LOG_ERROR, "Could not create CaptureGraphBuilder2\n"); goto error; } - ICaptureGraphBuilder2_SetFiltergraph(graph_builder2, graph); + r = ICaptureGraphBuilder2_SetFiltergraph(graph_builder2, graph); if (r != S_OK) { av_log(avctx, AV_LOG_ERROR, "Could not set graph for CaptureGraphBuilder2\n"); goto error;