From patchwork Sun May 26 23:52:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 49285 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:542:0:b0:460:55fa:d5ed with SMTP id 63csp2958797vqf; Sun, 26 May 2024 16:53:56 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVJkFbsLkfKgF+FYiMTLW3PJ31y2ukqDMQc3JxKxapGvZQZIt66YmQpjilKFqI0/Cz9Vd2ygoIHs0zg9IuwyY8J8+BNCIqbmUxVkA== X-Google-Smtp-Source: AGHT+IFnWbV5bRGiRn2RAL+3XqTe7SMaj/jkKC/YUkNguqVjQ/d8FqaPICBOpVvFjcYlsF8ou2Rg X-Received: by 2002:a2e:300b:0:b0:2dd:374d:724e with SMTP id 38308e7fff4ca-2e95b0bcd82mr47090221fa.1.1716767636423; Sun, 26 May 2024 16:53:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1716767636; cv=none; d=google.com; s=arc-20160816; b=g1yaQSYVVY05hDgYOxlvbyLR+wZWiB7ei74tMpukQAzCqwqBEV1rwVNYtnjmwOvriv 9jof80TwdYij4QrM/Rij6bMkStJwAf9uxIRvxsmt4oYxZCa5iVDlwjz0H+wBNR3RV5PG 37VBDc8KnnLKolNgxuNPqy7J1TyaM4GLzuduwxBk6hYg8R1za6+ORwy4AVVfbGddR9kX ZrV5N+ADbGqEGRgnQ5MaeVSne3IvcnEydAFleIpD8wlfCnCChz7s0La/DcX4FWhefU7l ipSoqU9bOdf1bxf2fkqW9w8UOAsCGAIgPL8kyD17JPv7HfXVrX4iOSG2EFpo/OCuRWL9 ErpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=mkmlNDzyziOLfy3TVRMpag9l0SDCPk/+SSSDpzBtHzs=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=FH/bCcF+vlb4MWVj+0Rm0KQ9LdXHyz+cfwhOU35KCX9CovSr8ZnBZdgU6uE+EjY6TD W4L0uhker3bc5FVPM68KnEefKhGDo+LAMOS5xTMmk4sm19Cktm85ypzf2jNSLhVdNFtw 55x5QhArh2Z9999y4FsiUkoEQ21OMmrYfkP8u7/vlTOePZbi2C67GT3kSTpEfE5sfqGo mcSE2TAfz/Zx9FX607/Az/SNGut6Gc7kNhmjY+RH8OMN8PpVd4v0q/oB0giTv+AFUPrt OjLdczb++lyhvzcLkHOHHCGFjDx/HBIEk+oIA8VAGbqsfO/9EHHqChZScvsMdgL2+psf pV6g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=KVlz9D9M; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 4fb4d7f45d1cf-5785249777asi3394329a12.395.2024.05.26.16.53.56; Sun, 26 May 2024 16:53:56 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=KVlz9D9M; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 81FB868D5B9; Mon, 27 May 2024 02:52:50 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BB0F468D521 for ; Mon, 27 May 2024 02:52:37 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 22E781BF205 for ; Sun, 26 May 2024 23:52:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1716767557; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lnyM9/rm3ObWEwXhD+pOtS5wvJUz4beKbLfAFRETQSU=; b=KVlz9D9Mki2z/2zqvZzln9h8Bs4Owb5haPLk9cIoM4iad8dVYpaDmh/4fL6s23qN76NR7v SIzPPKkZ9FgrIXdvMbsFPsWfyIKPeiDhIuCqPGXQ+Z0C9ElMUAWTIoUxDfObWkyfCnFMje 1FA4d7G5mwqFpu6TlRWgszRo2mNqo6w2z68/3nIByCw2WoezDvNs5Coecli7eOtzuEkpLH XBiBWBFaIqagPLek/FqW33WsrgFgeYkRNqn1nXzyMyeA3V6w+S+DsGzABLhYzLsJlz7LFy RdOoghwJLFhPkrtCNXazruzYCrFwtRZjtTmvl1dknwLeo9Z+RynOMbZjVukdNA== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Mon, 27 May 2024 01:52:19 +0200 Message-ID: <20240526235230.2876318-7-michael@niedermayer.cc> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240526235230.2876318-1-michael@niedermayer.cc> References: <20240526235230.2876318-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 07/17] qsv: Initialize impl_value X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: ddwJGWHh7vC/ Fixes: The warnings from CID1598553 Uninitialized scalar variable Passing partly initialized structs is ugly and asking for hard to reproduce bugs, I do not know if this actually fixes a bug or just avoids the uninitialized fields Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/qsv.c | 2 +- libavutil/hwcontext_qsv.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/qsv.c b/libavcodec/qsv.c index 6bbfe2a5a95..0c6fbd0dc09 100644 --- a/libavcodec/qsv.c +++ b/libavcodec/qsv.c @@ -496,7 +496,7 @@ static int qsv_new_mfx_loader(AVCodecContext *avctx, mfxStatus sts; mfxLoader loader = NULL; mfxConfig cfg; - mfxVariant impl_value; + mfxVariant impl_value = {0}; loader = MFXLoad(); if (!loader) { diff --git a/libavutil/hwcontext_qsv.c b/libavutil/hwcontext_qsv.c index f3d919daea1..7cec3474786 100644 --- a/libavutil/hwcontext_qsv.c +++ b/libavutil/hwcontext_qsv.c @@ -839,7 +839,7 @@ static int qsv_d3d11_update_config(void *ctx, mfxHDL handle, mfxConfig cfg) IDXGIDevice *pDXGIDevice = NULL; HRESULT hr; ID3D11Device *device = handle; - mfxVariant impl_value; + mfxVariant impl_value = {0}; hr = ID3D11Device_QueryInterface(device, &IID_IDXGIDevice, (void**)&pDXGIDevice); if (SUCCEEDED(hr)) { @@ -913,7 +913,7 @@ static int qsv_d3d9_update_config(void *ctx, mfxHDL handle, mfxConfig cfg) LUID luid; D3DDEVICE_CREATION_PARAMETERS params; HRESULT hr; - mfxVariant impl_value; + mfxVariant impl_value = {0}; hr = IDirect3DDeviceManager9_OpenDeviceHandle(devmgr, &device_handle); if (FAILED(hr)) { @@ -995,7 +995,7 @@ static int qsv_va_update_config(void *ctx, mfxHDL handle, mfxConfig cfg) VADisplayAttribute attr = { .type = VADisplayPCIID, }; - mfxVariant impl_value; + mfxVariant impl_value = {0}; vas = vaGetDisplayAttributes(dpy, &attr, 1); if (vas == VA_STATUS_SUCCESS && attr.flags != VA_DISPLAY_ATTRIB_NOT_SUPPORTED) { @@ -1036,7 +1036,7 @@ static int qsv_new_mfx_loader(void *ctx, mfxStatus sts; mfxLoader loader = NULL; mfxConfig cfg; - mfxVariant impl_value; + mfxVariant impl_value = {0}; *ploader = NULL; loader = MFXLoad();