From patchwork Sun May 26 23:52:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 49289 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:542:0:b0:460:55fa:d5ed with SMTP id 63csp2958940vqf; Sun, 26 May 2024 16:54:30 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCX9WA3O1doCZsyg/R/6iuwOr7lTmyC+4c9B0X3Li5ViJcqn51pzPn0F9GlM9poP8WEkjzACDSIVJtyxa4Cr5rzRJUZyHOhYwlMvYg== X-Google-Smtp-Source: AGHT+IGrSHOAYzsfqVdl5nhI29cSKt6wHt0tqgWdQFfIii/ghqWe37h7rjcWVKCyomnME0GhmyZ9 X-Received: by 2002:a05:600c:19ca:b0:41a:3b7e:2235 with SMTP id 5b1f17b1804b1-421089b1b42mr59515225e9.5.1716767670512; Sun, 26 May 2024 16:54:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1716767670; cv=none; d=google.com; s=arc-20160816; b=BWZf6cSUvC/gxXAWx5a7H4oD946lK8gKf8BXpoPBvgFDQlmZuxlmFZ2ZfLUeRu4vmG tuowFfOobgq2k/Jac4lvxRKYyHBCEY7UYNy/8uhSB/jLgmSDb1ymNfP+9KjhgUEZPmzt BikES2feVRTGdmY5fcXYPyckDPJQFxjR+JQ2V3dqP5IvmvWWcj0FF+G1rBUTbFSw6OZ3 sI4yB9bteWvOGFWQoJTMZUhHSgwBJYv401xP0l0g86Dqloi9xhJ3NruBIqRA2BoIQTZc ymw9w6H74LfeYIT+hHWvZg+EHucBKZGPgVqwN3Cm+QRcoXk05cLcETcT8UI0nvhQEPna W05Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=FrArkYVFhkOju9KdcKk/1/u6jyZ1BpPa6QSkRlK8YoY=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=JNf1N9pv2fk/02hP0sEHgdhucMr53ALoq8bTvwNLooijecS60gncBBUjikS0hBc2XS BETGdfxl3JmSECznP9fQNLQHurulC4nhjTQMlxJpzilOlFxM3JqCoRkt1uTMPuK2gxPk bOT6+diXGtet8+pRh0U5Ym/ecZB6GGr17dtgMppIqnvbFCCIAk5ZFuH+9iBL8o7a3hU/ zShRMdXfAiFWpLIRv236rygLlZNO/c8wj1WBCX3FqLzG+Ugk+YiiCipMdYCmIKq81Wwl 75u5oMIxfnFk9lpdnJEP3U/EGvRh//NHSUv+1nbjqxx9Wo1sL5n3Vucxf4fnYKpwnKrx 9Zdw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=QluydzoS; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a640c23a62f3a-a626cc372c0si332435866b.290.2024.05.26.16.54.30; Sun, 26 May 2024 16:54:30 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=QluydzoS; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D6B1768D5D3; Mon, 27 May 2024 02:52:54 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 57FBF68D504 for ; Mon, 27 May 2024 02:52:39 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id AB1401BF206 for ; Sun, 26 May 2024 23:52:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1716767558; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2yQh9/q/kkKbZDA7jIeCQQmVhEkwiSH0Xl34sBjsMww=; b=QluydzoSSZ+9P8xHZpyKAc/Fb3GCvXwmtWZ6bNZ5A2JYHg2RrBcmJSK2RjTDb2DeFl4DeU CoOgrsmaAKvWm8fjsuUJ39TKANh+cUNl0tcz58JjW93CWm/4O2r3XPoO+oLDUMEi9kd0VP D1uuaIGf9XCGILoQ5S8cl1mailkoRocmi7Nh0M8Q1OM7lFf1v0wofOnvNw+ghn4Qgq+CWH wR/cL78E0bFHF26hMcAIqbsZAx41WLEciJM2NEzR8EHD5YKmcSBwdvddJm8dD90a1FRk7g C9e5/HrdEcStZM5BNvkFnpF1/WHS+CBXBOij/GlG6YtqAHtQN3e/fR0Mfco4pA== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Mon, 27 May 2024 01:52:21 +0200 Message-ID: <20240526235230.2876318-9-michael@niedermayer.cc> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240526235230.2876318-1-michael@niedermayer.cc> References: <20240526235230.2876318-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 09/17] avcodec/vp8: Check cond init X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: Ylpgx6Rx7wmY Fixes: CID1598563 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/vp8.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c index 3e1f67172ae..d6df018655c 100644 --- a/libavcodec/vp8.c +++ b/libavcodec/vp8.c @@ -252,7 +252,11 @@ int update_dimensions(VP8Context *s, int width, int height, int is_vp7) free_buffers(s); return AVERROR(ret); } - pthread_cond_init(&s->thread_data[i].cond, NULL); + ret = pthread_cond_init(&s->thread_data[i].cond, NULL); + if (ret) { + free_buffers(s); + return AVERROR(ret); + } #endif }