From patchwork Mon May 27 13:33:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Diego Felix de Souza via ffmpeg-devel X-Patchwork-Id: 49294 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:542:0:b0:460:55fa:d5ed with SMTP id 63csp3267996vqf; Mon, 27 May 2024 06:34:38 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXEA0N0evlz3oeTlKI8C0rO8BwspuwN8SePXC7bjeku8NjQ1bI620HiBdsY0PadBEUSHgE2eC4LZgM5T2GvZguU2k5PfSu1d6y2tA== X-Google-Smtp-Source: AGHT+IHQ5IA1P+jrXxwO/f2B2sd2PW0PTBKXh1wGVKXOaVLVyHOw2r8ypizJvp8vuN4bXE+wO97V X-Received: by 2002:a2e:be13:0:b0:2e4:9606:6b86 with SMTP id 38308e7fff4ca-2e95b0bcdc5mr83942371fa.8.1716816878270; Mon, 27 May 2024 06:34:38 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 38308e7fff4ca-2e95bcccca1si22063631fa.34.2024.05.27.06.34.37; Mon, 27 May 2024 06:34:38 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3292168D4C3; Mon, 27 May 2024 16:34:35 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2065.outbound.protection.outlook.com [40.107.243.65]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5CF9168D29F for ; Mon, 27 May 2024 16:34:27 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T6WCZFEtHPV+In1APuo3eIeJuL4BReGgzu+4jfyMRw2xdFovyqtJA6elBUYspLpWKONyr5QeYm+hhx7+IoydbyVojiMNiCnZ0kuGLwiQ19BsvtgLntIpwJggLpFL+zaTrVvr8Kw15suwcvqmBWfq6s+gyh6f40ey0RNHVo/0/0gTkq8GRavpJN71/niaZ2J8GAwxnYsP6HS46Nyd8lHNiSyyEaYVgZkm1D8kCbvFHpEQW0+oh/VnWeQiigu8j8MmtlFF9NogA6nGCesvT+za9zMMIwwNZqfN8/3Nzz7LAsh3Os7KTH2xqCIXFWf2jTBCUqLmD59FodTzDaFuxoLplw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nsYOFGl4Rvm1qohTgo89KnWzIKIVdOE2z54ZA2FB6wY=; b=KaA2dyrvh0PQSeM1GtAQdFJ1My8TOY4cwxhH2z8nHVOM1++/NshEteHvTswaY1yrNMVgyq1I0uQZEwciYuVvXfZTXQkqzi954NEQ4rpgZssj8JXrRj64p92xZepZYow90G+EhCaxfvBX1xKVC45HOm9GztQA3m1I+eWlsMalVB11a/YxHIsKsaM1C7Jw++ur9AGRakk6FlRSgm6sXL/T2cJij23JLcQ9wIcr7q4k86IQO8Kch45mVYtAz55Wuymx6HZVsZWvxKA6rKRSOTjdycgl26cYX4kYLMUXqqoMV5N2/3U9+FPIK3A6qumdgneyhuuS31HI8Ql2NithCmxZzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=ffmpeg.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) Received: from CH5P221CA0019.NAMP221.PROD.OUTLOOK.COM (2603:10b6:610:1f2::26) by IA1PR12MB8077.namprd12.prod.outlook.com (2603:10b6:208:3f4::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.29; Mon, 27 May 2024 13:34:19 +0000 Received: from CH3PEPF00000010.namprd04.prod.outlook.com (2603:10b6:610:1f2::4) by CH5P221CA0019.outlook.office365.com (2603:10b6:610:1f2::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.30 via Frontend Transport; Mon, 27 May 2024 13:34:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CH3PEPF00000010.mail.protection.outlook.com (10.167.244.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.15 via Frontend Transport; Mon, 27 May 2024 13:34:19 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 27 May 2024 06:34:05 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 27 May 2024 06:34:04 -0700 To: Date: Mon, 27 May 2024 13:33:44 +0000 Message-ID: <20240527133344.78820-1-ddesouza@nvidia.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000010:EE_|IA1PR12MB8077:EE_ X-MS-Office365-Filtering-Correlation-Id: 4adf1788-0676-4925-3871-08dc7e51b65a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|36860700004|376005|82310400017|1800799015; X-Microsoft-Antispam-Message-Info: yA/JTOi8vyWI/60CDSvdCEwro+2zm0tWC0Ny6X6Sdory5pDO3UsbtSS7Jrb7b+cD/7xX9AdB/RuTh33p7j8+exfXGCDK8QS93KyDOeY0t1iTYZb3UMZ/9hIgUiB7ULSUrVIQ8WABUgiqdzzEVxqexrDFbXgOOruuf3a72yLOyeRGrYmNEm7H74cQCsZaS5yJXQDGvvnyj0RouOicBIl9WHQY8Ik0go+DSB1U2ArjIzxArHEO56TWcLBm1NNUEBkKcOLGkzQ7u+6MFMcz0YEwbNsRhdkVxufl73B5HVOSNduBsRS8dtVLG/gAfwYC42DILaJh2w6TZ5fBoX/MrOm+A8wBcK41trEeVgZZvg2uBJ+A9/NgfzZkmZ6e3X13l723pbQLRSSdQVgr3ijU2PKAeiYkuFGY1mXRAGXr7/uWQPR6DxLSsXcCycszRhNAohDJylAxNKeECdPS/dfMhF3ruYARHPzDzQ6fSmIaBGul2V24yH6p6Bo5afPGUglyGHE/0MdA7b9lITMOeqaP3/jkzr0BCTJz4KcwqOV6bc2XcICC8kYMehu5wHf9jAVH7+pvCTEu1OjUsc2Ya/dLDIb6TNogTNolI6/4zngHGiZbvxt9ulEqI0o2upy/+4ZhjnNXqys89ydvNOBeVG31LX6bT8yJM//aFEcsphqh2wBm7SHx8sO0ru3kT7ePo60gCqXAhZ+g6T07+KpGiYAC51Y0wulFjRikQBiG6VWF8YoIDfjciDV98REo4JstYPT4EofkiXUsZVbQGgZ5PPcJg2v4TQufCfqN/W57dNFReu81Fahy2vT3qU0GNVqpXp52DbPNP+mUYb/bVPJYap8hkQ6vZK4XFtZnIszDjbY3+RCx7dw0CVPOS3yHT80U1it553XD0/EPMtn8nNmar9c+dl9c+fNquFc+9qE9xl3ARoU4W3UbH0CEZJR9M/Ys0JSBcBayuG6W8zCL/qlC6s44BWp01dWYMOnR7euyn4k8KRRL2uC6UrH46VPoFIplum1RTDj55jSN+PqPNWDiZF82CHCB9Qdm5ATXfWx9iYmHLW32X7uJkGPaUZS0FtRrM3s8U3z33RzF2PsjzQe7x1+J+DV2rOJ0i9SOG52UUcYX3UuXDJUxVgC5I31P+uMn2i+WpEMBcCgNhW77Rsr7isNygnsxtew5jTLn4FVacOlr0jKw0+TAzx4CGkWin0yU8JyNCkRp4vKQA2AVaQ5Ffwv3Cm+hKsOIsEo5xIkhjze29quR18eFy8t69O8HGxa1A4NInOMHOtq7U07uYK38Sn/SYD9yr7CZrqKl3y3GWadkF6NQJjgntyRR74mFqYdZI6dhJdQbNSDK2MMziaTcZ6prKrX+jdiqkGYov4sjm+PLpjlimxPP2pI+XSOAkLWrRAjAtfBx X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(36860700004)(376005)(82310400017)(1800799015); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2024 13:34:19.4708 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4adf1788-0676-4925-3871-08dc7e51b65a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000010.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8077 Subject: [FFmpeg-devel] [PATCH] avcodec/nvenc_av1: Correct CQ range for AV1 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Diego Felix de Souza via ffmpeg-devel From: Diego Felix de Souza via ffmpeg-devel Reply-To: FFmpeg development discussions and patches Cc: ddesouza@nvidia.com Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: Z3eo56R2xTk0 From: Diego Felix de Souza The Constant Quality (CQ) range for the AV1 codec is actually 0 to 63, contrary to what is stated in the header and documentation. Signed-off-by: Diego Felix de Souza --- libavcodec/nvenc_av1.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.34.1 ----------------------------------------------------------------------------------- NVIDIA GmbH Wuerselen Amtsgericht Aachen HRB 8361 Managing Directors: Rebecca Peters, Donald Robertson, Janet Hall, Ludwig von Reiche ----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ----------------------------------------------------------------------------------- diff --git a/libavcodec/nvenc_av1.c b/libavcodec/nvenc_av1.c index a9e065e3b9..ca15ebddba 100644 --- a/libavcodec/nvenc_av1.c +++ b/libavcodec/nvenc_av1.c @@ -105,8 +105,8 @@ static const AVOption options[] = { OFFSET(async_depth), AV_OPT_TYPE_INT, { .i64 = INT_MAX }, 0, INT_MAX, VE }, { "rc-lookahead", "Number of frames to look ahead for rate-control", OFFSET(rc_lookahead), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, INT_MAX, VE }, - { "cq", "Set target quality level (0 to 51, 0 means automatic) for constant quality mode in VBR rate control", - OFFSET(quality), AV_OPT_TYPE_FLOAT, { .dbl = 0.}, 0., 51., VE }, + { "cq", "Set target quality level (0 to 63, 0 means automatic) for constant quality mode in VBR rate control", + OFFSET(quality), AV_OPT_TYPE_FLOAT, { .dbl = 0.}, 0., 63., VE }, { "init_qpP", "Initial QP value for P frame", OFFSET(init_qp_p), AV_OPT_TYPE_INT, { .i64 = -1 }, -1, 255, VE }, { "init_qpB", "Initial QP value for B frame", OFFSET(init_qp_b), AV_OPT_TYPE_INT, { .i64 = -1 }, -1, 255, VE }, { "init_qpI", "Initial QP value for I frame", OFFSET(init_qp_i), AV_OPT_TYPE_INT, { .i64 = -1 }, -1, 255, VE },