From patchwork Mon May 27 16:01:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?R=C3=A9mi_Denis-Courmont?= X-Patchwork-Id: 49300 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:542:0:b0:460:55fa:d5ed with SMTP id 63csp3359576vqf; Mon, 27 May 2024 09:02:11 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVEMiVU8p3XeQL9i1uFJya6xc77a+Bh8xf6WkW8Xif+dX+di154WS/a+ErWd8vMmwPBXGm+zlfLima6vqCjgo4n7WpPMlotyfMzUg== X-Google-Smtp-Source: AGHT+IGfFGchKAnhnrRh5HM6IR0PWCDe7bW1TzIR8sfqPLLlRsemA5UMaqD66bKYSMqT4z7yEM6f X-Received: by 2002:ac2:5f92:0:b0:523:94a3:26b5 with SMTP id 2adb3069b0e04-529677474ffmr4781646e87.5.1716825730422; Mon, 27 May 2024 09:02:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1716825730; cv=none; d=google.com; s=arc-20160816; b=hfbqQrYkPn2c0Ca1OlCXm8UcseaguX6dThKnC3cHbulWKCQGRaYtFdlNUHyqN+28Yv r+n7TeOr0s0xe9FtU/vIIsxKG6/JGN5egDPZRZu7mtwXVR+6gzG5YXPwRrv0QEDm9M9S SJtYaWDH5uVmBbAGPxLZ63tD+FwtiCtR3sVLqLGWiPlYu1lMTi04vNAZF3i28mOpFcXv 4NwbyF4+LCJGeAbkwA+If3kxgIBUYRRSuh2R0jDnDb7mo3afosVSsmpTp+6lhPSD/Gau 8teXLNRX+OtKv+gogG93hZYLkPU+Hjq0tUZ4Rh3EwM9tCrZoUYVPGIDs1gBbfKa21MLm Q5mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :delivered-to; bh=gK+fwZpbcisS+9/KXm6MsqzwWQRvAptS7ik1vnOq7ds=; fh=YOA8vD9MJZuwZ71F/05pj6KdCjf6jQRmzLS+CATXUQk=; b=appbmPu8rkBC8v4NO8MEJmXV0MY5M6az+gtACT7fBfQlgDZWUKXlWSfT2cIorigJpK u9KHWalXbpZpwv07lwpYAnDOMBaPiup8tE2l3iNQqPdu+P7i4YoBmjh7q/o2+aX7KoB2 tPAQbeQlKf9CAmgcfGnL9vjA1suvccOzdrKjoQ4uYg5NRXFOQLVITJ0Hkehkl6WjOcuw O2ByuVKh3WWZhAHJ08o+HgFKPfasNbN2Ho30dfEq8oCsbR1ktdMwEYMO2Lex+Hig2RKK pQMJBu8UA5T+ZYCXCjflTrJfUpeaW+PxKFCGVkQaVzHmVl8fN3q39zwTsEdCzyYZYF7K IIcg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a640c23a62f3a-a626c801021si399697166b.53.2024.05.27.09.02.09; Mon, 27 May 2024 09:02:10 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 057C868D414; Mon, 27 May 2024 19:02:07 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from ursule.remlab.net (vps-a2bccee9.vps.ovh.net [51.75.19.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 864C2689BA8 for ; Mon, 27 May 2024 19:02:00 +0300 (EEST) Received: from basile.remlab.net (localhost [IPv6:::1]) by ursule.remlab.net (Postfix) with ESMTP id 015D3C0069 for ; Mon, 27 May 2024 19:01:59 +0300 (EEST) From: =?utf-8?q?R=C3=A9mi_Denis-Courmont?= To: ffmpeg-devel@ffmpeg.org Date: Mon, 27 May 2024 19:01:59 +0300 Message-ID: <20240527160159.750956-1-remi@remlab.net> X-Mailer: git-send-email 2.45.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCHv3] checkasm/lpc: test compute_autocorr X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: N0AO/n11nERW --- Changes since v2: - Scale the error factor to length since this computes sums. - Check the last element from results. - Use fixed vector size for benchmarks. --- tests/checkasm/lpc.c | 51 +++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 48 insertions(+), 3 deletions(-) diff --git a/tests/checkasm/lpc.c b/tests/checkasm/lpc.c index 592e34c03d..22e5001ae8 100644 --- a/tests/checkasm/lpc.c +++ b/tests/checkasm/lpc.c @@ -16,6 +16,7 @@ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ +#include "libavutil/avassert.h" #include "libavutil/mem_internal.h" #include "libavcodec/lpc.h" @@ -30,7 +31,7 @@ } \ } while (0) -#define EPS 0.005 +#define EPS 0.0001 static void test_window(int len) { @@ -57,10 +58,47 @@ static void test_window(int len) bench_new(src, len, dst1); } +static void test_compute_autocorr(ptrdiff_t len, int lag) +{ + const double eps = EPS * (double)len; + LOCAL_ALIGNED(32, double, src, [5000 + 2 + MAX_LPC_ORDER]); + LOCAL_ALIGNED(16, double, dst0, [MAX_LPC_ORDER + 1]); + LOCAL_ALIGNED(16, double, dst1, [MAX_LPC_ORDER + 1]); + + declare_func(void, const double *in, ptrdiff_t len, int lag, double *out); + + av_assert0(lag >= 0 && lag <= MAX_LPC_ORDER); + + for (int i = 0; i < MAX_LPC_ORDER; i++) + src[i] = 0.; + + src += MAX_LPC_ORDER; + + for (int i = 0; i < 5000 + 2; i++) { + src[i] = (double)rnd() / (double)UINT_MAX; + } + + call_ref(src, len, lag, dst0); + call_new(src, len, lag, dst1); + + for (size_t i = 0; i <= lag; i++) { + if (!double_near_abs_eps(dst0[i], dst1[i], eps)) { + fprintf(stderr, "%zu: %- .12f - %- .12f = % .12g\n", + i, dst0[i], dst1[i], dst0[i] - dst1[i]); + fail(); + break; + } + } + + bench_new(src, 4608, lag, dst1); +} + void checkasm_check_lpc(void) { LPCContext ctx; - int len = rnd() % 5000; + int len = 2000 + (rnd() % 3000); + static const int lags[] = { 8, 12, }; + ff_lpc_init(&ctx, 32, 16, FF_LPC_TYPE_DEFAULT); if (check_func(ctx.lpc_apply_welch_window, "apply_welch_window_even")) { @@ -72,6 +110,13 @@ void checkasm_check_lpc(void) test_window(len | 1); } report("apply_welch_window_odd"); - ff_lpc_end(&ctx); + + for (size_t i = 0; i < FF_ARRAY_ELEMS(lags); i++) { + ff_lpc_init(&ctx, len, lags[i], FF_LPC_TYPE_DEFAULT); + if (check_func(ctx.lpc_compute_autocorr, "autocorr_%d", lags[i])) + test_compute_autocorr(len, lags[i]); + ff_lpc_end(&ctx); + } + report("compute_autocorr"); }