From patchwork Tue May 28 15:47:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Wu, Tong1" X-Patchwork-Id: 49315 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:8f0d:0:b0:460:55fa:d5ed with SMTP id i13csp53734vqu; Tue, 28 May 2024 08:50:10 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCX5hTCp0PQPmHVymZ62WEUPCVw23I2IhlTdy9PdqLLgy4uhSGA5vI/HEs/6FnsizNVuOm/p1Tv+luVJN0ccXOiVS48hYP7oraQioA== X-Google-Smtp-Source: AGHT+IEx4fmkREoiEtjhzons0e0WNNPT0txmPE5NLvSd5N8rdYStR+tpw4HzDtxu6bUeBIH+ckLA X-Received: by 2002:a17:906:6944:b0:a61:a705:56f3 with SMTP id a640c23a62f3a-a6262b1689fmr978106066b.35.1716911409956; Tue, 28 May 2024 08:50:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1716911409; cv=none; d=google.com; s=arc-20160816; b=HTwPOMPV/P+pEm/MdyuQVCnMZV6EmSGnG9rFfCXbRdAVZV2fUXXBYNPlL7q18QClz6 tg6+UXmT56CKBSN1y6sGejkQGCI+k8SGsAB/bMH2XHX2e2/B7bIvgtPtxkkvH9I8QUBw o7tPGU0/51alEikMh80seBnXLo3PUOqn4hxgmmftBCGfUPcHtAVedHwudAWZH//I+fLT b3aIGGkdLCf9vp4nBnhUvpDuZjpBz7y0KOUnWmmisi3+InHSHqLa2cfRTxkP51CyTxpc Zhd1ndVTEmo20wXBtPwMPAJax/hwbBF6T6hnXObbA3TQruZte9jFA2aJnwusynAztHSh wu/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=fUC/QkbNIblpm1WCX4q8WApRPNu2PvGGzlGKcaK7dqk=; fh=CX/m9qTuMDwrotqtm4RkAOJT6yXlKL2vcfWDitFPXZs=; b=tKfUlIXnajeJdqr+RseQz9hDHZPU4bNoxl/NtfYFhupTAH1hZ/bWN+nyqJzstYPNhB 2nN+VJ8meiGRPhaUhUCYhmNuKlw/0FW/0buS5gD/hwqPRll8iIW5dEJyTPkqWzB2Ofss IXkimCaPmyn5/yY2JqpiX88yaaProM6AsGIPqmhelAnE7bIJZFMOY8bsG8s0nN9+SRr/ UENg0gH/wphkXbNeMEDJOdisnf65IDdmd+wsVGdArXHnXVYWs385tQh/lDeAhzHlb71Q DQqbXaAEJDVq0NmmEpGVAqZOWeEsE+GY4tjuJRY6YX5Tif1fk04IRjZmR338WAFMiIGv qzcg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b=mjhzpt1P; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a640c23a62f3a-a63480181b9si81495566b.342.2024.05.28.08.50.00; Tue, 28 May 2024 08:50:09 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b=mjhzpt1P; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 539F868D4A6; Tue, 28 May 2024 18:49:57 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3CA8B68C094 for ; Tue, 28 May 2024 18:49:49 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716911395; x=1748447395; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=aDP6lLxdtaRsGTCrJdz2OssXB+9hNcIsXTozk5/2BS4=; b=mjhzpt1P4wcqnWxjxP+Rv3tE9ZL9KPAKTFVywMKSrz8CnY07OR0WjZ3E qY4kbeycamgPbmlalNEeWm0lGNVW/5QzPJL2/U3qAbCP0VxQaq0T8snYQ hBdKkeqsxKUeigAUC0mMLjwyuos1I8ylqiuJPhgWdZIGkIFpS4RbScv3J Wr8rkbbmZ15XP45xUFqRNX3CiwtwnW9BSE02lkcsuhmbM7ntc5S707ZqH Tc0wygJS0E/BDledRtTsNkTdTCykU+OMH5UiDX3B/o5qAzFgLEGCjNFfw GqjMn64l3sDIoj4PNvK/DcM6nGS+uLShSnKVKBCUTf9pIpXQ6LyfwQzIC A==; X-CSE-ConnectionGUID: GM+AcRyRTOSXp9MRlsH4Xw== X-CSE-MsgGUID: l5qi4MzeSna2pOAinMqGkg== X-IronPort-AV: E=McAfee;i="6600,9927,11085"; a="23821841" X-IronPort-AV: E=Sophos;i="6.08,195,1712646000"; d="scan'208";a="23821841" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2024 08:49:47 -0700 X-CSE-ConnectionGUID: xUG09ytvQUO4a/H5aKnuLg== X-CSE-MsgGUID: 51oDpnDuRSuik8BsYBQqGw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,195,1712646000"; d="scan'208";a="35731025" Received: from unknown (HELO localhost.localdomain) ([10.239.160.66]) by orviesa007.jf.intel.com with ESMTP; 28 May 2024 08:49:46 -0700 From: tong1.wu-at-intel.com@ffmpeg.org To: ffmpeg-devel@ffmpeg.org Date: Tue, 28 May 2024 23:47:52 +0800 Message-ID: <20240528154807.1151-1-tong1.wu@intel.com> X-Mailer: git-send-email 2.41.0.windows.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v12 01/15] avcodec/vaapi_encode: introduce a base layer for vaapi encode X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Tong Wu Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: arzirbtUzTjh From: Tong Wu Since VAAPI and future D3D12VA implementation may share some common parameters, a base layer encode context is introduced as vaapi context's base. Signed-off-by: Tong Wu --- libavcodec/hw_base_encode.h | 56 +++++++++++++++++++++++++++++++++++++ libavcodec/vaapi_encode.h | 39 +++++--------------------- 2 files changed, 63 insertions(+), 32 deletions(-) create mode 100644 libavcodec/hw_base_encode.h diff --git a/libavcodec/hw_base_encode.h b/libavcodec/hw_base_encode.h new file mode 100644 index 0000000000..ffcb6bcbb2 --- /dev/null +++ b/libavcodec/hw_base_encode.h @@ -0,0 +1,56 @@ +/* + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * FFmpeg is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with FFmpeg; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + */ + +#ifndef AVCODEC_HW_BASE_ENCODE_H +#define AVCODEC_HW_BASE_ENCODE_H + +#define MAX_DPB_SIZE 16 +#define MAX_PICTURE_REFERENCES 2 +#define MAX_REORDER_DELAY 16 +#define MAX_ASYNC_DEPTH 64 +#define MAX_REFERENCE_LIST_NUM 2 + +enum { + PICTURE_TYPE_IDR = 0, + PICTURE_TYPE_I = 1, + PICTURE_TYPE_P = 2, + PICTURE_TYPE_B = 3, +}; + +enum { + // Codec supports controlling the subdivision of pictures into slices. + FLAG_SLICE_CONTROL = 1 << 0, + // Codec only supports constant quality (no rate control). + FLAG_CONSTANT_QUALITY_ONLY = 1 << 1, + // Codec is intra-only. + FLAG_INTRA_ONLY = 1 << 2, + // Codec supports B-pictures. + FLAG_B_PICTURES = 1 << 3, + // Codec supports referencing B-pictures. + FLAG_B_PICTURE_REFERENCES = 1 << 4, + // Codec supports non-IDR key pictures (that is, key pictures do + // not necessarily empty the DPB). + FLAG_NON_IDR_KEY_PICTURES = 1 << 5, +}; + +typedef struct FFHWBaseEncodeContext { + const AVClass *class; +} FFHWBaseEncodeContext; + +#endif /* AVCODEC_HW_BASE_ENCODE_H */ + diff --git a/libavcodec/vaapi_encode.h b/libavcodec/vaapi_encode.h index 0eed9691ca..cae7af8725 100644 --- a/libavcodec/vaapi_encode.h +++ b/libavcodec/vaapi_encode.h @@ -33,34 +33,27 @@ #include "avcodec.h" #include "hwconfig.h" +#include "hw_base_encode.h" struct VAAPIEncodeType; struct VAAPIEncodePicture; +// Codec output packet without timestamp delay, which means the +// output packet has same PTS and DTS. +#define FLAG_TIMESTAMP_NO_DELAY 1 << 6 + enum { MAX_CONFIG_ATTRIBUTES = 4, MAX_GLOBAL_PARAMS = 4, - MAX_DPB_SIZE = 16, - MAX_PICTURE_REFERENCES = 2, - MAX_REORDER_DELAY = 16, MAX_PARAM_BUFFER_SIZE = 1024, // A.4.1: table A.6 allows at most 22 tile rows for any level. MAX_TILE_ROWS = 22, // A.4.1: table A.6 allows at most 20 tile columns for any level. MAX_TILE_COLS = 20, - MAX_ASYNC_DEPTH = 64, - MAX_REFERENCE_LIST_NUM = 2, }; extern const AVCodecHWConfigInternal *const ff_vaapi_encode_hw_configs[]; -enum { - PICTURE_TYPE_IDR = 0, - PICTURE_TYPE_I = 1, - PICTURE_TYPE_P = 2, - PICTURE_TYPE_B = 3, -}; - typedef struct VAAPIEncodeSlice { int index; int row_start; @@ -193,7 +186,8 @@ typedef struct VAAPIEncodeRCMode { } VAAPIEncodeRCMode; typedef struct VAAPIEncodeContext { - const AVClass *class; + // Base context. + FFHWBaseEncodeContext base; // Codec-specific hooks. const struct VAAPIEncodeType *codec; @@ -397,25 +391,6 @@ typedef struct VAAPIEncodeContext { AVPacket *tail_pkt; } VAAPIEncodeContext; -enum { - // Codec supports controlling the subdivision of pictures into slices. - FLAG_SLICE_CONTROL = 1 << 0, - // Codec only supports constant quality (no rate control). - FLAG_CONSTANT_QUALITY_ONLY = 1 << 1, - // Codec is intra-only. - FLAG_INTRA_ONLY = 1 << 2, - // Codec supports B-pictures. - FLAG_B_PICTURES = 1 << 3, - // Codec supports referencing B-pictures. - FLAG_B_PICTURE_REFERENCES = 1 << 4, - // Codec supports non-IDR key pictures (that is, key pictures do - // not necessarily empty the DPB). - FLAG_NON_IDR_KEY_PICTURES = 1 << 5, - // Codec output packet without timestamp delay, which means the - // output packet has same PTS and DTS. - FLAG_TIMESTAMP_NO_DELAY = 1 << 6, -}; - typedef struct VAAPIEncodeType { // List of supported profiles and corresponding VAAPI profiles. // (Must end with AV_PROFILE_UNKNOWN.)