From patchwork Wed May 29 15:43:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?R=C3=A9mi_Denis-Courmont?= X-Patchwork-Id: 49355 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:8f0d:0:b0:460:55fa:d5ed with SMTP id i13csp739890vqu; Wed, 29 May 2024 08:43:55 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVDtNkGX3lslaOYQxWT8r1Zt47R3yMCtvG4DhPlcm+AHRb5EfvDEbZf5IncnYFC+FUMOoA0Ijh1AGsvIWItwEZYImSxcSPzTpigrw== X-Google-Smtp-Source: AGHT+IFBNgKfMM9V2+RZntwJ71Wclo/4UtzCjNy3fKhOjMj0Vm94pkpExc2E9gYBoWB6PB3Ice6o X-Received: by 2002:a17:906:2297:b0:a65:d60c:84cf with SMTP id a640c23a62f3a-a65d60c8cd1mr58526366b.44.1716997435494; Wed, 29 May 2024 08:43:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1716997435; cv=none; d=google.com; s=arc-20160816; b=HOahEEVyslzKfpRIRu21H95NP4vfk1OosGtrkXeNjlBKdZZrW8m8pUg8e9iUxcfZKz GXroHjzsXM7mQ7QEiEfGAh07EaQLgy0s10pXRs8tpk1DBrrEISpWX0FvlYSLmruZaih3 SwlDoLEauXFVwpoCul5zmwm8sBgR184jQ6nWk3Kz+lPkSQqlK1fyV8sdtnKdqKy6gJhj lneU0fY50CXK2cmTBdhnqGvCiFe9OIh+s80y3T1K8nTOtsGpkjI8NbL28gKcGuRDcVVd pAKE42jGerqem+6Qd9+Atmhy2sSbj48XAcckdv5sIBg1DgvOIIEWEKQoMnJhFtM409id 0zkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :delivered-to; bh=p9dtqaKeV+G5QC47uPT8ZN9NhWPZIxiMdcUWnBNPJOI=; fh=YOA8vD9MJZuwZ71F/05pj6KdCjf6jQRmzLS+CATXUQk=; b=Fqu0uz0qVrlgHJnZ8WFISNT188XFJsQhLxpIUmOfq2rNcnXgMW3GuL2arU/pGx8uJI 8lsWOd4Vc1ixvHI/5MHWIxI2RpPimg33u91p6L1QL1Erf0BjA6V+BGjbM6iwTUqg0+q2 kp0Xi2hQC8v6djPcexKGOEA1WuTRAKsO+HHJNpN6543IiqPQoCQkkPiW6v8E6p8dKoeJ EbgQqM8DaN0jG+S1C7uilZh3GHpgYhFO1Fc35x2Mk4YNI2DKLKBqqcCN0+pgm3hpK22+ CTudElyDjF+BfeLExShvzNldHb4Qtl8Kl7s0WrVhb+Y3MaF60Klu4h70YZL1tdgJjCUP ZaKg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a640c23a62f3a-a626c91977fsi631240766b.266.2024.05.29.08.43.54; Wed, 29 May 2024 08:43:55 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 01B8F68D377; Wed, 29 May 2024 18:43:52 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from ursule.remlab.net (vps-a2bccee9.vps.ovh.net [51.75.19.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2C16168C197 for ; Wed, 29 May 2024 18:43:45 +0300 (EEST) Received: from basile.remlab.net (localhost [IPv6:::1]) by ursule.remlab.net (Postfix) with ESMTP id 958BDC006D for ; Wed, 29 May 2024 18:43:44 +0300 (EEST) From: =?utf-8?q?R=C3=A9mi_Denis-Courmont?= To: ffmpeg-devel@ffmpeg.org Date: Wed, 29 May 2024 18:43:44 +0300 Message-ID: <20240529154344.38880-1-remi@remlab.net> X-Mailer: git-send-email 2.45.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] checkasm: add linear least square tests X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: UD1guNVDO3Qz --- tests/checkasm/Makefile | 1 + tests/checkasm/checkasm.c | 1 + tests/checkasm/checkasm.h | 1 + tests/checkasm/lls.c | 101 ++++++++++++++++++++++++++++++++++++++ tests/fate/checkasm.mak | 1 + 5 files changed, 105 insertions(+) create mode 100644 tests/checkasm/lls.c diff --git a/tests/checkasm/Makefile b/tests/checkasm/Makefile index 1dc770e9da..6eb94d10d5 100644 --- a/tests/checkasm/Makefile +++ b/tests/checkasm/Makefile @@ -71,6 +71,7 @@ CHECKASMOBJS-$(CONFIG_SWSCALE) += $(SWSCALEOBJS) AVUTILOBJS += av_tx.o AVUTILOBJS += fixed_dsp.o AVUTILOBJS += float_dsp.o +AVUTILOBJS += lls.o CHECKASMOBJS-$(CONFIG_AVUTIL) += $(AVUTILOBJS) diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c index 97c9b9fdd4..d7aa2a9c09 100644 --- a/tests/checkasm/checkasm.c +++ b/tests/checkasm/checkasm.c @@ -254,6 +254,7 @@ static const struct { #if CONFIG_AVUTIL { "fixed_dsp", checkasm_check_fixed_dsp }, { "float_dsp", checkasm_check_float_dsp }, + { "lls", checkasm_check_lls }, { "av_tx", checkasm_check_av_tx }, #endif { NULL } diff --git a/tests/checkasm/checkasm.h b/tests/checkasm/checkasm.h index a42645c4ae..211d7f52e6 100644 --- a/tests/checkasm/checkasm.h +++ b/tests/checkasm/checkasm.h @@ -105,6 +105,7 @@ void checkasm_check_huffyuvdsp(void); void checkasm_check_idctdsp(void); void checkasm_check_jpeg2000dsp(void); void checkasm_check_llauddsp(void); +void checkasm_check_lls(void); void checkasm_check_llviddsp(void); void checkasm_check_llviddspenc(void); void checkasm_check_lpc(void); diff --git a/tests/checkasm/lls.c b/tests/checkasm/lls.c new file mode 100644 index 0000000000..a2e8f11f99 --- /dev/null +++ b/tests/checkasm/lls.c @@ -0,0 +1,101 @@ +/* + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * FFmpeg is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License along + * with FFmpeg; if not, write to the Free Software Foundation, Inc., + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. + */ + +#include +#include "libavutil/lls.h" +#include "checkasm.h" + +#define randomize_buffer(buf) \ +do { \ + double bmg[2], stddev = 10.0; \ + \ + for (size_t i = 0; i < MAX_VARS; i += 2) { \ + av_bmg_get(&checkasm_lfg, bmg); \ + buf[i] = bmg[0] * stddev; \ + buf[i + 1] = bmg[1] * stddev; \ + } \ +} while(0); + +static void test_update(LLSModel *lls, const double *var) +{ + double refcovar[MAX_VARS][MAX_VARS]; + declare_func(void, LLSModel *, const double *); + + call_ref(lls, var); + + for (size_t i = 0; i < MAX_VARS; i++) + for (size_t j = 0; j < MAX_VARS; j++) + refcovar[i][j] = lls->covariance[i][j]; + + memset(lls->covariance, 0, sizeof (lls->covariance)); + call_new(lls, var); + + for (size_t i = 0; i < lls->indep_count; i++) + for (size_t j = i; j < lls->indep_count; j++) + if (!double_near_abs_eps(refcovar[i][j], lls->covariance[i][j], + 2 * DBL_EPSILON)) { + fprintf(stderr, "%zu, %zu: %- .12f - %- .12f = % .12g\n", i, j, + refcovar[i][j], lls->covariance[i][j], + refcovar[i][j] - lls->covariance[i][j]); + fail(); + } + + bench_new(lls, var); +} + +#define EPS 0.2 +static void test_evaluate(LLSModel *lls, const double *param, int order) +{ + double refprod, newprod; + declare_func_float(double, LLSModel *, const double *, int); + + refprod = call_ref(lls, param, order); + newprod = call_new(lls, param, order); + + if (!double_near_abs_eps(refprod, newprod, EPS)) { + fprintf(stderr, "%- .12f - %- .12f = % .12g\n", + refprod, newprod, refprod - newprod); + fail(); + } + + if (order == lls->indep_count) + bench_new(lls, param, order); +} + +void checkasm_check_lls(void) +{ + static const unsigned char counts[] = { 8, 12, MAX_VARS, }; + + for (size_t i = 0; i < FF_ARRAY_ELEMS(counts); i++) { + LOCAL_ALIGNED_32(double, var, [MAX_VARS]); + LOCAL_ALIGNED_32(double, param, [MAX_VARS]); + LLSModel lls; + + avpriv_init_lls(&lls, counts[i]); + randomize_buffer(var); + randomize_buffer(param); + + if (check_func(lls.update_lls, "update_lls_%d", counts[i])) + test_update(&lls, var); + for (size_t j = 0; j <= i; j++) + if (check_func(lls.evaluate_lls, "evaluate_lls_%d_%d", counts[i], + counts[j])) + test_evaluate(&lls, param, counts[j]); + } + report("lls"); +} diff --git a/tests/fate/checkasm.mak b/tests/fate/checkasm.mak index 8d2705165a..9490aef154 100644 --- a/tests/fate/checkasm.mak +++ b/tests/fate/checkasm.mak @@ -28,6 +28,7 @@ FATE_CHECKASM = fate-checkasm-aacencdsp \ fate-checkasm-idctdsp \ fate-checkasm-jpeg2000dsp \ fate-checkasm-llauddsp \ + fate-checkasm-lls \ fate-checkasm-llviddsp \ fate-checkasm-llviddspenc \ fate-checkasm-lpc \