diff mbox series

[FFmpeg-devel] codec_desc: drop INTRA_ONLY flag for AAC

Message ID 20240602171601.1953119-1-dev@lynne.ee
State New
Headers show
Series [FFmpeg-devel] codec_desc: drop INTRA_ONLY flag for AAC | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 fail Make fate failed
andriy/make_x86 success Make finished
andriy/make_fate_x86 fail Make fate failed

Commit Message

Lynne June 2, 2024, 5:15 p.m. UTC
Not valid anymore with xHE-AAC.
---
 libavcodec/codec_desc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Michael Niedermayer June 4, 2024, 12:22 a.m. UTC | #1
On Sun, Jun 02, 2024 at 07:15:54PM +0200, Lynne via ffmpeg-devel wrote:
> Not valid anymore with xHE-AAC.
> ---
>  libavcodec/codec_desc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

breaks fate

--- ./tests/ref/fate/mkv	2024-06-03 22:55:42.149081056 +0200
+++ tests/data/fate/mkv	2024-06-04 02:21:45.904176579 +0200
@@ -13,215 +13,215 @@
 0,        -42,          0,       41,    63501, 0x139d4c99
 0,          0,         84,       41,     5368, 0xd964b678, F=0x0
 1,          8,          8,       21,      528, 0x3c990ddf
-1,         29,         29,       21,      510, 0xc16e0719
+1,         29,         29,       21,      510, 0xc16e0719, F=0x0
 0,         42,         42,       41,     1840, 0x097b6726, F=0x0
-1,         50,         50,       21,      500, 0x6248f603
-1,         71,         71,       22,      491, 0xe767f705
+1,         50,         50,       21,      500, 0x6248f603, F=0x0
+1,         71,         71,       22,      491, 0xe767f705, F=0x0
 0,         84,        167,       41,     7168, 0xaa5913ed, F=0x0

...

thx


[...]
diff mbox series

Patch

diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c
index a28ef68061..a3b983b907 100644
--- a/libavcodec/codec_desc.c
+++ b/libavcodec/codec_desc.c
@@ -2697,7 +2697,7 @@  static const AVCodecDescriptor codec_descriptors[] = {
         .type      = AVMEDIA_TYPE_AUDIO,
         .name      = "aac",
         .long_name = NULL_IF_CONFIG_SMALL("AAC (Advanced Audio Coding)"),
-        .props     = AV_CODEC_PROP_INTRA_ONLY | AV_CODEC_PROP_LOSSY,
+        .props     = AV_CODEC_PROP_LOSSY,
         .profiles  = NULL_IF_CONFIG_SMALL(ff_aac_profiles),
     },
     {
@@ -3031,7 +3031,7 @@  static const AVCodecDescriptor codec_descriptors[] = {
         .type      = AVMEDIA_TYPE_AUDIO,
         .name      = "aac_latm",
         .long_name = NULL_IF_CONFIG_SMALL("AAC LATM (Advanced Audio Coding LATM syntax)"),
-        .props     = AV_CODEC_PROP_INTRA_ONLY | AV_CODEC_PROP_LOSSY,
+        .props     = AV_CODEC_PROP_LOSSY,
         .profiles  = NULL_IF_CONFIG_SMALL(ff_aac_profiles),
     },
     {