From patchwork Sat Jun 8 23:10:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 49710 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:c209:0:b0:460:55fa:d5ed with SMTP id d9csp1781672vqo; Sat, 8 Jun 2024 16:11:09 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXVzrZxTcz3l+36HfnCpaePdv8phFVNSe3OlcxTF90Mdh5fDCpYis+bYY1dsLaIO0RbcOOOQ9LyTvQCqiyt7prLBpVPPn5uNmNapg== X-Google-Smtp-Source: AGHT+IEowZNt+OgzWoffiScI2fKPVIG5ZFyKguHEYBT1N9g/+ZTOpTEw8i2BVopjAuFYUDcI8fxa X-Received: by 2002:a05:6512:15a0:b0:522:2a2c:759e with SMTP id 2adb3069b0e04-52bb9f5de1bmr4924252e87.6.1717888268780; Sat, 08 Jun 2024 16:11:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1717888268; cv=none; d=google.com; s=arc-20160816; b=zzwXZsUW+yQ1x4Pg6j61FOU416fICexpq5LrbGf1jkJ6wbrWWkYHEu0jDGAOjwqYE+ D4I2r8XlMViIaO7gixTiiU6h+4uf47ThDG2059n1xfBPa752T0b+UEDcMKGAlcKvWV27 BMAdpSKx1M3LMgM/CfXxnCvWpiKy5cRqtcSyfI0lJ9QT0QfLV3jWU6OmQKDOlfkx3eKE xybCTYlR8JoAIw4UeQGkARCiItzG3mrvrVRKDNJcjqZToCsgjjxA8MD4jZV3d4gKZa0V u8jLhdsSsQxY9Zis+f7ct1xyJVxqxcw+q5I6+DHYwhY7Gf6tSCbQVgaQg47CXyB1EvqC Wk1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=aSjPt664TvAPUebO9yt9Fxt/qTgjKThe69UnKwEUKtI=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=bvmH//i1udQO8h/U6sKuhFhYnS7aGNql764tug3rhmJDqPkiKtcxPRp6EWV9G5vGNI oDb8jD+BkRpnKLRbUMKjGimVQ9vtQKxLoqwOBvyIrlTGoBSyk8N9S6L4k8oPCW3Vj5N2 R9a4GuXWcO+6Fw7L/htuQLso09ufCDapAbV/eu3Kz4W/G3ikxxYkbqZUo4/jQu2j0nOP vyPucW8rbR5m/QzS/y3EaqgoQ+Ra+OeoU88jDS7oaUGKuQSO4ye3eO5/GY4hPslFsI0M wW5Bg0pQ5grZrsDbMLwHMoFQYaZHbcBnOhYXY6tioqTC/058yFPHXaaeSgsmWvXJgNtG vBLw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=OLeBvZei; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a640c23a62f3a-a6efcbf7f50si116773666b.89.2024.06.08.16.11.08; Sat, 08 Jun 2024 16:11:08 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=OLeBvZei; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1032A68D726; Sun, 9 Jun 2024 02:10:57 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6A33F68D709 for ; Sun, 9 Jun 2024 02:10:49 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id AADEBE0002 for ; Sat, 8 Jun 2024 23:10:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1717888248; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uOjFkGXjUuIh4YvH2v3HgmrWO8bZ0Eq9e6+E73eIUiw=; b=OLeBvZei2hd//hSj708Jk9GXbe4mUm9c/kzhrIZcQoLlOwTCAT9+NzOTx1CeyJcV+MJkPs DkXjir7mrSTpwN7gfentTwoJCqdoKJJrASPOI10DXCOJZqD8LNzavLHISgxpFblLSNIRem fYjuKFencWmr/33aKOTw55FQM+oAxfcCE5dzcPaxWHKm/x7jwqELOIMhhF0dKAOQ1l21J7 5T5XEMMGIqi0C83nmLW4tD7E3zrgfXTEO153CzmlCwDOqRP7x3jW2jUxjuFJGKkR3ARLfS RTPsZwobtNVaS27os9dlm59joZo9uzLhgckzvPe/zQCBEKzNJ8buEBDWS5kX1Q== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Sun, 9 Jun 2024 01:10:39 +0200 Message-ID: <20240608231046.3619551-2-michael@niedermayer.cc> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240608231046.3619551-1-michael@niedermayer.cc> References: <20240608231046.3619551-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 2/9] avformat/rtsp: use < 0 for error check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: juFS+DPnxLNT Found while reviewing CID1473532 Uninitialized scalar variable Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/rtsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index db78735c7ae..28c858077ad 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -1429,7 +1429,7 @@ retry: cur_auth_type = rt->auth_state.auth_type; if ((ret = rtsp_send_cmd_with_content_async(s, method, url, header, send_content, - send_content_length))) + send_content_length)) < 0) return ret; if ((ret = ff_rtsp_read_reply(s, reply, content_ptr, 0, method) ) < 0)